From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/2] ARM64: dts: meson-gx: move the SCPI and SRAM nodes to meson-gx
Date: Thu, 24 Nov 2016 15:38:09 +0100 [thread overview]
Message-ID: <02a1021b-401c-1f3b-f911-25de60dab889@baylibre.com> (raw)
In-Reply-To: <20161123162040.24843-2-martin.blumenstingl@googlemail.com>
On 11/23/2016 05:20 PM, Martin Blumenstingl wrote:
> SCPI and SRAM are identical on GXBB and GXL. Moving the corresponding
> nodes to meson-gx adds support for the thermal sensor on GXL based
> devices.
> While here, also rename the second compatible string because
> "arm,legacy-scpi" was replaced by "arm,scpi-pre-1.0".
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 45 +++++++++++++++++++++++
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 57 -----------------------------
> 2 files changed, 45 insertions(+), 57 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index fc033c0..47ab306 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -65,6 +65,7 @@
> reg = <0x0 0x0>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu1: cpu at 1 {
> @@ -73,6 +74,7 @@
> reg = <0x0 0x1>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu2: cpu at 2 {
> @@ -81,6 +83,7 @@
> reg = <0x0 0x2>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu3: cpu at 3 {
> @@ -89,6 +92,7 @@
> reg = <0x0 0x3>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> l2: l2-cache0 {
> @@ -153,6 +157,28 @@
> };
> };
>
> + scpi {
> + compatible = "amlogic,meson-gxbb-scpi", "arm,scpi-pre-1.0";
> + mboxes = <&mailbox 1 &mailbox 2>;
> + shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
> +
> + clocks {
> + compatible = "arm,scpi-clocks";
> +
> + scpi_dvfs: scpi_clocks at 0 {
> + compatible = "arm,scpi-dvfs-clocks";
> + #clock-cells = <1>;
> + clock-indices = <0>;
> + clock-output-names = "vcpu";
> + };
> + };
> +
> + scpi_sensors: sensors {
> + compatible = "arm,scpi-sensors";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <2>;
> @@ -264,6 +290,25 @@
> #address-cells = <0>;
> };
>
> + sram: sram at c8000000 {
> + compatible = "amlogic,meson-gxbb-sram", "mmio-sram";
> + reg = <0x0 0xc8000000 0x0 0x14000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x0 0xc8000000 0x14000>;
> +
> + cpu_scp_lpri: scp-shmem at 0 {
> + compatible = "amlogic,meson-gxbb-scp-shmem";
> + reg = <0x13000 0x400>;
> + };
> +
> + cpu_scp_hpri: scp-shmem at 200 {
> + compatible = "amlogic,meson-gxbb-scp-shmem";
> + reg = <0x13400 0x400>;
> + };
> + };
> +
> aobus: aobus at c8100000 {
> compatible = "simple-bus";
> reg = <0x0 0xc8100000 0x0 0x100000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index ac5ad3b..76465e7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -50,28 +50,6 @@
> / {
> compatible = "amlogic,meson-gxbb";
>
> - scpi {
> - compatible = "amlogic,meson-gxbb-scpi";
> - mboxes = <&mailbox 1 &mailbox 2>;
> - shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
> -
> - clocks {
> - compatible = "arm,scpi-clocks";
> -
> - scpi_dvfs: scpi_clocks at 0 {
> - compatible = "arm,scpi-dvfs-clocks";
> - #clock-cells = <1>;
> - clock-indices = <0>;
> - clock-output-names = "vcpu";
> - };
> - };
> -
> - scpi_sensors: sensors {
> - compatible = "arm,scpi-sensors";
> - #thermal-sensor-cells = <1>;
> - };
> - };
> -
> soc {
> usb0_phy: phy at c0000000 {
> compatible = "amlogic,meson-gxbb-usb2-phy";
> @@ -93,25 +71,6 @@
> status = "disabled";
> };
>
> - sram: sram at c8000000 {
> - compatible = "amlogic,meson-gxbb-sram", "mmio-sram";
> - reg = <0x0 0xc8000000 0x0 0x14000>;
> -
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0 0x0 0xc8000000 0x14000>;
> -
> - cpu_scp_lpri: scp-shmem at 0 {
> - compatible = "amlogic,meson-gxbb-scp-shmem";
> - reg = <0x13000 0x400>;
> - };
> -
> - cpu_scp_hpri: scp-shmem at 200 {
> - compatible = "amlogic,meson-gxbb-scp-shmem";
> - reg = <0x13400 0x400>;
> - };
> - };
> -
> usb0: usb at c9000000 {
> compatible = "amlogic,meson-gxbb-usb", "snps,dwc2";
> reg = <0x0 0xc9000000 0x0 0x40000>;
> @@ -138,22 +97,6 @@
> };
> };
>
> -&cpu0 {
> - clocks = <&scpi_dvfs 0>;
> -};
> -
> -&cpu1 {
> - clocks = <&scpi_dvfs 0>;
> -};
> -
> -&cpu2 {
> - clocks = <&scpi_dvfs 0>;
> -};
> -
> -&cpu3 {
> - clocks = <&scpi_dvfs 0>;
> -};
> -
> &cbus {
> spifc: spi at 8c80 {
> compatible = "amlogic,meson-gxbb-spifc";
>
Tested successfully on my P200 (S905) and Nexbox A95X (S905X)
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
So
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2016-11-24 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 16:20 [PATCH 0/2] minor GXL and GXM improvements Martin Blumenstingl
2016-11-23 16:20 ` [PATCH 1/2] ARM64: dts: meson-gx: move the SCPI and SRAM nodes to meson-gx Martin Blumenstingl
2016-11-24 14:38 ` Neil Armstrong [this message]
2016-11-23 16:20 ` [PATCH 2/2] ARM64: dts: meson-gxm: add SCPI configuration for GXM Martin Blumenstingl
2016-11-24 14:38 ` Neil Armstrong
2016-11-28 19:08 ` [PATCH 0/2] minor GXL and GXM improvements Kevin Hilman
2016-12-02 23:08 ` [PATCH v2 0/2] GXL and GXM SCPI improvements Martin Blumenstingl
2016-12-02 23:08 ` [PATCH v2 1/2] ARM64: dts: meson-gx: move the SCPI and SRAM nodes to meson-gx Martin Blumenstingl
2016-12-02 23:08 ` [PATCH v2 2/2] ARM64: dts: meson-gxm: add SCPI configuration for GXM Martin Blumenstingl
2016-12-09 4:39 ` [PATCH v2 0/2] GXL and GXM SCPI improvements Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a1021b-401c-1f3b-f911-25de60dab889@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®