From: Heiner Kallweit <hkallweit1@gmail.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
Alan Stern <stern@rowland.harvard.edu>,
Jack Pham <quic_jackp@quicinc.com>,
Tung Nguyen <tunguyen@apm.com>
Subject: [PATCH v2 0/5] usb: host: xhci-plat: omit shared hcd if either of the root hubs has no ports
Date: Wed, 16 Mar 2022 23:08:15 +0100 [thread overview]
Message-ID: <0684616b-5cc0-e9f6-7015-ce709c6d4386@gmail.com> (raw)
I have a system with a low-cost Amlogic S905W SoC that supports USB3
but has a USB3 root hub with no ports. This results in an error
message and a hcd that is good for nothing. The USB2 root hub has
ports and works normally.
I think we can do better and omit creating a shared hcd if either of
the root hubs has no ports. This series is based on discussion [0].
The series works as intended for me. What I couldn't test is the case
of the USB2 root hub having no ports.
Follow-up to this series could be applying the xhci-plat extension
to other xhci drivers.
[0] https://www.spinics.net/lists/linux-usb/msg223416.html
v2:
- reordered patches
- create new helper xhci_has_one_roothub() instead of using
xhci_hcd->needs_shared_hcd (proposed by Mathias)
Heiner Kallweit (5):
xhci: factor out parts of xhci_gen_setup()
xhci: prepare for operation w/o shared hcd
usb: host: xhci-plat: create shared hcd after having added main hcd
usb: host: xhci-plat: prepare operation w/o shared hcd
usb: host: xhci-plat: omit shared hcd if either root hub has no ports
drivers/usb/host/xhci-hub.c | 3 +-
drivers/usb/host/xhci-mem.c | 11 +--
drivers/usb/host/xhci-plat.c | 46 +++++++----
drivers/usb/host/xhci.c | 155 ++++++++++++++++++++---------------
drivers/usb/host/xhci.h | 26 ++++++
5 files changed, 149 insertions(+), 92 deletions(-)
--
2.35.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2022-03-16 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 22:08 Heiner Kallweit [this message]
2022-03-16 22:09 ` [PATCH v2 1/5] xhci: factor out parts of xhci_gen_setup() Heiner Kallweit
2022-03-16 22:09 ` [PATCH v2 2/5] xhci: prepare for operation w/o shared hcd Heiner Kallweit
2022-03-16 22:10 ` [PATCH v2 3/5] usb: host: xhci-plat: create shared hcd after having added main hcd Heiner Kallweit
2022-03-16 22:11 ` [PATCH v2 4/5] usb: host: xhci-plat: prepare operation w/o shared hcd Heiner Kallweit
2022-06-08 20:55 ` Matthias Kaehlcke
2022-06-09 11:38 ` Mathias Nyman
2022-06-09 12:03 ` [RFT PATCH] xhci: Fix null pointer dereference in resume if xhci has only one roothub Mathias Nyman
2022-06-09 15:41 ` Matthias Kaehlcke
2022-06-10 8:17 ` Mathias Nyman
2022-06-09 15:10 ` [PATCH v2 4/5] usb: host: xhci-plat: prepare operation w/o shared hcd Matthias Kaehlcke
2022-03-16 22:12 ` [PATCH v2 5/5] usb: host: xhci-plat: omit shared hcd if either root hub has no ports Heiner Kallweit
2022-03-24 9:23 ` [PATCH v2 0/5] usb: host: xhci-plat: omit shared hcd if either of the root hubs " Mathias Nyman
2022-03-24 19:38 ` Heiner Kallweit
2022-03-24 20:46 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0684616b-5cc0-e9f6-7015-ce709c6d4386@gmail.com \
--to=hkallweit1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=quic_jackp@quicinc.com \
--cc=stern@rowland.harvard.edu \
--cc=tunguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®