From: Zelong Dong <Zelong.Dong@amlogic.com>
To: neil.armstrong@linaro.org, Philipp Zabel <p.zabel@pengutronix.de>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, kelvin.zhang@amlogic.com
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller
Date: Tue, 12 Sep 2023 14:37:59 +0800 [thread overview]
Message-ID: <076b59c0-7585-ea98-014c-cd70f92df002@amlogic.com> (raw)
In-Reply-To: <55cbdbba-39c6-7415-37db-97d2c35412cb@linaro.org>
在 2023/7/31 17:17, Neil Armstrong 写道:
> On 28/07/2023 17:49, Philipp Zabel wrote:
>> On Mi, 2023-07-19 at 14:09 +0800, zelong dong wrote:
>>> From: Zelong Dong <zelong.dong@amlogic.com>
>>>
>>> Add new compatible and DT bindings for Amlogic C3 Reset Controller
>>>
>>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>>> ---
>>> .../bindings/reset/amlogic,meson-reset.yaml | 1 +
>>> include/dt-bindings/reset/amlogic,c3-reset.h | 119 ++++++++++++++++++
>>> 2 files changed, 120 insertions(+)
>>> create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> index d3fdee89d4f8..f0c6c0df0ce3 100644
>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> @@ -18,6 +18,7 @@ properties:
>>> - amlogic,meson-axg-reset # Reset Controller on AXG and
>>> compatible SoCs
>>> - amlogic,meson-a1-reset # Reset Controller on A1 and
>>> compatible SoCs
>>> - amlogic,meson-s4-reset # Reset Controller on S4 and
>>> compatible SoCs
>>> + - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>>
>>> reg:
>>> maxItems: 1
>>> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h
>>> b/include/dt-bindings/reset/amlogic,c3-reset.h
>>> new file mode 100644
>>> index 000000000000..d9127863f603
>>> --- /dev/null
>>> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h
>>
>> Given that this is only included by
>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be
>> moved to arch/arm64/boot/dts/amlogic ?
>
> Maybe I missed something, but since when should we move bindings headers
> to arch/xxx/boot/dts/vendor ?
>
> Neil
>
>>
>> regards
>> Philipp
>
Hi,
It's been a while, how will we deal with this patch ?
Should we let this patch apply first? If Amlogic reset bindings headers
need to be moved to arch/xxx/boot/dts/vendor, could we apply it in a
separate change?
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-09-12 6:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 6:09 [PATCH v3 0/3] reset: amlogic-c3: add reset driver zelong dong
2023-07-19 6:09 ` [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller zelong dong
2023-07-19 7:41 ` Krzysztof Kozlowski
2023-07-19 11:50 ` Dmitry Rokosov
2023-07-19 12:33 ` Krzysztof Kozlowski
2023-07-19 14:11 ` Dmitry Rokosov
2023-07-28 15:49 ` Philipp Zabel
2023-07-28 16:40 ` Krzysztof Kozlowski
2023-07-31 8:08 ` Neil Armstrong
2023-07-31 8:09 ` Neil Armstrong
2023-07-31 9:10 ` Zelong Dong
2023-07-31 9:17 ` Neil Armstrong
2023-09-12 6:37 ` Zelong Dong [this message]
2023-09-12 8:36 ` neil.armstrong
2023-07-19 6:09 ` [PATCH v3 2/3] reset: reset-meson: add support for Amlogic C3 SoC " zelong dong
2023-07-19 6:09 ` [PATCH v3 3/3] arm64: dts: amlogic: add reset controller for Amlogic C3 SoC zelong dong
2023-07-19 11:52 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076b59c0-7585-ea98-014c-cd70f92df002@amlogic.com \
--to=zelong.dong@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®