From: thomas.langer@intel.com (Langer, Thomas)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 1/3] iio: adc: meson-saradc: mark all meson_sar_adc_data static and const
Date: Thu, 4 May 2017 19:07:24 +0000 [thread overview]
Message-ID: <0DAF21CFE1B20740AE23D6AF6E54843F1E8BCDB2@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20170504180136.27025-2-martin.blumenstingl@googlemail.com>
Hello Martin,
>
> These are only passed as of_device_id.data and never modified. Thus we
> can mark them as static const, just like the of_device_id instances
> where they are used.
Here you talk about static const, but in the code below the const is missing.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/iio/adc/meson_saradc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c
> b/drivers/iio/adc/meson_saradc.c
> index dd4190b50df6..1cb5df306001 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -834,17 +834,17 @@ static const struct iio_info meson_sar_adc_iio_info
> = {
> .driver_module = THIS_MODULE,
> };
>
> -struct meson_sar_adc_data meson_sar_adc_gxbb_data = {
> +static struct meson_sar_adc_data meson_sar_adc_gxbb_data = {
> .resolution = 10,
> .name = "meson-gxbb-saradc",
> };
>
> -struct meson_sar_adc_data meson_sar_adc_gxl_data = {
> +static struct meson_sar_adc_data meson_sar_adc_gxl_data = {
> .resolution = 12,
> .name = "meson-gxl-saradc",
> };
>
> -struct meson_sar_adc_data meson_sar_adc_gxm_data = {
> +static struct meson_sar_adc_data meson_sar_adc_gxm_data = {
> .resolution = 12,
> .name = "meson-gxm-saradc",
> };
> --
> 2.12.2
>
next prev parent reply other threads:[~2017-05-04 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 18:01 [PATCH v3 0/3] Meson8 / Meson8b support for the meson_saradc driver Martin Blumenstingl
2017-05-04 18:01 ` [PATCH v3 1/3] iio: adc: meson-saradc: mark all meson_sar_adc_data static and const Martin Blumenstingl
2017-05-04 19:07 ` Langer, Thomas [this message]
2017-05-05 21:17 ` Martin Blumenstingl
2017-05-04 18:01 ` [PATCH v3 2/3] dt-bindings: iio: adc: add Meson8 and Meson8b support Martin Blumenstingl
2017-05-04 18:01 ` [PATCH v3 3/3] iio: adc: meson-saradc: add Meson8b SoC compatibility Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DAF21CFE1B20740AE23D6AF6E54843F1E8BCDB2@IRSMSX101.ger.corp.intel.com \
--to=thomas.langer@intel.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®