From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69BE8C79F9D for ; Mon, 5 Jan 2026 15:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VzL1sww7GCpPUyCeW2wLIbVVQg519IVPV1Iw5nvvnVE=; b=vo95x0oN8BB8WOwoD9Tj5NDBkv yjfDdRTh0XYRxpl6kWDLz3ltT//z24FwDolHdGSApFDhnuXDCLcRmaLPNWvIzulpl+GWPdU/Jh/S3 WKcE0EhJO/2vWAomEwL2exN6Q/0F1D+ydJ9L0M+WybbJHcUF/iphUL91/DYj43Tdl7ZGL7Eey8GHh Xa0h4TiPlj4s5SzzQLeus6V6aBiU99it337sdTXPMHO1JFZvdHFqyLSOphUtjAeJk3J2EwrrJasof meeezW3RIHhqOtZgRGKZNAR74gvJGvHzglGG8gugt01Ka5eVg+kZCMQXCTzQ94936P5VrgG4O6D8v ilayUhVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcmBd-0000000BaZI-2z68; Mon, 05 Jan 2026 15:08:01 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcmBZ-0000000BaXT-2uXH for linux-amlogic@lists.infradead.org; Mon, 05 Jan 2026 15:07:59 +0000 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so18295e9.3 for ; Mon, 05 Jan 2026 07:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767625676; x=1768230476; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=DJeP3umUUPJKCdZprAUZ1ZTfLiCOqec4hH3IqgMAE2k=; b=KcKFNqLejGDM/u62ZnFccOIVNB4NvHm9Pyowkt5Cm0tobX+QH/fgyyDVFjKzWcinyI agwPISDZlZN/1dt5maDA++vdHdoaj4cimxbfm02gkeaXTi25w78CDbwZ5wGED5eWGptV xVuLk6AyfK6SJq8m16GOtMaLGae6fZYvS80qY8PqO/+xx7R2VfnidW3vQVqxrDG+TVpF pOSt5cY3RgwmvTPYb4UhlIchaguBj/februQLLH9Q7Gdm9z3cZDP6ZDWxDC74HNU8F6+ Sa82+5E18DbPbnK0PM80oJtOYgjjcA+KSN5BtPPgsn98jYmLcD52gkNe3KwfGksQOaFQ hlcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767625676; x=1768230476; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJeP3umUUPJKCdZprAUZ1ZTfLiCOqec4hH3IqgMAE2k=; b=HSknRSZWQB1w0aDf5Gqzq9k5HK3mzBC71Xc9mSGdl2OpXnugCf+VEE2vjt7p9/aPsm xnyWWa5iSPKJOzXWBzFhhR8/OJsZqJKT+jglJziW6bMrrgrBfMHSNOL6u8NBVxhTaYbs +FkI7IxPAH1m4zHA3+16edzNyTy8uoceuL2Ybunyk2LAvtGJWgbAY7TR9gFCJ+XAp1yH 9ePx8iFPzIcSW4g/RwQr/Z8YdiNhY6sLfBCFfyDWXY+0TKpzeJfwyZj/wU8hFtA7FZ7J lKvToQIWarWZk9drYH1d2sdh/ZIawAJTldmVQqLL22ISn41sgh+3WcMqey1Wyp7G3Ciu 5gHw== X-Forwarded-Encrypted: i=1; AJvYcCUKcC3CUDr92ui0hf8tAskNDkcjXnFSEZjNatHwvM0Mlu4JWT2lF6amiS4S24u1uE5DK92hSWpbxfYFk+SF@lists.infradead.org X-Gm-Message-State: AOJu0Yxyr/avUQf/2wQve5CGLKGrUk76KP/ouT6crp//Fhx0JLLsqbMh 9lC+sp0PPFIILDEBgL1AGv7cAX/yyB1OEOjzaYe+3eEjDu7CQZbhxH1kaH3Y/5tqMxo= X-Gm-Gg: AY/fxX6N6uHedsXYqX0Kh1SEfdEscxhYB4eD1uSPCCt1S/gZ82BpYLKWmOOx/nHS5uz oq19cx8IRqeUZ2jCrSeOpoGmSYTVAO2Zukke62RkCjWBkwSRlAe949ndeLKfC3rHnyGTFSFkOBI y8KYviWj5g/6BjBOsAl3gjE6YfNZ7Gkepa1vlejedMoD44wYGt3M6F1NUH78H9wUDTovXm4EiO2 ob6COHKOU6L6Y60yuVoGOFgmqxOTMhyGDvC9aPE3/p6OmT8F5e0rEuHXh5MVp/BKCbnqO17bYZ2 rOG4stdomWUYIgrCP/AlMNv9NYEbfuJNsbkw4RjJjGWWe4MaJMXhV7yrkG5XyAUu4DU7ZHGU72/ l0MnbXRgeTdmLhCDw0N92iA2FHgQJG2nEOhXG53S2QbzzX7NW3WIkf6LTGMtgNLISltGscdrCQy ynOPId2VQ+ii8lacZKtCWUBxTZZ+W650+eF/fg11cxM9N/t3bY4RNA/wfRZ+hr3S0= X-Google-Smtp-Source: AGHT+IHNPKjsE1L43Mcol0BPhYCu+RrWOpaqpZKfNqq23wdaZg/I9TTFl/xgV8vj8QWVD5+5pya8pQ== X-Received: by 2002:a05:600c:5249:b0:456:1a69:94fa with SMTP id 5b1f17b1804b1-47d1954a128mr636773765e9.13.1767625675529; Mon, 05 Jan 2026 07:07:55 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d4c1:5589:eadb:1033? ([2a01:e0a:3d9:2080:d4c1:5589:eadb:1033]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7443c04csm35338465e9.1.2026.01.05.07.07.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 07:07:55 -0800 (PST) Message-ID: <0a457882-1700-4edd-ba86-3682b05731f0@linaro.org> Date: Mon, 5 Jan 2026 16:07:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping To: Bartosz Golaszewski , Linus Walleij , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marek Szyprowski References: <20260105150509.56537-1-bartosz.golaszewski@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260105150509.56537-1-bartosz.golaszewski@oss.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260105_070757_774855_F28A7423 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 1/5/26 16:05, Bartosz Golaszewski wrote: > The GPIO controller is configured as non-sleeping but it uses generic > pinctrl helpers which use a mutex for synchronization. > > This can cause the following lockdep splat with shared GPIOs enabled on > boards which have multiple devices using the same GPIO: > > BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:591 > in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 142, name: > kworker/u25:3 > preempt_count: 1, expected: 0 > RCU nest depth: 0, expected: 0 > INFO: lockdep is turned off. > irq event stamp: 46379 > hardirqs last enabled at (46379): [] > _raw_spin_unlock_irqrestore+0x74/0x78 > hardirqs last disabled at (46378): [] > _raw_spin_lock_irqsave+0x84/0x88 > softirqs last enabled at (46330): [] > handle_softirqs+0x4c4/0x4dc > softirqs last disabled at (46295): [] > __do_softirq+0x14/0x20 > CPU: 1 UID: 0 PID: 142 Comm: kworker/u25:3 Tainted: G C > 6.19.0-rc4-next-20260105+ #11963 PREEMPT > Tainted: [C]=CRAP > Hardware name: Khadas VIM3 (DT) > Workqueue: events_unbound deferred_probe_work_func > Call trace: > show_stack+0x18/0x24 (C) > dump_stack_lvl+0x90/0xd0 > dump_stack+0x18/0x24 > __might_resched+0x144/0x248 > __might_sleep+0x48/0x98 > __mutex_lock+0x5c/0x894 > mutex_lock_nested+0x24/0x30 > pinctrl_get_device_gpio_range+0x44/0x128 > pinctrl_gpio_set_config+0x40/0xdc > gpiochip_generic_config+0x28/0x3c > gpio_do_set_config+0xa8/0x194 > gpiod_set_config+0x34/0xfc > gpio_shared_proxy_set_config+0x6c/0xfc [gpio_shared_proxy] > gpio_do_set_config+0xa8/0x194 > gpiod_set_transitory+0x4c/0xf0 > gpiod_configure_flags+0xa4/0x480 > gpiod_find_and_request+0x1a0/0x574 > gpiod_get_index+0x58/0x84 > devm_gpiod_get_index+0x20/0xb4 > devm_gpiod_get+0x18/0x24 > mmc_pwrseq_emmc_probe+0x40/0xb8 > platform_probe+0x5c/0xac > really_probe+0xbc/0x298 > __driver_probe_device+0x78/0x12c > driver_probe_device+0xdc/0x164 > __device_attach_driver+0xb8/0x138 > bus_for_each_drv+0x80/0xdc > __device_attach+0xa8/0x1b0 > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > Cc: stable@vger.kernel.org > Reported-by: Marek Szyprowski > Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@samsung.com/ > Signed-off-by: Bartosz Golaszewski > --- > drivers/pinctrl/meson/pinctrl-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c > index 18295b15ecd9..4507dc8b5563 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.c > +++ b/drivers/pinctrl/meson/pinctrl-meson.c > @@ -619,7 +619,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc) > pc->chip.set = meson_gpio_set; > pc->chip.base = -1; > pc->chip.ngpio = pc->data->num_pins; > - pc->chip.can_sleep = false; > + pc->chip.can_sleep = true; > > ret = gpiochip_add_data(&pc->chip, pc); > if (ret) { Reviewed-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic