From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B3BCD5BAA for ; Tue, 19 May 2026 07:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hzZJzAvYK6ISTDYP1eimKtVz2ZfWwVFwhmJ5OPHLrQw=; b=3X/R963EGkWxeWllr5ARyxKmjO ZAQiIN+mU4oIwGRjsjiE27yW2o95mN/3LQ/N9qflQ8R0829F3DoYS6TpdAR4d3EdD2XK91s+3DsIL wbHadDLZtR/eC2SeWfoIzkoZasAGD2guFFvwoh8zXTb5O04HbneAubyf0nhMi5ChNbX+yhzc897Fy 10WU0QOk3H/sPluIziZ8lIuOHk/VLzwBa98iz3UnRjDX7Q6eEeX9ALu6sCl4zUGXIPBfLIRnOSzpx XC6vMH2BBorvNm2nbtuMD978DCATpumGzP+DdI+hZ8BrL3CIs2Vvv5A8tTolMGVnHcSZQRe3+1qXT cCDpRPUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEq0-00000000UQZ-3djy; Tue, 19 May 2026 07:26:00 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEpy-00000000UPA-3m5w for linux-amlogic@lists.infradead.org; Tue, 19 May 2026 07:26:00 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-444826c16ffso2739514f8f.1 for ; Tue, 19 May 2026 00:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175556; x=1779780356; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=U/UrhAX2VwHcFosaazEyQ389tsED90O5GiFK+5wV2WI=; b=lE3g3lbjDh7rlEwkeTcrYZO81mDYNwmHn3AntowQrYhVCSMUo8OC9Q++uo86Z2KiOA 8y62/yoEHh5cx1vi5yT8H8LaVTNzvnXHnNCG/p+xlZSUIXmbY7MHyovCFsEoyam7IeuP LFkwAOsGrOUafa+LFgR7w+/xuLGrShOWqwVOgi6hhCOM7gyDG3FpSxCwz5/PbcfoA8vc Cw8mUV8k1pVdbZn2+GiJ4NeEFWs8j6+JU5E87Hhum3Hnn2K5Wv6xhNua+Go0RS5vKF9c wEEf4zaU3Crv52fZCxF7ajR/0uALL9heCghzwMaUJKHBdBNeP1sHXpnCys+YfRK6CUHg OELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175556; x=1779780356; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U/UrhAX2VwHcFosaazEyQ389tsED90O5GiFK+5wV2WI=; b=VWORaM47W4T2AM1h1CTb5v7etGujrDzJZ2409Rxf+PuDBg6+8LrqaAc8YCUR/48w4Y 4OUcLXAhOYrpHsNl3cc4cmFuixLDHRL16oD5qWLRQpzPDMQoMA2nFuFclEWe8DWX3R+F IGZLVfF2AFFAxQZy6G5yB243igiPTZSgHIhpQEDGU/KKJXjQg3xKzF1RPi7m6GdgBilJ ou263LcFTVStBmVMZ7ozjJ9slh8VuqWrAzi54jf1U+5pipyEvK0Kn3ODZnwLvfVw0Rxs O6My3stvt8/WeJW2tLwwg1qPD7fv6+Pm88zhxlSvPTbhojQlwTKB3spJG1OpcR8wsWov hqvg== X-Forwarded-Encrypted: i=1; AFNElJ+tl9SSyFTvzDty5r/VQZHfijlQIyVgxxLYNKGvuIdap+1jLiY63UJAP/rTJaQdL5rEJ76fyfrWD5RKX5yu@lists.infradead.org X-Gm-Message-State: AOJu0Yynkf6bbUSNFWv9Cz1+rmYwvWwBhM62QTN/BSiouV4+OQH33VtG 8kqxi5aMPf+GikvTVBBcllqXFM4VOo8GftxA+c1U6UPInjBSovgZLJu8SVH43b1fplo= X-Gm-Gg: Acq92OGjldO88gE9Jm95H/Af8rQGZRTAlQw3fgqq0mUWZxEqssvksjGqjd+ZO/Kq6fL 4fEiOc2hOAafpbIhGFOGooWjv8MxRH07m0mdMMi7gvRAH7gEGVuPxGwETIkdMifHPWwDAbYvv0X mELJ/+5RcYd97hKZqJ5s7z1kcxQ7iZzMscgIRNvn9Vd/9mO8jn3RxlCrWglSNFZ4vrpfMjp1dfX MbkdvbGFzrf4qDUHlWkIGv+d+lQPu3xER9mDO1dsDd5KXKdr3TTSdHTo9sgBeFHRh1rYDeTXh0e OOgOKQtZHSqL1NcxNHeRF9UxNFETxSbfa1kelpMpum9KbDP9zOhcserD4ncfjyg/AcfYWZDmSOw 1TrCeQF5XVTZeYpatxogRN1UH4RaJplZTMt9oFdWlih3KuN8tFZk827BqVs3IFIS6qy94otVn5O z+JNUdyVvTHbt/I1r5Pc+pX2OnXKUlHPauRa7ZvNzxazTvvCFlh0X3TQFI14Lz10iFjxi/lW+3b M8XFsEfKJ0IKVA= X-Received: by 2002:a5d:5d0e:0:b0:44e:639b:7d0f with SMTP id ffacd0b85a97d-45e5c36bd17mr28618808f8f.12.1779175556033; Tue, 19 May 2026 00:25:56 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed30110sm47358336f8f.13.2026.05.19.00.25.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:25:55 -0700 (PDT) Message-ID: <0a91bf03-c94f-4519-a69c-b7f5e505ec1d@linaro.org> Date: Tue, 19 May 2026 09:25:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 04/13] drm/meson: dw-hdmi: Drop call to drm_bridge_hpd_notify() To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-5-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-5-jonas@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_002558_981647_5D2870CA X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 5/18/26 21:47, Jonas Karlman wrote: > Calls to both drm_helper_hpd_irq_event() and drm_bridge_hpd_notify() in > the IRQ handler causes multiple hotplug uevents and modesets during an > HPD interrupt. > > Change to only call drm_helper_hpd_irq_event() in IRQ handler to ensure > only one hotplug uevent is triggered when the connection status or EDID > has changed. > > The bridge connectors detect() func help ensure that any hpd_notify() > func is called for all bridges in the chain. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 9aafdc768f2b..30099bf71aad 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -521,17 +521,8 @@ static irqreturn_t dw_hdmi_top_thread_irq(int irq, void *dev_id) > > /* HPD Events */ > if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL) && > - dw_hdmi->bridge) { > - bool hpd_connected = false; > - > - if (stat & HDMITX_TOP_INTR_HPD_RISE) > - hpd_connected = true; > - > + dw_hdmi->bridge) > drm_helper_hpd_irq_event(dw_hdmi->bridge->dev); > - drm_bridge_hpd_notify(dw_hdmi->bridge, > - hpd_connected ? connector_status_connected > - : connector_status_disconnected); > - } > > return IRQ_HANDLED; > } Reviewed-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic