From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76488C636CC for ; Tue, 7 Feb 2023 08:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=je9GRHu7jY8+Awu3K2MIvnVViTMNRBBfa93DWA6tJEU=; b=Z3WN7l1dhq4iVRDRIlzTFr8Gow LX86P/w+yNmWp2IX4yQ9kHKLpWum/a24MlZ3zh7VdA+puuoFb+S64slY1UDWbqE9NRzwU7sLLyATR 93G1BYA59VyJnSJe1DfrQslpyFHmVvXCYvk0/vjj89yYQW6dtpZ4X9zk3no2rQtIyoD/IwX9jUaZx P6DzkMWAqRxXwRxZTMbS26F1UPVTPat0EnKogFxYrN8fQg/FJCHZ9q/7VH5/QhckBXev/4w024WTE GJ8IGyLV36IMfp8yOzcnm58ZDM5nqiW/BhVRp8mMOYpSJy+bGtnSpkKv3T6RIInMzUyTXwrjprSrh 4LO6+3Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPJFj-00BHGM-Vs; Tue, 07 Feb 2023 08:23:00 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPJFg-00BHEH-3d for linux-amlogic@lists.infradead.org; Tue, 07 Feb 2023 08:22:57 +0000 Received: by mail-wr1-x436.google.com with SMTP id o18so12716976wrj.3 for ; Tue, 07 Feb 2023 00:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rznDP7uBI+QG6KYVDkvdwqbzoBSSdyzFVHdEMC/qL+s=; b=XrpjMr0Dw4av7VtcwsHWujhnmZivRmIkKYDhHR/7GpoEMk6VOLS+v5n+iPETazs/y+ wiVPRxEEIeX8niUYSXglh7QjYaJ3k7PQXFk0suw9gkSQ3DwGw4Fu5Myt6BZnUsWyME0A n0WyqEwyMZZCAh9YvuXTh2g4EQ8UnJww4DDEfdvv12hBTzXTG6ToL8V/wbgIDPWE56pG obxV6/QD1TKXHXOjz2lAdPht2yTdwOkDMzxbYzZqUgutyudvFDA/0OkwSmUMvLEGMVih 5IFIzyOY/6yvXgeCpv64tL5NVxNsG2FjoEgEYFsunQ7EJfY18R/FnpI5Afxq7w6tAssX xg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rznDP7uBI+QG6KYVDkvdwqbzoBSSdyzFVHdEMC/qL+s=; b=1I7MCeqzjnSklPzWWXMVH4vIT40Yur/gNuPTBPrDf/xPuyqPq1+3HmsWtnk9Ys7pnT zsBRmu/07lHRreDCXq1s3wBc+3EvGBh1eW8yopNfwJB+DVyA9yIIg0iDlXHOhU3nFQqA trYDdzUsL5GxTMHRZ5lLlijdnwcu9gN2+3PkmKhIxTxhCYKx6M/4+UcfJ4I4MR7h0tPL 1cfiv0iQL6EDRgissWbHXwPnbJpHbM9lDYwattq4u5lD3lw6PTJItRWKZAd98WUYXteX 6Wm7ZJKKoRTZHuhGMs5sDgppT4F52u75G8obAkVkE4O339xqhSxgyiFglLTOlzJ32/oQ Cxcg== X-Gm-Message-State: AO0yUKWdtzdRumGc/J2U+gzpdp3E8sv2V7zhfqLsBPpxNzklUOZyj5e2 pnRCdqh/I0yNrj0Kh4qdZ/tSgQ== X-Google-Smtp-Source: AK7set/13nHV2KQUuofdwb5s1dtrRayAH/7m7w+qHZtqe0Fmgaktq8+HvHFuHmI6dCONzCX5hAMmwg== X-Received: by 2002:a5d:4d46:0:b0:2c3:f0ec:68a7 with SMTP id a6-20020a5d4d46000000b002c3f0ec68a7mr1817670wru.30.1675758172501; Tue, 07 Feb 2023 00:22:52 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:c58c:fc5c:67d6:e5f3? ([2a01:e0a:982:cbb0:c58c:fc5c:67d6:e5f3]) by smtp.gmail.com with ESMTPSA id l11-20020a05600002ab00b002bfb5ebf8cfsm11173916wry.21.2023.02.07.00.22.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 00:22:51 -0800 (PST) Message-ID: <0bc74947-8522-d924-de21-a1ebb6814364@linaro.org> Date: Tue, 7 Feb 2023 09:22:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: neil.armstrong@linaro.org Subject: Re: [PATCH v2] arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive Content-Language: en-US To: Da Xue , Jerome Brunet Cc: Heiner Kallweit , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Martin Blumenstingl , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." References: <84d40502-fe1a-ef61-e945-9c581557f528@gmail.com> <1jedrg6mkl.fsf@starbuckisacylon.baylibre.com> Organization: Linaro Developer Services In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_002256_234512_2AC28692 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 03/02/2023 09:03, Da Xue wrote: > On Fri, Jan 27, 2023 at 10:10 AM Jerome Brunet wrote: >> >> >> On Fri 27 Jan 2023 at 14:02, Heiner Kallweit wrote: >> >>> On 27.01.2023 08:59, Neil Armstrong wrote: >>>> Hi, >>>> >>>> On 26/01/2023 15:03, Heiner Kallweit wrote: >>>>> The usage of edge-triggered interrupts lead to lost interrupts under load, >>>>> see [0]. This was confirmed to be fixed by using level-triggered >>>>> interrupts. >>>>> The report was about SDIO. However, as the host controller is the same >>>>> for SD and MMC, apply the change to all mmc controller instances. >>>> >>>> Thanks, I applied it in for-next so it runs on the CI tests. >>>> >>>>> >>>>> [0] https://www.spinics.net/lists/linux-mmc/msg73991.html >>>>> >>>>> Fixes: 1499218c80c9 ("arm64: dts: move common G12A & G12B modes to meson-g12-common.dtsi") >>>> >>>> I think we should find a better Fixes or perhaps split in 3 so it targets the >>>> right commit adding the nodes for each family. >>>> >>> This would be the cleanest option, right. Practically it shouldn't make >>> much of a difference. The chosen commit is from 2019, SDIO interrupt >>> support has been added just recently, and regarding MMC/SD it seems no >>> problems caused by edge-triggered interrupts are known. >> >> ... Well, I wonder is this might be linked to instabilities seen with >> very high speed mode (such as SDR104) and DDR modes. We have seen quite >> a lot of those over the years. In any case, if it helps stabilize the >> MMC on amlogic, it would be great if it can be picked up by stable. > > On S905X, I'm still getting SDR104 failures with this change at both > 208MHz and 150MHz so maybe not completely. > > [ 9.071641] mmc1: tuning execution failed: -5 > [ 9.579765] mmc1: tuning execution failed: -5 > [ 9.761580] mmc1: tuning execution failed: -5 > [ 9.871836] mmc1: tuning execution failed: -5 Are these the same before the change ? or did those appear with the change ? > >> >>> >>>> If the test doesn't report any breakage, I'll probably ask you that. >>>> >>> Sure. >>> >>>> Neil >>>> >>> Heiner >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic