From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891DFC54FD3 for ; Wed, 25 Mar 2020 13:36:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51ADD2076A for ; Wed, 25 Mar 2020 13:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pObFQ3cV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51ADD2076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5lMYKa7nRkUu7CV2RrvYOFDmK3DabgYOgFCd+Q8T/cw=; b=pObFQ3cVzCsoX2 8qBenAZbEQfIZ5HSKetex21K5kMVHS55utG4uTiyEKQrtuzy2UgLMAFeu5BBu7pjrcB1BjcNSFomv 69O7La646XVIUOUV25yfUr/8wJMw6x13osNiF0IOtD/eII6ZS+qofx95y4e0p3mExp/2zlvvJUp+a tlkekD2RvpcAQV57kEnbT802S+ASeF2DRyuDpv/SYnnRUaSKQ8dWm9Ebwrk8wzns7KFf9HuYh7bcU fjh4e6qxSF1MM8tkSO0jDAxJfFWMNbujPCryD9wRgstgGc8mBpldeymgdYbyF6upi0m/ql98cO4eT NWhf+I+o2utRNFpphnxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH6CR-00018i-J6; Wed, 25 Mar 2020 13:36:03 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH6CH-0000xE-3G; Wed, 25 Mar 2020 13:35:54 +0000 Received: from [10.18.38.73] (10.18.38.73) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 25 Mar 2020 21:36:06 +0800 Subject: Re: [PATCH 02/13] usb: dwc3: meson-g12a: specify phy names in soc data To: Martin Blumenstingl , Neil Armstrong References: <20200324102030.31000-1-narmstrong@baylibre.com> <20200324102030.31000-3-narmstrong@baylibre.com> From: Hanjie Lin Message-ID: <0cc6076c-1334-026f-c7ce-32a5945351b5@amlogic.com> Date: Wed, 25 Mar 2020 21:36:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.73] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200325_063553_137117_BE81C3F3 X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, khilman@baylibre.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/3/24 22:19, Martin Blumenstingl wrote: > On Tue, Mar 24, 2020 at 3:17 PM Neil Armstrong wrote: >> >> On 24/03/2020 15:13, Martin Blumenstingl wrote: >>> Hi Neil, >>> >>> On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong wrote: >>> [...] >>>> +static const char *meson_a1_phy_names[] = { >>>> + "usb2-phy0", "usb2-phy1" >>>> +}; >>> my understanding is that the A1 SoC only has usb2-phy1. >>> +Cc Hanjie Lin to confirm this >> >> I forgot a comment here, it only has a single PHY, but still the 2 U2 PHY >> controls slots... it would need a large amount of code to handle this >> tweak, and leaving 2 PHYs keeps the behavior before the patchset. > I just reviewed patch #3 and I now understand that it would require a > large code-change > I'm fine with a comment > > > Martin > > . > I see, A comment here will be more comprehensible. Acked-by: Hanjie Lin Hanjie _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic