From: neil.armstrong@linaro.org
To: Alexey Romanov <avromanov@sberdevices.ru>,
narmstrong@baylibre.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com
Cc: linux-arm-kernel@lists.infradead.org, kernel@sberdevices.ru,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers: meson: secure-pwrc: always enable DMA domain
Date: Mon, 19 Jun 2023 11:00:17 +0200 [thread overview]
Message-ID: <0d50047b-b30a-9c20-1754-2ee4fc4f7e18@linaro.org> (raw)
In-Reply-To: <20230610090414.90529-1-avromanov@sberdevices.ru>
On 10/06/2023 11:04, Alexey Romanov wrote:
> Starting from commit e45f243409db ("firmware: meson_sm:
> populate platform devices from sm device tree data") pwrc
> is probed successfully and disables unused pwr domains.
> By A1 SoC family design, any TEE requires DMA pwr domain
> always enabled.
>
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> ---
> I'm not entirely sure if this domain should always be enabled on or it
> should be separately enabled in dts file. Comments are welcome.
> ---
> drivers/soc/amlogic/meson-secure-pwrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
> index e93518763526..25b4b71df9b8 100644
> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
> @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = {
> SEC_PD(ACODEC, 0),
> SEC_PD(AUDIO, 0),
> SEC_PD(OTP, 0),
> - SEC_PD(DMA, 0),
> + SEC_PD(DMA, GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE),
> SEC_PD(SD_EMMC, 0),
> SEC_PD(RAMA, 0),
> /* SRAMB is used as ATF runtime memory, and should be always on */
It's fine to keep it enabled.
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-19 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 9:04 Alexey Romanov
2023-06-19 9:00 ` neil.armstrong [this message]
2023-06-19 9:04 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d50047b-b30a-9c20-1754-2ee4fc4f7e18@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=avromanov@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®