From: "Asai, Shigeaki" <y-asai.0816@docomonet.jp>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: odroid-go-ultra: use the RK818 RTC as rtc0
Date: Mon, 19 Oct 2026 22:04:51 +0900 [thread overview]
Message-ID: <10DD5FCA6DA7B692F3006A@docomonet.jp> (raw)
In-Reply-To: <0b5c28f0-0a43-42b3-a07e-4ecf39b2380d@linaro.org>
Hi Neil,
On 10/19/26, Neil Armstrong wrote:
> The vrtc was used as rtc0 because it's the defaut wakeup rtc,
> can the rk818 and rk817 wakeup the system when in system suspend ?
Thank you for the review. I did not think about wakeup, sorry. I tried
it on my board:
- s2idle: with Igor's "irqchip/meson-gpio: Allow the GPIO interrupts to
wake the system" applied, an alarm on the RK818 RTC woke the board
4/4, and the power key on the RK817 3/3. Without it, neither of them
woke the board.
- deep: an alarm on the vrtc (rtc1 with this patch) woke up BL30, but
the system did not come back to Linux, and I had to disconnect the
battery. An alarm on the RK818 RTC and the power key did not wake it
up at all. So deep suspend does not seem to work on this board for
now, which looks like a separate problem.
On the other hand, the vrtc does not keep the time, and the RK817 RTC
drifts, so only the RK818 RTC gives the correct time at boot. Also,
before this patch, the vrtc was not rtc0 on my board even with the
rtc0 alias: the RK817 and RK818 RTCs registered first and took rtc0
and rtc1, and the vrtc became rtc2.
Would it be OK to keep this patch as it is? If you prefer to keep the
vrtc as rtc0 for deep suspend, I can send a v2 with rtc0 = vrtc,
rtc1 = RK818 and rtc2 = RK817 instead.
(This reply was written with the help of Claude.)
Thanks
Asai, Shigeaki
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-10-19 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 11:07 Shigeaki Asai
2026-10-19 7:29 ` Neil Armstrong
2026-10-19 13:04 ` Asai, Shigeaki [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-13 22:49 Shigeaki Asai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10DD5FCA6DA7B692F3006A@docomonet.jp \
--to=y-asai.0816@docomonet.jp \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®