mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	Junyi Zhao <junyi.zhao@amlogic.com>,
	linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Wed, 18 Nov 2026 15:16:38 +0800	[thread overview]
Message-ID: <1282161c-f1fe-40fa-a539-f95fbdeb46e5@amlogic.com> (raw)
In-Reply-To: <23a72c5e-7eb7-4a4e-9f06-fdc4976b05bc@web.de>

Hi Markus,

On 2026/11/17 21:21, Markus Elfring wrote:
> …
>> +++ b/drivers/i2c/busses/i2c-amlogic-a9.c
>> @@ -0,0 +1,428 @@
> …
>> +static int aml_i2c_xfer_msg(struct aml_i2c *i2c, struct i2c_msg *msg, bool last)
>> +{
> …
>> +     spin_lock_irqsave(&i2c->lock, flags);
>> +     i2c->state = (msg->flags & I2C_M_RD) ? A9_STATE_READ : A9_STATE_WRITE;
> …
>> +     /* Start the transfer */
>> +     aml_i2c_do_start(i2c, msg);
>> +     spin_unlock_irqrestore(&i2c->lock, flags);
> …
>> +     if (!time_left) {
>> +             guard(spinlock_irqsave)(&i2c->lock);
> …
>> +     }
>> +
>> +     return i2c->error;
>> +}…
> Will development interests grow also for the application of another scoped lock guard?
> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/cleanup.h#L325-L328
> 

Will do.

> Regards,
> Markus

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

      reply	other threads:[~2026-11-18  7:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:58 [PATCH v10 0/2] i2c: Add driver support Amlogic A9 I2C Xianwei Zhao via B4 Relay
2026-11-17 11:58 ` [PATCH v10 1/2] dt-bindings: i2c: add Amlogic A9 I2C controller Xianwei Zhao via B4 Relay
2026-11-17 11:58 ` [PATCH v10 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Xianwei Zhao via B4 Relay
2026-11-17 12:19   ` sashiko-bot
2026-11-17 13:21   ` Markus Elfring
2026-11-18  7:16     ` Xianwei Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282161c-f1fe-40fa-a539-f95fbdeb46e5@amlogic.com \
    --to=xianwei.zhao@amlogic.com \
    --cc=Markus.Elfring@web.de \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=junyi.zhao@amlogic.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®