From: Neil Armstrong <neil.armstrong@linaro.org>
To: Carlo Caione <ccaione@baylibre.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jerome Brunet <jbrunet@baylibre.com>,
David Airlie <airlied@gmail.com>,
Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>,
Mark Brown <broonie@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers
Date: Tue, 6 Dec 2022 10:41:13 +0100 [thread overview]
Message-ID: <14e5c4e4-30dd-8efd-81e4-d680664ab04a@linaro.org> (raw)
In-Reply-To: <20221116-s905x_spi_ili9486-v3-3-59c6b58cbfe3@baylibre.com>
Hi Carlo,
On 06/12/2022 09:34, Carlo Caione wrote:
> For platforms using simplefb / efifb, call
> drm_aperture_remove_framebuffers() to remove the conflicting
> framebuffer.
Conflicting framebuffer on the SPI display ? How is that possible ?
The meson_drm should already do this, no ?
Neil
>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> drivers/gpu/drm/tiny/ili9486.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 14a9e6ad2d15..6fd4d42437fd 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -14,6 +14,7 @@
>
> #include <video/mipi_display.h>
>
> +#include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_fb_helper.h>
> @@ -238,6 +239,10 @@ static int ili9486_probe(struct spi_device *spi)
> if (ret)
> return ret;
>
> + ret = drm_aperture_remove_framebuffers(false, &ili9486_driver);
> + if (ret)
> + return ret;
> +
> drm_mode_config_reset(drm);
>
> ret = drm_dev_register(drm, 0);
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-12-06 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 8:34 [PATCH v3 0/3] Make ILI9486 driver working with 16-bits SPI controllers Carlo Caione
2022-12-06 8:34 ` [PATCH v3 1/3] drm/tiny: ili9486: Enable driver module autoloading Carlo Caione
2022-12-06 8:34 ` [PATCH v3 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers Carlo Caione
2022-12-06 8:34 ` [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers Carlo Caione
2022-12-06 9:41 ` Neil Armstrong [this message]
2022-12-06 9:52 ` Thomas Zimmermann
2022-12-06 13:00 ` Carlo Caione
2022-12-06 14:14 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14e5c4e4-30dd-8efd-81e4-d680664ab04a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=broonie@kernel.org \
--cc=ccaione@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=kamlesh.gurudasani@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®