From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16A67CCFA05 for ; Fri, 7 Nov 2025 11:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MQzt1to+YOq3z3fr834LNXNN+EOV62lfJzdBUyiZyHU=; b=luS71r30gCdP/q TFWJO9BB6Px/rVR2oBcuQD+4mEGZmjtYxY3lCnZdQpB+LhDeqZ1x2kXzfXl6E0yJUOzqZMfAiOj2S zm+JpCU+G+tRSkydH0oIljNfMeGusg6tAyQHhgRN8KWsFl/w7Ufc5yJMiUJ5xL2tKWUstcjri/qOO zTrHDpsyObggiINcpGe9nMXBKsthOTGZI6zfp24DPKk3KOgTrmkG1J2NsCXqfZa40gAPsX9yIoJm6 fRzetLh06c1Z6WVHdnBrbTJKEP794DzTFPOdr5kywAFA7/FTUos/9rvNmVxBBql40xwB3tyFyexhO c8v6u4NyJ5kESWpNJOSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHKCi-0000000H9iF-3uzA; Fri, 07 Nov 2025 11:00:28 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHKCf-0000000H9h7-3bCQ for linux-amlogic@lists.infradead.org; Fri, 07 Nov 2025 11:00:27 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A7AjS9C1864656 for ; Fri, 7 Nov 2025 11:00:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=meYRNVo/ytmsLIw3 9yLlW7GI4+rmzu1SkLLhvRhvP8rWpFv8etdCh6oOI0eghmA6tDSc4+hVriUcpmbT bvUyQrcf9TgGLMtQn9G+DabVKcab8kJVoyw9dkotpbWXALEFwxkESHu9/xGv20VL nacxkzyq6bconr1T4lWp2oNzE6cnmBNsSKhavXJQtBCa7T+USx4Ja6Uje777/aBI 6S25I9Inyk4w65tWzgHYtI+hnsskEBJILnxbA1HqfHj1VXyZUvwbpaTp6JPz2umy TUX/veb7bU/ued1EGhEUm+QNtaAtvgdwI55azNJSswoyx0dkp6JjaiBc//hM8H2d w5LLEA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a98ta18ef-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 11:00:25 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-883618130f5so26245085a.1 for ; Fri, 07 Nov 2025 03:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762513224; x=1763118024; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=hQehlBwumPbhV2KNKMRe/JvdeYnmaV5PJAeHrkHd4n3hUr5E9T0DLTg0D4IsOyMoBo GFIxpaNuaXSgFljg53ePXkcXQTYg9C/6GSsZZlE5shh/+nR9S0K+DEdATrl34NpjrI0f c1N0aZtXCOeLdfNC53r86s8Z/vi3VJxzvc8ipBEt7U+5O6ur8wvwP5TpDy88PITuDZXP 0dse0WBRd945vQXvnMbZeKmJfkB3Ti2/XMFuOtNU9iJAp8uMCVXZsK0A7oSmm88+mB+r Z5TD4zU4d73MQcWNSmrLemX+8MdFh7LaC+uWH3sx0kxdFDK46yu1KAYeGChRBe5nZrge o8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762513224; x=1763118024; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=i9VkbGac8yxgjUhYKpsnNPu9PpOr0M+VSDM+EOzTWBj8vNM/SvPnV2AGAIS78it2yX 9ZqqMMt+qGe7IrqZXgtI3cGALL5Ij0phlIyHHeKnw5txzc5MdUmrAlQLnFPVV8Hyg6OV HWA06YKU87XYg3UWwteiILhO1090HOSiiJmYtNnfAc8lf0w0yLA5rDMyngBF50vrKacD ZwItk/aBwzAn1ANrQW5Y3ifziTsOcATWj9DiCnzHoVyy1nEqQSoPmBzi5C5bXB/ehAXA pLVZuBWMPO2xAGHTss4j1Rosmi9Ywp35/QmIZpkQyGuJ+Yy4+wEDxq+Pv7yvyXZFL9Q6 +2xw== X-Forwarded-Encrypted: i=1; AJvYcCWj0Bhk7fmeXvYpgkzg2L1VTGxpGup3sX3SDyIWiQ/mhdfY46o+aEcokvaCJn6SUNgpOi7pDp2jvN8+UdJ5@lists.infradead.org X-Gm-Message-State: AOJu0Yxhwe8cIA89gni/N+iKaTnmhbNbhWRt4DcakgRByGPJH2r3+Sqv hvdkQ+qhFFszzlU4OH9JiiPM4NMCiyAs//lKs4zlIlxUg+6aBn3+9JhNUb5WATSj9mNAu0IxmYH uU6mJ2dNb1LSL/PD0z2LNLtPcCZxgf/lwwnbwH3iD1wnJZLltH7L1m7Rowu2jQhnIXs3EINxQsA == X-Gm-Gg: ASbGncvqASC/2BFgdgXXCDqeKb++We7ivucnrTT07P68wM+J/6LXyxzKOZRzt0x2nNe 6bF+/fQU8aCATYx/GZb5leePGVZwsSfkLERdhcbtVCSTA/Csotnev8+gEBQUB/MEH46yXb6o6+M xbRoe4MxujBB0ZrPvv8QkUevl7MO0TwlKlv6Z5kR2ukByleEY//nt+hNQRcd0ooYSmXXtGw8NPH 7Sc7UosoBi7cwjbvJxOClm0xW2Pt+Ybr8gdRI222V8hlVipx0NvmqdS7xFJC1T0hBdyjGANNisO HQ/Em6ue2Vcn0cySw5nMO0OmWWj2e3IhvTCMbBnqljIKHpKEGX0PtSyUXFAnK0Gb2tzs8iK0zLR mxJEbpjzLYwjklsSNeIFjUpXnPSNbIt/GUmN1RRShPwjZhCtvhI866ZQ/ X-Received: by 2002:a05:620a:4049:b0:85f:89:e114 with SMTP id af79cd13be357-8b245280933mr239712985a.1.1762513223947; Fri, 07 Nov 2025 03:00:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IH34Ma6AlYFANasFLA7REiIDlipeT0LBwxV1S1iyIGEImmErkoaBKdKchVkLndS6HBNKbTjKQ== X-Received: by 2002:a05:620a:4049:b0:85f:89:e114 with SMTP id af79cd13be357-8b245280933mr239705785a.1.1762513223227; Fri, 07 Nov 2025 03:00:23 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc874sm216910666b.54.2025.11.07.03.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 03:00:21 -0800 (PST) Message-ID: <14f95efb-0eb0-48ee-9132-df35abddfcc7@oss.qualcomm.com> Date: Fri, 7 Nov 2025 12:00:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] net: stmmac: qcom-ethqos: split power management context into a separate struct To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-6-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-6-01d3e3aaf388@linaro.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4OCBTYWx0ZWRfX+neWriwqIQWO 9pqsq+T5NCzjynwlSymHb4Bcq2D50U8Q4/B3rejoIsDuNpFWeWTN3ThY1IFfpQjeZd54N5P9D8D ny0PJZAm6j12H5H9dUuKfTFSMWogAjnFIxrcFRtrUNGO3nEIsELkT9kG3T+xHkJjedo993tJCjk MCNo2LUpv5eP9Hv+tlaDt+5RpqZxb+MiARAeVU4m9evfjaFyxXJIK2+sjgkxzc4fFl9DqgCSBr2 VPOFSOV0TzYgT1PSuVkMg+52HBQ1IUg08uTG9LmhTZnHD2q5dEm5TM0IzjWPQziiJNRCK9sHgSP m3a2WkmhIgP9cEYlQS/RHPYJQtehCdWvh9mshZCe6zeXFiquFmK1okYxmt4bwlBWDqQH7X021Wh zWZOkMNz4PAA/7uL0RjyCo4Td17RHA== X-Proofpoint-ORIG-GUID: lCtAUpf0NlTmy2YsFH9WHQdqwLoQmS-H X-Proofpoint-GUID: lCtAUpf0NlTmy2YsFH9WHQdqwLoQmS-H X-Authority-Analysis: v=2.4 cv=G9IR0tk5 c=1 sm=1 tr=0 ts=690dd149 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=iTm1nGh4yTgqJnnOKdQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070088 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251107_030025_937535_9C5C7C8F X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > With match data split into general and power-management sections, let's > now do the same with runtime device data. > > Signed-off-by: Bartosz Golaszewski > --- > .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 46 ++++++++++++---------- > 1 file changed, 25 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 1f00556bbad997e2ec76b521cffe2eb14fabb79e..09f122062dec87aa11804af2769ddff4964e6596 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -105,17 +105,21 @@ struct ethqos_emac_match_data { > const struct ethqos_emac_pm_data *pm_data; > }; > > +struct ethqos_emac_pm_ctx { > + struct clk *link_clk; > + unsigned int link_clk_rate; > + struct phy *serdes_phy; What is the benefit of doing this? PHY APIs happily consume a nullptr and NOP out, and the PHY is already retrieved with _optional(), similarly with clk Konrad _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic