Re: [PATCH] dt-bindings: media: amlogic,axg-ge2d: add S4 support

[neil.armstrong@linaro.org]

On 10/25/26 20:23, christian.koever-draxl@student.uibk.ac.at wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> 
> The S4 GE2D is compatible with the AXG one, but sits in a power domain
> of its own. Add an S4 compatible with the AXG one as fallback, and
> allow a power domain.

The AXG GE2D is a special version for AXG which doesn't use the Canvas
to read and write buffers, so it may work on S4 but they are not stricly
compatible.

So please add a separate compatible entry and drop the fallback.

Neil

> 
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> ---
> Tool use (Documentation/process/generated-content.rst):
> This work was done with the help of an AI coding assistant, Claude
> (Anthropic), used through Claude Code over many sessions. It did a large
> part of the hands-on work: it read the vendor kernel and the firmware
> interfaces, probed registers on the board, drafted the code and the
> changelogs, and ran the builds, checkpatch, dt_binding_check and the
> tests on the hardware. I directed the work, reviewed every change and
> the final patches, and take responsibility for them. There is no single
> prompt to quote; the sessions were of the form "find out why X fails on
> this board, fix it, test it on the box".
> 
> Tested on an Amediatech X98Q TV box (Amlogic S905W2, S4 family, 2 GiB),
> vendor U-Boot and BL31/OP-TEE, Linux 7.3 plus this work.
> 
>   .../devicetree/bindings/media/amlogic,axg-ge2d.yaml    | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml b/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
> index f23fa6d06ad0..22decb67879d 100644
> --- a/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
> +++ b/Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml
> @@ -12,8 +12,11 @@ maintainers:
>   
>   properties:
>     compatible:
> -    enum:
> -      - amlogic,axg-ge2d
> +    oneOf:
> +      - const: amlogic,axg-ge2d
> +      - items:
> +          - const: amlogic,s4-ge2d
> +          - const: amlogic,axg-ge2d
>   
>     interrupts:
>       minItems: 1
> @@ -27,6 +30,9 @@ properties:
>     clocks:
>       minItems: 1
>   
> +  power-domains:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> 
> base-commit: 7be4bc52fd9e0e55dc9a2e0232b89427d2c4b614


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic