From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCCDC2BB85 for ; Thu, 16 Apr 2020 16:08:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 230642054F for ; Thu, 16 Apr 2020 16:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S+VTvvYX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2Nmh4V/+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 230642054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4fWdy9g2gfRSTWmUhPs1Doo3CHztip6dmVsJA/2WFic=; b=S+VTvvYX0zs7JI 2xew51WTrAb4MXdjG02zz2k0yeDvvq70I4BoMpjF0uuvhIYI3zFYpQJzILbsh53ZMZkJCt1ESe6AK 0XymkxAgGG5KsyRwUYSQKCzRZgL7ZdlCvTWXc3ECSNXI5LeN55qXqEO/LOqsoUbVsT+VPuMMjWG3j obTSkuubpoq3jdvzm4Bp0Li7S980YTObot/20LFgRNiu8LdxAPXuyU4l30eBH0Lmi2paZh/QNARkA g2WqfuVQVEPgTJe2YdBFATrvv1/Z3QIb73sQ+RzLg3HRq6QcgiJl+jLQ1zNy7RgVfRN8THkFWR6n6 AzvXLB/zwxYuvUylmHgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP74E-0000N4-7b; Thu, 16 Apr 2020 16:08:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP73b-00080m-As for linux-amlogic@lists.infradead.org; Thu, 16 Apr 2020 16:08:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587053282; bh=rigBaHmT1eqdPDWAD3BnFqzh24KSHzwhJQei6DYsP1c=; h=Subject:From:Date:References:In-Reply-To:To:Cc:Cc:From; b=2Nmh4V/+aYYUad5fdOOwrg69hOB3lczbwsKcyPbH1EJYfn4CFuFRbrF0cS23nLdvj HXicX/kopn4U6rOTf4JrMc5xJt1nc7gKBXPOXXlgDpnarenio9mWXJSxpeFIflaFFW JSUp48vHN/pimOJ3qk3fTVNvFg+mhdksI9zW8/gk= MIME-Version: 1.0 Subject: Re: [PATCH] usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init From: patchwork-bot+linux-amlogic@kernel.org Message-Id: <158705328211.8629.9063413018389670651.git-patchwork-notify@kernel.org> Date: Thu, 16 Apr 2020 16:08:02 +0000 References: <20200210225816.36598-1-natechancellor@gmail.com> In-Reply-To: <20200210225816.36598-1-natechancellor@gmail.com> To: Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_090803_397541_A71D6F72 X-CRM114-Status: UNSURE ( 5.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, khilman@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next). On Mon, 10 Feb 2020 15:58:17 -0700 you wrote: > Clang warns: > > ../drivers/usb/dwc3/dwc3-meson-g12a.c:421:6: warning: variable 'ret' is > used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > if (priv->otg_mode == USB_DR_MODE_OTG) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/usb/dwc3/dwc3-meson-g12a.c:455:9: note: uninitialized use > occurs here > return ret; > ^~~ > ../drivers/usb/dwc3/dwc3-meson-g12a.c:421:2: note: remove the 'if' if > its condition is always true > if (priv->otg_mode == USB_DR_MODE_OTG) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/usb/dwc3/dwc3-meson-g12a.c:415:9: note: initialize the > variable 'ret' to silence this warning > int ret, irq; > ^ > = 0 > 1 warning generated. > > [...] Here is a summary with links: - usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init https://git.kernel.org/khilman/linux-amlogic/c/238d760216541d345ee930e76c781f5cd1d22fba You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/pwbot _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic