From: Marc Gonzalez <mgonzalez@freebox.fr>
To: DT <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
AML <linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: amlogic: add fbx8am DT overlays
Date: Mon, 19 Feb 2024 11:32:21 +0100 [thread overview]
Message-ID: <15fcafb2-4b4a-40a1-8ef5-ee3aef9b3b9d@freebox.fr> (raw)
In-Reply-To: <54b4e810-754e-481a-bbc8-984f859b116d@linaro.org>
On 14/02/2024 10:47, Neil Armstrong wrote:
> On 13/02/2024 18:14, Marc Gonzalez wrote:
>
>> Add support for two variants of the fbx8am board.
>>
>> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile | 6 ++++++
>> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-brcm.dtso | 35 ++++++++++++++++++++++++++++++++++
>> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-realtek.dtso | 25 ++++++++++++++++++++++++
>> 3 files changed, 66 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index cc8b34bd583d8..1ab160bf928ae 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j110-rev-2.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j110-rev-3.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-fbx8am-brcm.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-fbx8am-realtek.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-radxa-zero.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb
>> @@ -80,3 +82,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
>> +
>> +# Overlays
>> +meson-g12a-fbx8am-brcm-dtbs := meson-g12a-fbx8am.dtb meson-g12a-fbx8am-brcm.dtbo
>> +meson-g12a-fbx8am-realtek-dtbs := meson-g12a-fbx8am.dtb meson-g12a-fbx8am-realtek.dtbo
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-brcm.dtso b/arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-brcm.dtso
>> new file mode 100644
>> index 0000000000000..ed79809b15859
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-brcm.dtso
>> @@ -0,0 +1,35 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +// Copyright (c) 2024 Freebox SAS
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/gpio/meson-g12a-gpio.h>
>> +
>> +/ {
>> + compatible = "freebox,fbx8am-brcm", "freebox,fbx8am", "amlogic,g12a";
>
> This looks fine but I'm unsure if those new compatible should be documented or not,
> since they are in an overlay
Rob, Krzysztof, Conor,
Just want to make sure this was done "right".
Is it acceptable for an overlay (DTSO) to define a more specific compatible prop?
Regards
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-02-19 10:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 17:11 [PATCH v3 0/4] Add support for Freebox fbx8am boards Marc Gonzalez
2024-02-13 17:12 ` [PATCH v3 1/4] dt-bindings: vendor-prefixes: add freebox Marc Gonzalez
2024-02-13 17:13 ` [PATCH v3 2/4] dt-bindings: arm: amlogic: add fbx8am binding Marc Gonzalez
2024-02-13 17:13 ` [PATCH v3 3/4] arm64: dts: amlogic: add fbx8am board Marc Gonzalez
2024-02-14 9:46 ` Neil Armstrong
2024-02-13 17:14 ` [PATCH v3 4/4] arm64: dts: amlogic: add fbx8am DT overlays Marc Gonzalez
2024-02-14 9:47 ` Neil Armstrong
2024-02-19 10:32 ` Marc Gonzalez [this message]
2024-02-20 10:01 ` Krzysztof Kozlowski
2024-02-21 10:01 ` Neil Armstrong
2024-02-21 13:48 ` [PATCH] fixup! " Marc Gonzalez
2024-02-21 14:06 ` Neil Armstrong
2024-02-19 8:54 ` [PATCH v3 0/4] Add support for Freebox fbx8am boards Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15fcafb2-4b4a-40a1-8ef5-ee3aef9b3b9d@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=phhusson@freebox.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®