Re: [PATCH v2 3/6] dt-bindings: auxdisplay: Add Titan Micro Electronics TM1628

From: Rob Herring <robh@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Kevin Hilman" <khilman@baylibre.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Mark Brown" <broonie@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 3/6] dt-bindings: auxdisplay: Add Titan Micro Electronics TM1628
Date: Tue, 22 Feb 2022 08:22:43 -0600	[thread overview]
Message-ID: <1645539763.080061.3016155.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <39d61ddb-4b54-4a13-fbb2-c0f88d9bf017@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

On Mon, 21 Feb 2022 21:23:18 +0100, Heiner Kallweit wrote:
> Add a YAML schema binding for TM1628 auxdisplay
> (7/11-segment LED) controller.
> 
> This patch is partially based on previous RFC work from
> Andreas FÃ¤rber <afaerber@suse.de>.
> 
> Signed-off-by: Andreas FÃ¤rber <afaerber@suse.de>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - (re-)add Andreas' SoB
> - fix YAML errors reported by Rob
> ---
>  .../bindings/auxdisplay/titanmec,tm1628.yaml  | 88 +++++++++++++++++++
>  1 file changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.example.dt.yaml: led-controller@0: 'spi-3-wire', 'spi-lsb-first', 'spi-max-frequency' do not match any of the regexes: '^.*@[1-7],([1-9]|1[0-6])$', 'pinctrl-[0-9]+'
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1595730

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic