From: Philipp Zabel <p.zabel@pengutronix.de>
To: Yejune Deng <yejune.deng@gmail.com>,
kishon@ti.com, vkoul@kernel.org, khilman@baylibre.com,
narmstrong@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, lorenzo.pieralisi@arm.com,
repk@triplefau.lt
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()
Date: Wed, 18 Nov 2020 15:55:55 +0100 [thread overview]
Message-ID: <16613681b429ff814089d8529061b1c906bbb288.camel@pengutronix.de> (raw)
In-Reply-To: <1605666995-16462-1-git-send-email-yejune.deng@gmail.com>
Hi Yejune,
On Wed, 2020-11-18 at 10:36 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
> drivers/phy/amlogic/phy-meson-axg-pcie.c | 2 +-
> drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> index 377ed0d..3204f02 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> @@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(priv->regmap))
> return PTR_ERR(priv->regmap);
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> index 08e3227..bab6345 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> @@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> if (ret)
> goto err_disable_clk_ref;
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-11-18 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 2:36 Yejune Deng
2020-11-18 14:55 ` Philipp Zabel [this message]
2020-11-22 21:55 ` Martin Blumenstingl
2020-11-30 11:02 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 5:58 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
2020-11-17 8:34 ` Neil Armstrong
2020-11-17 22:52 ` Martin Blumenstingl
2020-11-03 4:37 Yejune Deng
2020-11-03 9:04 ` Remi Pommarel
2020-11-08 22:13 ` Martin Blumenstingl
2020-11-16 7:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16613681b429ff814089d8529061b1c906bbb288.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=repk@triplefau.lt \
--cc=vkoul@kernel.org \
--cc=yejune.deng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®