From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 471A9E732DB for ; Thu, 28 Sep 2023 14:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5UXFGjR3pWPT6aw541x0wmf/pPZjsuxq+hwcjPQUt/s=; b=ka8EnH7x15pzFi 2RlTde1qWq24FzKNwEcbrnz4oaTI5iYjp4Nfy39rHnRfyiyUeZHOFbPG+YVz7Mv/fvyqWjuqnsDLg paSFlIyV0gz/3WJoDfj9aE+NToTd11vtstU+FL9NHtpCcLZkYY19B42GsqKo21Hjoz1SZZUD8Vq6U 04jrLEkElMHNf4GEdIkPDraqSVDntHznFrFJeaJEAhfxeBZ94psNXNKA2GIcgbIVbs2xCuidvSXmE sxB5mzc3i/rigyDC/8e8R/worJZ4f5bBRmni70bHtAezSfKrRWO/UZ7NvE53RUNMJy6uzuxG4SJKq ANsuauuU9WBpOH5UvsYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlsIh-0052eg-1q; Thu, 28 Sep 2023 14:47:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlsIS-0052OR-2u; Thu, 28 Sep 2023 14:47:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 89B09CE220A; Thu, 28 Sep 2023 14:47:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7281C43395; Thu, 28 Sep 2023 14:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695912438; bh=ImbJJt6lxA8I9pgmrzl1yvRbcB2Hjbk9mPdoIz4rOhc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=r9fyjiAJjrsDcK5xUPyR39tdDZzscjdbcTlaVXqFYJ7f8ZiyLNT+hvLyGmwBuT1EX CCuLc5/7IIiDZSFbAAbJyhLe9tbjkUY2J9fam3hQm2VVKETUs68AZztINVKfPjPvWq c3nPwq9X/9C7W56zW5IzaZXzAb6A+MnKL2HryVomatX0iSPwiITU3hPTuheVLwK4J/ pfQFCuBZDMVefdsco7rJxZz2BlRHnqbDSF2ZPepWvgOteyqUkxP1EkJ913nZVtx6tv 2pXlC19w43Orm43W3l2poUcEWHscncVxInCoqkpq7dwTuCDUDbzz9al6fchGSi7FGR X9P2qRZlW2c+w== Received: (nullmailer pid 408734 invoked by uid 1000); Thu, 28 Sep 2023 14:47:11 -0000 MIME-Version: 1.0 From: Rob Herring To: Xianwei Zhao Cc: Jerome Brunet , Stephen Boyd , Martin Blumenstingl , linux-amlogic@lists.infradead.org, Rob Herring , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , linux-arm-kernel@lists.infradead.org, Kevin Hilman , Krzysztof Kozlowski , devicetree@vger.kernel.org, Michael Turquette In-Reply-To: <20230928063448.3544464-3-xianwei.zhao@amlogic.com> References: <20230928063448.3544464-1-xianwei.zhao@amlogic.com> <20230928063448.3544464-3-xianwei.zhao@amlogic.com> Message-Id: <169591240804.408241.17087442588468882782.robh@kernel.org> Subject: Re: [PATCH 2/4] dt-bindings: clock: add Amlogic C3 peripherals clock controller bindings Date: Thu, 28 Sep 2023 09:47:11 -0500 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230928_074721_388952_0D15546B X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, 28 Sep 2023 14:34:46 +0800, Xianwei Zhao wrote: > Add the peripherals clock controller dt-bindings for Amlogic C3 SoC family > > Signed-off-by: Xianwei Zhao > --- > .../clock/amlogic,c3-peripherals-clkc.yaml | 86 +++++++ > .../clock/amlogic,c3-peripherals-clkc.h | 230 ++++++++++++++++++ > 2 files changed, 316 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,c3-peripherals-clkc.yaml > create mode 100644 include/dt-bindings/clock/amlogic,c3-peripherals-clkc.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,c3-peripherals-clkc.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: [{'description': 'input oscillator (usually at 24MHz)'}, {'description': 'input fixed pll'}, {'description': 'input fixed pll div2'}, {'description': 'input fixed pll div2p5'}, {'description': 'input fixed pll div3'}, {'description': 'input fixed pll div4'}, {'description': 'input fixed pll div5'}, {'description': 'input fixed pll div7'}, {'description': 'input gp0 pll'}, {'description': 'input hifi pll'}] is too long [{'description': 'input oscillator (usually at 24MHz)'}, {'description': 'input fixed pll'}, {'description': 'input fixed pll div2'}, {'description': 'input fixed pll div2p5'}, {'description': 'input fixed pll div3'}, {'description': 'input fixed pll div4'}, {'description': 'input fixed pll div5'}, {'description': 'input fixed pll div7'}, {'description': 'input gp0 pll'}, {'description': 'input hifi pll'}] is too short False schema does not allow 10 1 was expected 10 is greater than the maximum of 2 10 is greater than the maximum of 3 10 is greater than the maximum of 4 10 is greater than the maximum of 5 10 is greater than the maximum of 6 10 is greater than the maximum of 7 10 is greater than the maximum of 8 10 is greater than the maximum of 9 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,c3-peripherals-clkc.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'xtal'}, {'const': 'fixed_pll'}, {'const': 'fclk_div2'}, {'const': 'fclk_div2p5'}, {'const': 'fclk_div3'}, {'const': 'fclk_div4'}, {'const': 'fclk_div5'}, {'const': 'fclk_div7'}, {'const': 'gp0_pll'}, {'const': 'hifi_pll'}] is too long [{'const': 'xtal'}, {'const': 'fixed_pll'}, {'const': 'fclk_div2'}, {'const': 'fclk_div2p5'}, {'const': 'fclk_div3'}, {'const': 'fclk_div4'}, {'const': 'fclk_div5'}, {'const': 'fclk_div7'}, {'const': 'gp0_pll'}, {'const': 'hifi_pll'}] is too short False schema does not allow 10 1 was expected 10 is greater than the maximum of 2 10 is greater than the maximum of 3 10 is greater than the maximum of 4 10 is greater than the maximum of 5 10 is greater than the maximum of 6 10 is greater than the maximum of 7 10 is greater than the maximum of 8 10 is greater than the maximum of 9 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# Error: Documentation/devicetree/bindings/clock/amlogic,c3-peripherals-clkc.example.dts:23.31-32 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/clock/amlogic,c3-peripherals-clkc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230928063448.3544464-3-xianwei.zhao@amlogic.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic