From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH u-boot] ARM: arch-meson: fix writel arguments order
Date: Mon, 18 Dec 2017 12:57:40 +0100 [thread overview]
Message-ID: <16d1c2ac-b21b-9e6d-744b-778cb7ab849c@baylibre.com> (raw)
In-Reply-To: <1513085019-8071-1-git-send-email-narmstrong@baylibre.com>
On 12/12/2017 14:23, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm/mach-meson/eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks Hans for finding this stupid error !
>
> Neil
>
> diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
> index 2debe93..8c6577b 100644
> --- a/arch/arm/mach-meson/eth.c
> +++ b/arch/arm/mach-meson/eth.c
> @@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
> /* Use GXL RMII Internal PHY */
> if (IS_ENABLED(CONFIG_MESON_GXL) &&
> (flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
> - writel(GXBB_ETH_REG_2, 0x10110181);
> - writel(GXBB_ETH_REG_3, 0xe40908ff);
> + writel(0x10110181, GXBB_ETH_REG_2);
> + writel(0xe40908ff, GXBB_ETH_REG_3);
> }
>
> break;
>
Hi Tom,
Can this be merged ?
This error breaks boot on 3 boards.
Thanks,
Neil
next prev parent reply other threads:[~2017-12-18 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 13:23 Neil Armstrong
2017-12-18 11:57 ` Neil Armstrong [this message]
2017-12-18 23:37 ` [U-Boot,u-boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d1c2ac-b21b-9e6d-744b-778cb7ab849c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®