Re: [PATCH net-next] dt-bindings: net: Define interrupt constraints for DWMAC vendor bindings

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: linux-rockchip@lists.infradead.org,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Paolo Abeni <pabeni@redhat.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	linux-kernel@vger.kernel.org,
	"G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>,
	netdev@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Linux Team <linux-imx@nxp.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	David Wu <david.wu@rock-chips.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Biao Huang <biao.huang@mediatek.com>,
	devicetree@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	imx@lists.linux.dev
Subject: Re: [PATCH net-next] dt-bindings: net: Define interrupt constraints for DWMAC vendor bindings
Date: Mon, 10 Mar 2025 16:16:33 -0500	[thread overview]
Message-ID: <174164139310.903652.6069254912704107254.robh@kernel.org> (raw)
In-Reply-To: <20250309003301.1152228-1-prabhakar.mahadev-lad.rj@bp.renesas.com>


On Sun, 09 Mar 2025 00:33:01 +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> The `snps,dwmac.yaml` binding currently sets `maxItems: 3` for the
> `interrupts` and `interrupt-names` properties, but vendor bindings
> selecting `snps,dwmac.yaml` do not impose these limits.
> 
> Define constraints for `interrupts` and `interrupt-names` properties in
> various DWMAC vendor bindings to ensure proper validation and consistency.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Hi All,
> 
> Based on recent patch [0] which increases the interrupts to 11
> and adds `additionalItems: true` its good to have constraints
> to validate the schema. Ive made the changes based on the DT
> binding doc and the users. Ive ran dt binding checks to ensure
> the constraints are valid. Please let me know if you'd like me
> to split this patch or if any of the constraints are incorrect,
> as I don't have documentation for all of these platforms.
> 
> https://lore.kernel.org/all/20250308200921.1089980-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
> 
> Cheers, Prabhakar
> ---
>  .../devicetree/bindings/net/amlogic,meson-dwmac.yaml   |  6 ++++++
>  .../devicetree/bindings/net/intel,dwmac-plat.yaml      |  6 ++++++
>  .../devicetree/bindings/net/mediatek-dwmac.yaml        |  6 ++++++
>  .../devicetree/bindings/net/nxp,dwmac-imx.yaml         |  8 ++++++++
>  .../devicetree/bindings/net/rockchip-dwmac.yaml        | 10 ++++++++++
>  Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 10 ++++++++++
>  .../bindings/net/toshiba,visconti-dwmac.yaml           |  6 ++++++
>  7 files changed, 52 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic