Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	 Wayne Schroeder <raz@chewies.net>,
	Kevin Hilman <khilman@baylibre.com>,
	 linux-amlogic@lists.infradead.org,
	Jerome Brunet <jbrunet@baylibre.com>,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
Date: Fri, 23 May 2025 14:16:49 -0500	[thread overview]
Message-ID: <174802762618.2701053.17389702773465611504.robh@kernel.org> (raw)
In-Reply-To: <20250522172535.302064-1-linux.amoon@gmail.com>

On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management.
> 
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v3: dropped remove of usb2_phy1.
> v2: remove usb2_phy1 phy-supply since now it's managed by
> the hub reset control.
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
 Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@gmail.com:

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
	from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
	from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic