From: Manivannan Sadhasivam <mani@kernel.org>
To: christian.koever-draxl@student.uibk.ac.at
Cc: neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
vkoul@kernel.org, mani@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Christian Stefan Kövér-Draxl" <ckoever@outlook.de>
Subject: Re: [PATCH 2/2] phy: amlogic: meson-g12a-usb2: add S4 support
Date: Sun, 01 Nov 2026 16:38:09 +0530 [thread overview]
Message-ID: <179353128971.2955.5743207181968737681.b4-reply@b4> (raw)
In-Reply-To: <20261025192202.209045-3-christian.koever-draxl@student.uibk.ac.at>
On 2026-10-25 20:22 +0100, christian.koever-draxl@student.uibk.ac.at wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
>
> The S4 USB2 PHY follows the A1 programming (MPLL DCO clock select, R21
> calibration, R13 analog settings) with a few differences taken from the
> vendor driver:
>
> - edge drive trim 2 instead of 3,
> - HS disconnect reference 3 instead of 1,
> - a disconnect threshold in R14, and the R13 PMA signal update bit
> set to latch the analog settings.
>
> Without the PMA update the host controller sees no root ports and
> nothing enumerates.
>
> Tested on an S905W2 board: devices enumerate and work behind a hub on
> the host ports.
>
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-11-01 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 19:22 [PATCH 0/2] " christian.koever-draxl
2026-10-25 19:22 ` [PATCH 1/2] dt-bindings: phy: amlogic,g12a-usb2-phy: add S4 compatible christian.koever-draxl
2026-10-30 11:10 ` Krzysztof Kozlowski
2026-10-25 19:22 ` [PATCH 2/2] phy: amlogic: meson-g12a-usb2: add S4 support christian.koever-draxl
2026-11-01 11:08 ` Manivannan Sadhasivam [this message]
2026-11-03 8:56 ` [PATCH 0/2] " neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179353128971.2955.5743207181968737681.b4-reply@b4 \
--to=mani@kernel.org \
--cc=christian.koever-draxl@student.uibk.ac.at \
--cc=ckoever@outlook.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®