From: neil.armstrong@linaro.org
To: u-boot-amlogic@groups.io, christianshewitt@gmail.com,
u-boot@lists.denx.de, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: fix Ethernet on WeTek Hub/Play2
Date: Mon, 18 Mar 2024 09:44:05 +0100 [thread overview]
Message-ID: <19d5d996-71ce-40e6-874f-70f9f1b6c66b@linaro.org> (raw)
In-Reply-To: <20240316135430.826898-2-christianshewitt@gmail.com>
On 16/03/2024 14:54, Christian Hewitt wrote:
> Placing the snps,reset content needed for Ethernet to probe in a common
> uboot.dtsi results in the content not being used and broken Ethernet. Fix
> this by creating two board specific dtsi files with the right content.
>
> Fixes: 67d5128df950 ("ARM: dts: add support for WeTek Hub and WeTek Play2")
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> ...u-boot.dtsi => meson-gxbb-wetek-hub-u-boot.dtsi} | 0
> arch/arm/dts/meson-gxbb-wetek-play2-u-boot.dtsi | 13 +++++++++++++
> 2 files changed, 13 insertions(+)
> rename arch/arm/dts/{meson-gxbb-wetek-u-boot.dtsi => meson-gxbb-wetek-hub-u-boot.dtsi} (100%)
> create mode 100644 arch/arm/dts/meson-gxbb-wetek-play2-u-boot.dtsi
>
> diff --git a/arch/arm/dts/meson-gxbb-wetek-u-boot.dtsi b/arch/arm/dts/meson-gxbb-wetek-hub-u-boot.dtsi
> similarity index 100%
> rename from arch/arm/dts/meson-gxbb-wetek-u-boot.dtsi
> rename to arch/arm/dts/meson-gxbb-wetek-hub-u-boot.dtsi
> diff --git a/arch/arm/dts/meson-gxbb-wetek-play2-u-boot.dtsi b/arch/arm/dts/meson-gxbb-wetek-play2-u-boot.dtsi
> new file mode 100644
> index 00000000000..3743053eb9c
> --- /dev/null
> +++ b/arch/arm/dts/meson-gxbb-wetek-play2-u-boot.dtsi
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2019 BayLibre, SAS.
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + */
> +
> +#include "meson-gx-u-boot.dtsi"
> +
> +ðmac {
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +};
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-03-18 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 13:54 [PATCH 0/3] ARM: dts: fix Ethernet and random MAC's " Christian Hewitt
2024-03-16 13:54 ` [PATCH 1/3] ARM: dts: fix Ethernet " Christian Hewitt
2024-03-18 8:44 ` neil.armstrong [this message]
2024-03-16 13:54 ` [PATCH 2/3] ARM: board: meson: update efuse MAC reading code Christian Hewitt
2024-03-18 8:48 ` neil.armstrong
2024-03-16 13:54 ` [PATCH 3/3] configs: amlogic: set board family to avoid random MAC on WeTek Hub/Play2 Christian Hewitt
2024-03-18 8:50 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d5d996-71ce-40e6-874f-70f9f1b6c66b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=christianshewitt@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®