From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>, Chen Yufan <chenyufan@vivo.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] clk: meson: axg-audio: Use dev_err_probe() to simplfy code
Date: Fri, 30 Aug 2024 19:46:33 +0200 [thread overview]
Message-ID: <1cb1589f-221a-4fee-b7c4-2556e2c14335@kernel.org> (raw)
In-Reply-To: <1jfrqmrru3.fsf@starbuckisacylon.baylibre.com>
On 30/08/2024 16:46, Jerome Brunet wrote:
> On Fri 30 Aug 2024 at 16:01, Chen Yufan <chenyufan@vivo.com> wrote:
>
>> Use dev_err_probe() can make code a bit simpler.
>
> It surely does but ...
>
>>
>> Signed-off-by: Chen Yufan <chenyufan@vivo.com>
>> ---
>> drivers/clk/meson/axg-audio.c | 12 ++++--------
>
> Why this driver alone ?
>
> I have nothing against the change you are doing but I would not want to get a
> single patch for each and every amlogic clock drivers.
>
Look here:
https://lore.kernel.org/all/?q=f:@vivo.com
There is a like a flood of trivial patches started last two weeks. Not
sure if there is any coordination, any oversight or review. Few trivial
ones were introducing bugs, so I suggest caution.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2024-08-30 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:01 Chen Yufan
2024-08-30 14:46 ` Jerome Brunet
2024-08-30 17:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb1589f-221a-4fee-b7c4-2556e2c14335@kernel.org \
--to=krzk@kernel.org \
--cc=chenyufan@vivo.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=opensource.kernel@vivo.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome