From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BA38C4345F for ; Mon, 15 Apr 2024 14:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:From:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=weYNh3lVDvJsNWLcAYLNFZQpqgQ8NaVNk3Bq0njcTzY=; b=YxidlthP1Du1Jz zgsO87sWrf/k+hk0ZnrVj8jKlHkhdqczQKGCqG0wTn2K7lXjnwWhzlzARFEkPl8ncH1o8G4HVTdsR RiXrwAPyNkyu7QbZB/Th4Y7Z8KE7DceD1lmYq53S4MpeVSvmU7IQ89XahAhPU96oqYCuzLdYoYwfN QgZb9xjIkVsYl6RUfTj6ZcOW4QDi9KREuY6FFWMWFMxtfXhaDZkjf9ODrP7aYG/a1RGd+X8Mfp+na cgBOZL6qVtbnAm4dUv6ghig1+EH4AZuwiyM3F8MrILhHfQQERnHfOJCeJxBLTLqd+RUUbIdRkTJp8 UzSB9M0ZWLAeVE2divQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwN9l-00000008eWG-1Yee; Mon, 15 Apr 2024 14:18:01 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwN9e-00000008eUZ-2BXA for linux-amlogic@lists.infradead.org; Mon, 15 Apr 2024 14:17:59 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240415141746euoutp02614ce28b8f0dc6ee6d9a03826cabc828~GedWLYGFe0461804618euoutp02d for ; Mon, 15 Apr 2024 14:17:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240415141746euoutp02614ce28b8f0dc6ee6d9a03826cabc828~GedWLYGFe0461804618euoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1713190666; bh=zaHlAEoiDKROJY7VOEH6En1JrEsx1/tm4GCi694dG7o=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=b9Q13URlzeRiG4F0ITi/a/4+aFY0gCm05XCT180UqfbY28Z5TJVziXSjDq7RT8cFR 8uv0kOp0UFK+eVSpDnC/xBsmFby2HlE5C9dfeB2im6rHhFB2x72MwxSlRxlFVSH5h2 4zuR1GO513ZL1O1qTNIBNuKrrFVgOnCojSdD1Ni8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20240415141745eucas1p2243811eae4b291a2963c6a4190d087d0~GedVySrfo0944809448eucas1p2Q; Mon, 15 Apr 2024 14:17:45 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 8A.58.09624.9073D166; Mon, 15 Apr 2024 15:17:45 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240415141745eucas1p2570fd7509a5d42276a70504803c9988f~GedVY0Akn0944409444eucas1p2O; Mon, 15 Apr 2024 14:17:45 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240415141745eusmtrp230c0618bb0db5f6b21a686d02e3b0716~GedVX96FJ1064510645eusmtrp2f; Mon, 15 Apr 2024 14:17:45 +0000 (GMT) X-AuditID: cbfec7f2-c11ff70000002598-82-661d370959d9 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C0.4D.09010.9073D166; Mon, 15 Apr 2024 15:17:45 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240415141744eusmtip2cf1c1d1487a68e62858ad1ebd209a3b7~GedUvxdsZ2056220562eusmtip2U; Mon, 15 Apr 2024 14:17:44 +0000 (GMT) Message-ID: <1dd9e3a1-29d0-4628-9b6a-b7e9fc09bf0f@samsung.com> Date: Mon, 15 Apr 2024 16:17:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/15] tty: serial: switch from circ_buf to kfifo To: Jiri Slaby , gregkh@linuxfoundation.org, linux-amlogic@lists.infradead.org, "linux-arm-msm@vger.kernel.org" Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Content-Language: en-US From: Marek Szyprowski In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHKsWRmVeSWpSXmKPExsWy7djPc7qc5rJpBi+bTSy2ddhYNC9ez2bx 5tERZot3c2UsfrZvYbLomLydxWLBbG6LifvPsltc3jWHzeLM4l52i2OLTrJYvN95i9GBx+P9 jVZ2j6cTJrN7bFrVyeZx59oeNo/9c9ewe2xeUu/xeZNcAHsUl01Kak5mWWqRvl0CV8bld0eZ Cx4KVFw7OpmpgfEwbxcjB4eEgInEiRccXYxcHEICKxgldly8ywjhfGGU+NB2mQnC+cwoMWHR ShaYjnWvayHiyxkl/n7cyArhfGSUmL3/MHsXIycHr4CdxNEp3WwgNouAqsTD9/fYIOKCEidn PmEBsUUF5CXu35oBVi8s4Cpx6c1bNpBBIgIrGSUuPLgG5jALnGSSuPu8EayKWUBc4taT+Uwg NpuAoUTX2y6wqZxA217ff8sIUSMvsf3tHGaQZgmBfk6Jr18+soIkJARcJL7tusEEYQtLvDq+ hR3ClpH4v3M+E0RDO6PEgt/3oZwJjBINz28xQlRZS9w594sNFALMApoS63fpQ4QdJW7+7GeF BAyfxI23ghBH8ElM2jadGSLMK9HRJgRRrSYx6/g6uLUHL1xinsCoNAspYGYheXMWkndmIexd wMiyilE8tbQ4Nz212DAvtVyvODG3uDQvXS85P3cTIzCJnf53/NMOxrmvPuodYmTiYDzEKMHB rCTC2yIsmybEm5JYWZValB9fVJqTWnyIUZqDRUmcVzVFPlVIID2xJDU7NbUgtQgmy8TBKdXA ZP3y+L2jwa1NNjd83+5V7FNulOia1OLiM7kmdb/F08NSkw9ti8tYKHr019u/9n6MneemsfVG FK2acmhy6ARf9eBezmN7KpvV2g4l+mgzLxPomv3jof0u7/RPmeKT8/1mzi+srfsZt2RR98X3 mcG1ZTZZwklPdZsn8j4Uk/m2qVtF+iDD/gsqN3u/LPZeZySeEb5a9eMToWM7FjZOq3GW+1h0 /vmCGxPTPj1aJvDScCKzzfI/2darXbdsyWra9+bqKfc7rOobN/8V2qE2SUI9693HST8mHazi veb1Um8uh2fg+oC+S086ju57mLDB0vWciuj1tlU9cmcPZBzL+3TnrXc198dl04vPOnPqfI4s Z1ZiKc5INNRiLipOBABzmhc10QMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t/xe7qc5rJpBr+2SFhs67CxaF68ns3i zaMjzBbv5spY/GzfwmTRMXk7i8WC2dwWE/efZbe4vGsOm8WZxb3sFscWnWSxeL/zFqMDj8f7 G63sHk8nTGb32LSqk83jzrU9bB77565h99i8pN7j8ya5APYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYzL744yFzwUqLh2dDJTA+Nh3i5GDg4J AROJda9ruxi5OIQEljJKfF90n6mLkRMoLiNxcloDK4QtLPHnWhcbRNF7RokTs1+zgCR4Bewk jk7pZgOxWQRUJR6+v8cGEReUODnzCViNqIC8xP1bM9hBbGEBV4lLb96CDRIRWMkoMXH7SnYQ h1ngNJPE6osPWaHuYJK49a8R7A5mAXGJW0/mg9lsAoYSXW+7wFZwAq1+ff8tI0SNmUTX1i4o W15i+9s5zBMYhWYhuWQWklGzkLTMQtKygJFlFaNIamlxbnpusZFecWJucWleul5yfu4mRmDc bjv2c8sOxpWvPuodYmTiYDzEKMHBrCTC2yIsmybEm5JYWZValB9fVJqTWnyI0RQYHBOZpUST 84GJI68k3tDMwNTQxMzSwNTSzFhJnNezoCNRSCA9sSQ1OzW1ILUIpo+Jg1OqgWniynX53Dv4 vms6v7pgkHE5fHLp5HWr3yjx1mhcXxdoMW1bluPiTWZLpy26VTJncuGv26+W3T1iKO27v7FU 3CHcwz+Or9DBrFz3xJa53QHfvPZ5RkX47Jq8q3viyhmaZfMV88+2zPb8wvpUZJp1gF2bd92k b3duRZ8qtDKTmXSX24ax+YmLwLs8x4RbOa2T35399elzpbaZu5/6xM2Fux0EX056mnhrBn9X 2hPf2C1CqydMUOuQ7yxaO3f/03Nh35vEo7S15l8VyPJ/NOvZ/H3Z3h+fVvknhqpl8y/5f884 pcEl/tWP80+uHkiI283+dXO67icX+SiB5Gs//i/VTisru+j0OuU7P1/p1vOvNiYrsRRnJBpq MRcVJwIAN2bmOGQDAAA= X-CMS-MailID: 20240415141745eucas1p2570fd7509a5d42276a70504803c9988f X-Msg-Generator: CA X-RootMTR: 20240415125847eucas1p2bc180c35f40f9c490c713679871af9ae X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240415125847eucas1p2bc180c35f40f9c490c713679871af9ae References: <20240405060826.2521-1-jirislaby@kernel.org> <20240405060826.2521-13-jirislaby@kernel.org> <91ac609b-0fae-4856-a2a6-636908d7ad3c@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_071755_614966_079B854A X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 15.04.2024 15:28, Jiri Slaby wrote: > On 15. 04. 24, 14:58, Marek Szyprowski wrote: >> On 05.04.2024 08:08, Jiri Slaby (SUSE) wrote: >>> Switch from struct circ_buf to proper kfifo. kfifo provides much better >>> API, esp. when wrap-around of the buffer needs to be taken into >>> account. >>> Look at pl011_dma_tx_refill() or cpm_uart_tx_pump() changes for >>> example. >>> >>> Kfifo API can also fill in scatter-gather DMA structures, so it easier >>> for that use case too. Look at lpuart_dma_tx() for example. Note that >>> not all drivers can be converted to that (like atmel_serial), they >>> handle DMA specially. >>> >>> Note that usb-serial uses kfifo for TX for ages. >>> >>> omap needed a bit more care as it needs to put a char into FIFO to >>> start >>> the DMA transfer when OMAP_DMA_TX_KICK is set. In that case, we have to >>> do kfifo_dma_out_prepare twice: once to find out the tx_size (to find >>> out if it is worths to do DMA at all -- size >= 4), the second time for >>> the actual transfer. >>> >>> All traces of circ_buf are removed from serial_core.h (and its struct >>> uart_state). >>> >>> Signed-off-by: Jiri Slaby (SUSE) >>> ... >> >> This patch landed in linux-next as commit 1788cf6a91d9 ("tty: serial: >> switch from circ_buf to kfifo"). Unfortunately it breaks UART operation >> on thr Amlogic Meson based boards (drivers/tty/serial/meson_uart.c >> driver) and Qualcomm RB5 board (drivers/tty/serial/qcom_geni_serial.c). >> Once the init process is started, a complete garbage is printed to the >> serial console. Here is an example how it looks: > > Oh my! > > Both drivers move the tail using both kfifo and uart_xmit_advance() > interfaces. Bah. Does it help to remove that uart_xmit_advance() for > both of them? (TX stats will be broken.) > > Users of uart_port_tx() are not affected. > > This is my fault when merging uart_xmit_advance() with this series. Yes, removing uart_xmit_advance() from both drivers seems to be fixing the console output. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic