From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 2/2] clk: meson: g12a: add cpu clocks
Date: Thu, 7 Mar 2019 13:24:45 +0100 [thread overview]
Message-ID: <1e0f2d89-7fc1-a2d1-6691-60ff9e1098e8@baylibre.com> (raw)
In-Reply-To: <CAFBinCAax7=dbLxTNtSrJJthuFb02+7YMyGwpie28F1bnr0qRw@mail.gmail.com>
Hi Martin,
On 05/03/2019 22:10, Martin Blumenstingl wrote:
> On Mon, Mar 4, 2019 at 2:12 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add the Amlogic G12A Family CPU Clock tree in read/only for now.
>>
>> The CPU clock can either use the SYS_PLL for > 1GHz frequencies or
>> use a couple of div+mux from 1GHz/667MHz/24MHz source with 2 non-glitch
>> muxes.
>>
>> Proper DVFS support will come in a second time.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> in my previous review I criticized that the post-dividers are not
> mentioned in the description.
> it's not part of v2 but after having a closer look again I think it's
> not a big issue:
> these CPU post-dividers are all marked as read-only and have a comment
> that "ROM monitor code" manages them.
Sorry indeed I forgot to say a word about this, but you pointed the right
thing, they are only here to be complete, not to be used (for now).
Neil
>
> disclaimer for my "reviewed-by":
> - I don't have access to the datasheet so I can't verify if the clock
> tree from this patch is correct
> - the latest buildroot code with G12A support
> (buildroot_openlinux_kernel_4.9_fbdev_20180706) doesn't have proper
> names for all clocks
> - this review is based on my experience with Meson8* (where Linux also
> manages the CPU clock, unlike on the GX SoCs where it's managed in
> firmware)
>
>
> Regards
> Martin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-07 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:11 [PATCH v2 0/2] clk: meson: g12a: Add CPU Clock support Neil Armstrong
2019-03-04 13:11 ` [PATCH v2 1/2] clk: meson-g12a: add cpu clock bindings Neil Armstrong
2019-03-05 21:03 ` Martin Blumenstingl
2019-03-12 18:31 ` Rob Herring
2019-03-04 13:11 ` [PATCH v2 2/2] clk: meson: g12a: add cpu clocks Neil Armstrong
2019-03-05 21:10 ` Martin Blumenstingl
2019-03-07 12:24 ` Neil Armstrong [this message]
2019-03-19 9:38 ` Jerome Brunet
2019-03-19 9:39 ` [PATCH v2 0/2] clk: meson: g12a: Add CPU Clock support Jerome Brunet
2019-03-19 20:23 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e0f2d89-7fc1-a2d1-6691-60ff9e1098e8@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®