From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC688CCD1BB for ; Wed, 22 Oct 2025 11:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NAGU3smp8AtsYoe0+xzp4VRMBKGbZkxWrE3agbUSFBI=; b=d4h6mL92g3Qy0G Tt/DWm3zlaZQa0sqmZWKUoLTvu3N3pnvUChOu2E4WSkc2G0ZhR/kTgKiOYSX4HfvaXH62KQjTmS9N 3CuT9giUrOaSnZFLYLnWD8Y1zBsnwde6XZaxjekJDGP4uswQfesjTnHZ6uykEOHPnkITHUrYQ70ag EUImpEoH2/TYhpKN20BL1cF8wpjjT3HfgSWIOHwmu2QbpzXytcCi135g5ErKflsNqatF3eFlrGw/o BfqIyNGsI6S2fd8DcOiZDR6PSQdaN0MmRVUtMDlc3QpqYuJ0Ue8AKUWxzhJVfh+XHTSbiBkabZhKo /mTuXsEY5FBI0nZuvn0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBXTP-00000002jPj-2tgC; Wed, 22 Oct 2025 11:57:48 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBXTL-00000002jOb-0FnC for linux-amlogic@lists.infradead.org; Wed, 22 Oct 2025 11:57:45 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-46fcf9f63b6so38022705e9.2 for ; Wed, 22 Oct 2025 04:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1761134261; x=1761739061; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=nvWvVWsMp2HvZc/pRVfJNYeSWgEzu4aPg/sGoBmwFsM=; b=Phavu5UevBu5aBkp0/ZIlmPv+7T/5eTOy9BHfw5DlBBhqADtDUM6ugKhStNf2tFlgq uITu1bgTeMBevhGpyRK7Jpvf8n/+Xm+veKEa3nDBuAvetrBAyAq2JN9bscrmADcJzakU cMtuGNt3jFSzmR0/FxWChwjzFdSOsYqDhBqBsqYl9a8IIYSOhXD6oYxyAN3C9tlVIp7N 8O2pYTT0fImAq6qu8e0KQ+TwA+nMtDohUixygs5SNPI3OoC3Eug06zKP/PvhYSxwYgpf 4nfrrrnMG+3kWSalvuuvJvgs1xiiwPoN9EJrkC1gHOghg503XO4nPnv4BYMP9rlGKoC2 eKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761134261; x=1761739061; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nvWvVWsMp2HvZc/pRVfJNYeSWgEzu4aPg/sGoBmwFsM=; b=sfMRmRFyGxWWAyEnMGzVrj3UPulHawmcCgDN3i3shOiYyVVLLVbiQt7DJyxuTQ81D4 7mokAy8Acv/jfNYgoIYDiaM9ed0deZ6ZsQkqHnuJoT8z4zRfM1V72OuRVefubRXKSPnm g2KFjDCUJWyykTB9krSk62S+wzH9IN/+gij5xlXO+27DM2TX8pkBWSMWpqguQ+REaSv2 fy1h0kYS0JTkzYbfpbQFKt3MGoeklwM6lQLw3snaIZmZwlnp0RTV4YyYcyKjjmLELAi+ CMyOeSeGheJX30S4hXaLJyyiCGOq5dgwZ2fAQMzutw4M3k0KP43RJoVhU9k89Doxg6KT DcZQ== X-Forwarded-Encrypted: i=1; AJvYcCXw8eYbkL0XiHpGlV1CQFL7xh1zQR1DxvMBYX8TonGtAbvu/xyKTWI3CaL1JMHCp4sohQHUzi+xt8uszZ1Y@lists.infradead.org X-Gm-Message-State: AOJu0Yw6UF7AmrGLh9/ox3r1fGwcKTX6yc+K2D4Ent9B2hMraz7YRNGD iej3AZ2QTPVypJdvNqaP+S1MeeP7N7AyRjS6GdMSL4uQ9VZwQW3pc4Nai68A/aRXOFw= X-Gm-Gg: ASbGncuzAe4iYqUJM/1DfMTTe2JQ5H/kNd9dzpyTDk3HOFZbu4Z7XFrStdKNd6X2J42 lfW9tjr6OcVU2ycMecdkQ9J3OIqaxS1SuTb12WHEfGdDQg0SUkXTuBNSTiFW8efjbXOLLz8XKB8 r8NLXLtlIhxmmb8QIYCQ07zWCLAYQENl3QLf5jVN4jkQBi/njfFEt28gO2mG8d8RyGlIAAJCyjx iOVsZ7i0xypmlIhWlzairKKRRSt7zuwNxdKsVi2uojCPQIw23E+HaiuEfnuzH4NHbmXkX6ly0Oe Piy+ltmzBn7ERbsM7m9xj1+yXtjhgn2fOIRb69LsGgjlLepzoLCUCRxTp0YZ59dXz3cjKLHIRSW 0QGsWUIRGf95EgetWet87P8JQY4scXlMQUxnbMem5WBPD5rtbBn5PbI+jTLPz7M1kctMPa16Nrf 0mDthnBKTpLQ== X-Google-Smtp-Source: AGHT+IHU1kUQ/j+2c0DWldc7DeJQPageEV0i7vez8IloaeUnW6bD/qTCz4m2QvWTUpZaGhquDY3CAg== X-Received: by 2002:a05:600c:6385:b0:458:a7fa:211d with SMTP id 5b1f17b1804b1-47117912365mr156602265e9.29.1761134260710; Wed, 22 Oct 2025 04:57:40 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:bdae:f4f4:58be:ea26]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475c42d9524sm39570535e9.18.2025.10.22.04.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 04:57:40 -0700 (PDT) From: Jerome Brunet To: Chuan Liu via B4 Relay Cc: Neil Armstrong , Michael Turquette , Stephen Boyd , Kevin Hilman , Martin Blumenstingl , chuan.liu@amlogic.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] clk: amlogic: Fix out-of-range PLL frequency setting In-Reply-To: <20251022-optimize_pll_driver-v1-1-a275722fb6f4@amlogic.com> (Chuan Liu via's message of "Wed, 22 Oct 2025 14:58:51 +0800") References: <20251022-optimize_pll_driver-v1-0-a275722fb6f4@amlogic.com> <20251022-optimize_pll_driver-v1-1-a275722fb6f4@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 22 Oct 2025 13:57:39 +0200 Message-ID: <1j8qh34098.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251022_045743_301976_4DE6D912 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed 22 Oct 2025 at 14:58, Chuan Liu via B4 Relay wrote: > From: Chuan Liu > > meson_clk_get_pll_range_index incorrectly determines the maximum value > of 'm'. This explanation is little light ! How did the problem show up ? Under which condition ? How did you come this conclusion ? Other people having problems might benefit from the explanation > > Fixes: 8eed1db1adec6 ("clk: meson: pll: update driver for the g12a") > Signed-off-by: Chuan Liu > --- > drivers/clk/meson/clk-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c > index 1ea6579a760f..b07e1eb19d12 100644 > --- a/drivers/clk/meson/clk-pll.c > +++ b/drivers/clk/meson/clk-pll.c > @@ -191,7 +191,7 @@ static int meson_clk_get_pll_range_index(unsigned long rate, > *m = meson_clk_get_pll_range_m(rate, parent_rate, *n, pll); > > /* the pre-divider gives a multiplier too big - stop */ > - if (*m >= (1 << pll->m.width)) > + if (*m > pll->range->max) Making sure m does not exceed the maximum value is valid too. You should check both conditions then > return -EINVAL; > > return 0; -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic