From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4522D29FE6 for ; Wed, 14 Jan 2026 10:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GKV8JYdbVjk11aCPsZIEW6SO6utZWBsTyPV87EY9yyY=; b=LWnmvedq+Wxqyw WtpZVNMSR9wJcyLolr8Uvx6EEQXUtBNxIWB7qIIuReheA870HHcSCJ81isf7UXbxs4ygf/byur0di tUIb0oOKoQp5kCV6WhI0pAv+wnmaR9yoVscHbzf8zqG/4QJMM9a+/cLn1l9Cr7YPpbEtF/yox4kUw g08lbntpJSPuO7s1Mtfx+xPjwIi9p7Nci9cNvXeOtKFcXSHZPlAXnU2GZq5ViS5rGNbXKcj6ok3TG RSXn3nkPvpmNkLO3lwlrOgiDahceSIjGoP1+/jk6UTUgURRFQ/Y07yn/nMYQpqenETbUm2xEyBjgX iP+XOAr7ckMN5awLv2IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfyJN-00000008pps-3qZ4; Wed, 14 Jan 2026 10:41:14 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfyJH-00000008pnW-1hfq for linux-amlogic@lists.infradead.org; Wed, 14 Jan 2026 10:41:12 +0000 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso50061715e9.1 for ; Wed, 14 Jan 2026 02:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768387265; x=1768992065; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+NcxQNU+z+mjpVWzVO5zIslJ+Ha+xCleufzRRdU3nw0=; b=Rs1VMoaGExrvIbqfJgrIObFoy8mvwJ6Hm4YcHlpedB5SoOlXvf5JydBnIA4R7azzHk oIiiGV2paaljr2fXBRgug/Aj2ywMssyAQKoIeNAXikz04uBHXuCPC1ofNfN/Nu0I7enm d+shSZ2qRK7eSw3ldOq0mu+Z0fyX/BPQWrddqG7/hru26Mt1b0tv9GdlvMz0bYcieY8l n/1ocAxQnogi91rlNEDaYhaDGLyyHrmhsg3JvDCSYZLiUS71WvAJdkc6M0BYC5pLlxFB cbeXJ0UKB8iN3GnyQgewwA0j0X8eBKh9PBIxc2d+gBYSempyoxe0D/fgU7y7hRBhMxds Ac6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768387265; x=1768992065; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+NcxQNU+z+mjpVWzVO5zIslJ+Ha+xCleufzRRdU3nw0=; b=h6xPyygRaabIeUb1lTRXXlxXiv/k6CVOilFwKyxThcxz6S5DaV7B29CHy6zk+RrwXw n5w6ifsiCpI7ycyEoC/1FW7iVWQoX8gTq+j+QnDpnmJVSpu4UGXyL0sA8KxgiWfKh/3+ NKvjkcsRUGqLNdEWShkTHw55LExaHB4YJzfCMfYBziHcY7kxDcNYJp/rTFS9J3eiF7Px bvQ1Gy1MiGjIRuNVtjPXmATJ4QeTNidHyskLZCQtCaGm1gE1BlToy7TfFugr+SGnXq+H K0CGq/W/G+rBoLKtceviO01CLyOd2l5alirC1qS86ZAxmxouMugQz6s4DNozgdB7/N3k bViA== X-Forwarded-Encrypted: i=1; AJvYcCWxsZR8CuncKszUo9XD6lPTuWY8whQ1vDiKwgPmakfZNXQq4iwZARjUysi0Cs0+Glpv8DvdbdWswW6yRjLd@lists.infradead.org X-Gm-Message-State: AOJu0Yx2hc08YSF2RNZuGQjnKCUf2b0G3Pi0KVsytBcZxwlUwhSSzQg8 pDoWegKoEq/cr4yetmnjywJLjOOxrRmz4XMyrC64+mCSI4Uwq23e/HCqLap/M9bubYc= X-Gm-Gg: AY/fxX5fq5PMLqOH8Z4gTnqbQ/oahSGsPohFMKWIxeWCHG/iuDpYhgu3gleoDZtma8H VFKLtIDncJgUNk4KxqN92YWhandPcYi06W8Sp8FN9HmG0RcJpuQiOdQP1qKlMDhRMJbckiNCnNV WEVC+ovPsR4TNy5EyNa2X6z9zaGsCi7+V9Qpc82E4L/BdFE+Q31mAyECnx+q/0cOsWMP64/guqS +bbLz1+6T9jVgcGPExZcjQMM1QqHC2lk2UtxNfz/2lEfey3VgDBKNf6gbs034p+BcOO8pNZdc52 q3tvoyXpDLYXDZYcH/zQdoh6uw0FwuqXwD7yt3qEW4zHMEFumMx4gE7M3ox81Sd21XY2uNkbKtY X8gby7Z0cGP6Zy/pMg7nHWB1BVKytC8bav/EiOnwDWIBod4+7qnvgdwkmL0HY5zD5k6pKIMN8Uf G7LbkYChuJxA== X-Received: by 2002:a05:600c:5490:b0:47e:e20e:bba4 with SMTP id 5b1f17b1804b1-47ee3356e79mr22358195e9.18.1768387265370; Wed, 14 Jan 2026 02:41:05 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:f2cc:bd72:2de3:86cd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47ee578d37esm21654835e9.1.2026.01.14.02.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 02:41:04 -0800 (PST) From: Jerome Brunet To: Neil Armstrong Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] arm64: dts: amlogic: s4: assign mmc b clock to 24MHz In-Reply-To: (Neil Armstrong's message of "Wed, 14 Jan 2026 10:05:35 +0100") References: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> <20260114-amlogic-s4-mmc-fixup-v2-1-7e9ab5f12286@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 14 Jan 2026 11:40:59 +0100 Message-ID: <1jikd4xyro.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260114_024108_012155_39C272E7 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On mer. 14 janv. 2026 at 10:05, Neil Armstrong wrote: > On 1/14/26 09:56, Jerome Brunet wrote: >> The amlogic MMC driver operate with the assumption that MMC clock >> is configured to provide 24MHz. It uses this path for low >> rates such as 400kHz. >> This assumption did hold true until but it now, but it is apparently >> not the case with s4. The clock has been reported to provide 1GHz >> instead. This is most likely due to how the bootloader is using the MMC >> clock on this platform. >> Regardless of why the MMC clock rate is 1GHz, if the MMC driver expects >> 24MHz, the clock should be properly assigned, so assign it. >> Reported-by: Nick Xie >> Closes: https://lore.kernel.org/linux-amlogic/20260113011931.40424-1-nick@khadas.com/ >> Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") >> Tested-by: Nick Xie >> Signed-off-by: Jerome Brunet >> --- >> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> index 9d99ed2994df..62538fd9db6b 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >> @@ -838,6 +838,10 @@ sd: mmc@fe08a000 { >> clock-names = "core", "clkin0", "clkin1"; >> resets = <&reset RESET_SD_EMMC_B>; >> status = "disabled"; >> + >> + assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_B>; >> + assigned-clock-parents = <0>; > > In this case, assigned-clock-parents should be dropped. > Dunno why I thought that was always required. I'll fix it and the other instances > Neil > >> + assigned-clock-rates = <24000000>; >> }; >> emmc: mmc@fe08c000 { >> -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic