From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A43C43603 for ; Wed, 11 Dec 2019 09:34:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93CFF20637 for ; Wed, 11 Dec 2019 09:34:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PzpTuLKE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="VzDedKeM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93CFF20637 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Lz/Rtb2LqqwD7uGTqJwYWyjy+zpZoNuWszqAdvdchAQ=; b=PzpTuLKEOaDZVNtI8i68tv13AZ rB1Yxf7Mg4LJB1/RgaWxmpC/egxQGC8syOfTfN0boH6PZ1LTzKYKm5DldHB74tUALgprdu+M/IAgj zsP7LbzpdRYrfFsGeLkIyyMkKnV5zmZJP+4V2bj9+2tPorYDKWJgUpkz/+aJP5iR2T+3EsRzk4YMi efDTRS7Cdx6eBvBKccshketG/8oaf4fokoDJqlb5+cf6gEwPV7PuWTP2M7YoVSZndXizymCp9gZjJ Z7JhG9u3xB6+XZy6QVdgrQvdOTFx/HhxFBFm1qj0E8Vn2OFa/3SxPn2+Ddp9i/bZt9ruvxCiFo2zT l8+jMaHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieyO1-0004SV-Lw; Wed, 11 Dec 2019 09:34:25 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieyNv-0004M6-1B for linux-amlogic@lists.infradead.org; Wed, 11 Dec 2019 09:34:21 +0000 Received: by mail-wm1-x342.google.com with SMTP id q9so6246084wmj.5 for ; Wed, 11 Dec 2019 01:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=2aHze3eD3qXxFb1do0AXNxi5Ns/Q9Iwwz2n3HPpJOcs=; b=VzDedKeMxQaNjEiczxGBTICIPaIV8PnAeFP1Rr1OgYLJI0XPPZ8hsic40cqjmiTyo3 wYTDItCB0zXtkyaI42IJsnUV4D0yQCvnTnWO3F00uZ7dPqoIFPgzSDJBLe65rRZm3OVe OBqCyUpJ+xq6g5nVO5nm6OYpdhun8nWnR8INhbYMnRBLIoascaSdvzMpS+J6p25Kre8e 3KkQ/rMdUKCU6OmbCGynjh0CgUo5q/5lFiY9bc8rvWo4BnD7+Xts/5+fBpVBAtTHkOU5 Syju8hBbNEbXRwgUmdisOR4FPwKw6Ut1p/I1D6tKeY03HyZFcugKDOCcrRv1IzQ5jJwx QY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=2aHze3eD3qXxFb1do0AXNxi5Ns/Q9Iwwz2n3HPpJOcs=; b=HS0axMJWFS4xiAr8H5oWWlAmOhlL7bDDOnVqPjDU1GImdYn+nr/mVmvnnYbSqcWLqX R8vKKTUgEZYkclu40RD72jqS5IZNXpTnmNcSQfFiJHvhQOooXKoHlKjomkQ3zb95eXe9 AP4pIYU37/doNpBotQ5Jb2v2GpAbw9KrwblJoXJETPaLGJaRKNhe7fUAQbHlJ+K0gP6a G8eT1JyRwLB4qDlYUNcnlJWx0KUIfSzbkJf2DK0DMt6B0IRGwFYoRSH3knmlFK5D6jHd 4mKzq5CdVkqvxeuvJbNcdyuPDfIuZGeolGzCziigha3wce9NcsMFDDxfTO0x0ZWlgeyx v7iQ== X-Gm-Message-State: APjAAAV7yZlMJjJ+MN72ynY9XsRH6SyVIi74E7ITA1fTemFg5zpIYTgG kcO38MeN/iG5ONCTUGo/iKEa4w== X-Google-Smtp-Source: APXvYqyaiVVPEaixzSy9hFWroTUOlG1fayabOrFMoHshKKilcKu2iFPikVV+wuyvp7vTFK3Tb0XS2Q== X-Received: by 2002:a1c:9e49:: with SMTP id h70mr2604822wme.79.1576056857130; Wed, 11 Dec 2019 01:34:17 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id y10sm1594428wmm.3.2019.12.11.01.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 01:34:16 -0800 (PST) References: <20191211032802.83309-1-jian.hu@amlogic.com> User-agent: mu4e 1.3.3; emacs 26.2 From: Jerome Brunet To: Jian Hu , Neil Armstrong Subject: Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes In-reply-to: <20191211032802.83309-1-jian.hu@amlogic.com> Date: Wed, 11 Dec 2019 10:34:16 +0100 Message-ID: <1jk173kxyf.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_013419_092516_5453AB06 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Jianxin Pan , Wolfram Sang , Martin Blumenstingl , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed 11 Dec 2019 at 04:28, Jian Hu wrote: > There are four I2C controllers in A1 series, > Share the same comptible with AXG. Compared to AXG, > Drive strength feature is newly added in A1. Until here, OK > This patch depends on A1 clock driver. This last sentence is a valuable piece of information for the maintainer but should not appear is the commit description as it is something we want is the history Please move this bellow the '---' *AND* Add a link like " https://lkml.kernel.org/r/..." to help the maintainer locate the related series > > Signed-off-by: Jian Hu > > --- > This patch depends on A1 clock patchset at[0] > > Changes since v1 at [1]: > -change reg length to 0x20 > -assign i2c bus alias in dts file > -add new feature note compared to AXG in changelog > > [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com > [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com > --- > --- > .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 + > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++ > 2 files changed, 146 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts > index 69c25c68c358..2d0457976233 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts > @@ -13,6 +13,10 @@ > > aliases { > serial0 = &uart_AO_B; > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; It is not necessary to define alias for all the possible buses, especially it some won't be used on the platform. Will this platform use all 4 busses ? In any case, the aliases can added later, as needed when the related i2c bus is enabled on the board > }; > > chosen { > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index eab2ecd36aa8..66d5206a57de 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -117,6 +117,46 @@ > }; > }; > > + i2c0: i2c@1400 { > + compatible = "amlogic,meson-axg-i2c"; > + reg = <0x0 0x1400 0x0 0x20>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clkc_periphs CLKID_I2C_M_A>; > + status = "disabled"; > + }; > + > + i2c1: i2c@5c00 { Please order nodes by address when then have one. The 3 following i2c busses should appear after the uarts > + compatible = "amlogic,meson-axg-i2c"; > + reg = <0x0 0x5c00 0x0 0x20>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clkc_periphs CLKID_I2C_M_B>; > + status = "disabled"; > + }; > + > + i2c2: i2c@6800 { > + compatible = "amlogic,meson-axg-i2c"; > + reg = <0x0 0x6800 0x0 0x20>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clkc_periphs CLKID_I2C_M_C>; > + status = "disabled"; > + }; > + > + i2c3: i2c@6c00 { > + compatible = "amlogic,meson-axg-i2c"; > + reg = <0x0 0x6c00 0x0 0x20>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clkc_periphs CLKID_I2C_M_D>; > + status = "disabled"; > + }; > + > uart_AO: serial@1c00 { > compatible = "amlogic,meson-gx-uart", > "amlogic,meson-ao-uart"; > @@ -171,3 +211,105 @@ > #clock-cells = <0>; > }; > }; > + > +&periphs_pinctrl { > + i2c0_f11_pins:i2c0-f11 { > + mux { > + groups = "i2c0_sck_f11", > + "i2c0_sda_f12"; > + function = "i2c0"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c0_f9_pins:i2c0-f9 { When the nodes don't have an address, please order them alpha-numerically by node name. > + mux { > + groups = "i2c0_sck_f9", > + "i2c0_sda_f10"; > + function = "i2c0"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c1_x_pins:i2c1-x { > + mux { > + groups = "i2c1_sck_x", > + "i2c1_sda_x"; > + function = "i2c1"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c1_a_pins:i2c1-a { > + mux { > + groups = "i2c1_sck_a", > + "i2c1_sda_a"; > + function = "i2c1"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c2_x0_pins:i2c2-x0 { > + mux { > + groups = "i2c2_sck_x0", > + "i2c2_sda_x1"; > + function = "i2c2"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c2_x15_pins:i2c2-x15 { > + mux { > + groups = "i2c2_sck_x15", > + "i2c2_sda_x16"; > + function = "i2c2"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c2_a4_pins:i2c2-a4 { > + mux { > + groups = "i2c2_sck_a4", > + "i2c2_sda_a5"; > + function = "i2c2"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c2_a8_pins:i2c2-a8 { > + mux { > + groups = "i2c2_sck_a8", > + "i2c2_sda_a9"; > + function = "i2c2"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c3_x_pins:i2c3-x { > + mux { > + groups = "i2c3_sck_x", > + "i2c3_sda_x"; > + function = "i2c3"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > + > + i2c3_f_pins:i2c3-f { > + mux { > + groups = "i2c3_sck_f", > + "i2c3_sda_f"; > + function = "i2c3"; > + bias-pull-up; > + drive-strength-microamp = <3000>; > + }; > + }; > +}; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic