From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35EB5C43603 for ; Mon, 16 Dec 2019 11:22:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06D60206D3 for ; Mon, 16 Dec 2019 11:22:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o7ZlX4eO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="qC2K4KTY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06D60206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ZMWb1bw9cN7D8/Sdz6JiGPPrLrLNWDjZVyKiajRE+lA=; b=o7ZlX4eO7QjVir276qdXJBrv/2 igQ39hLsOuWm3zyGzVQI8rdxqmzXxqVVisOn+Osq0m7czWcGRKdv1++8JMBSdI4EOKaZ4Bs7z0BcZ /SCt+QJr+glAG2MbgXshy0RDCKHUjz8kmSSsLgOAHJxo8Oo9xGxKgTp0fdmxiwDgMWoYLxCbXAljK pEFsEAhbT1itVsJo2QIURezZiJMxA7nlI23v1iZcsSzU854bOCpj5YHLPTykJQvwTQTjU/kRc6mE/ CmkjlE/X5Gd3zsENhB2ieqbwb7BVpVLt5nn6IHGW9Yjb93DwsMK4QndtInItiMWZGMDSFsL1AfcQI xJV+lh6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoSG-0007WG-0S; Mon, 16 Dec 2019 11:22:24 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoRj-0006dL-Br for linux-amlogic@lists.infradead.org; Mon, 16 Dec 2019 11:21:53 +0000 Received: by mail-wm1-x343.google.com with SMTP id p17so6276880wmb.0 for ; Mon, 16 Dec 2019 03:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=cl0rAMLqqZ3vDX0ytFuKFHQWL+5kw7GkHR6k2JTXXWs=; b=qC2K4KTYi+HAmeVp1g+GJ7rpwe9o8iLBeAuo+VRD+ciwGilXWVRHxRgwey5RAPE2Cr s8l2O4jNJs1ycBBORqMjWAOsAR7ahxytekVVQssAhlI/VbrD4DhEFIufFQ3Wjl7Vc206 XHqWkxoClvveHskQ/V2Z2CPPwkiOAZhzS2bd73KV+vmYNXLQ3d2FBQ469Z91wI4ySqe4 p5YBbLd4p+3UDfRCXIGOR2q+taVmR4/f1bnSyHvW/ERADWraiBGfXNjwXYbiblpOZVsq Oc6vI8GQNLd2VFAEPwa3bQymsQnGC77o7jQFOQyYJdzNyw9DfRYkmAOnzb083mrZX9e6 An7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=cl0rAMLqqZ3vDX0ytFuKFHQWL+5kw7GkHR6k2JTXXWs=; b=L4pgTy3QZ6BdeIK9bwrSP7PO9nCmR00rCH1tEZNd/CF8dx73aKNCsShT/m13QaAqV9 N3OQcyFAK6ZsrYLN0odjfmhlmg9iH6DPq6siR67yxrc40kkdklDY0MDgXUcdtpQjiRBB n/ibZBQ77gf9VwBAItg8pJi8fImKtkIp1j7NB+IAW6PbzsR24GU8dfq/UVF+7Bl/z1XD IV1kiAfQNGme02lqc4VcMiJ9ldcxrHoTL2MGXw/+SiAFIBoz9bwGp41p/gakP+ntw9rt WoKWZ26hRS2RyHJgPQEEX0YsFxpe1x2uHEXhXumuZiYCmjGN6BLA58uG5exv5Yw0/8M0 guYQ== X-Gm-Message-State: APjAAAWjQ17Nx2Csgsbf1Sq+6AYR+DELbBoKIZ0DvMzhY1HZUhq6Y0jF hJtociU798AP6BOaOyp42q5heA== X-Google-Smtp-Source: APXvYqxC+UeKU5NKi91Br581QakkL4y4s0iWzgxBCk+lvnaus0NdoX9FH6aPCsJEfd8efqNI4k/Fug== X-Received: by 2002:a05:600c:507:: with SMTP id i7mr31082793wmc.135.1576495309273; Mon, 16 Dec 2019 03:21:49 -0800 (PST) Received: from localhost (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.gmail.com with ESMTPSA id d16sm22991983wrg.27.2019.12.16.03.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 03:21:48 -0800 (PST) References: <20191215114705.24401-1-repk@triplefau.lt> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Martin Blumenstingl , Remi Pommarel Subject: Re: [PATCH v2] clk: meson: pll: Fix by 0 division in __pll_params_to_rate() In-reply-to: Date: Mon, 16 Dec 2019 12:21:47 +0100 Message-ID: <1jmubsbjn8.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_032151_413683_50F99B5E X-CRM114-Status: UNSURE ( 7.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun 15 Dec 2019 at 21:34, Martin Blumenstingl wrote: > On Sun, Dec 15, 2019 at 12:39 PM Remi Pommarel wrote: >> >> Some meson pll registers can be initialized with 0 as N value, introducing >> the following division by 0 when computing rate : >> >> UBSAN: Undefined behaviour in drivers/clk/meson/clk-pll.c:75:9 >> division by zero >> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.4.0-rc3-608075-g86c9af8630e1-dirty #400 >> Call trace: >> dump_backtrace+0x0/0x1c0 >> show_stack+0x14/0x20 >> dump_stack+0xc4/0x100 >> ubsan_epilogue+0x14/0x68 >> __ubsan_handle_divrem_overflow+0x98/0xb8 >> __pll_params_to_rate+0xdc/0x140 >> meson_clk_pll_recalc_rate+0x278/0x3a0 >> __clk_register+0x7c8/0xbb0 >> devm_clk_hw_register+0x54/0xc0 >> meson_eeclkc_probe+0xf4/0x1a0 >> platform_drv_probe+0x54/0xd8 >> really_probe+0x16c/0x438 >> driver_probe_device+0xb0/0xf0 >> device_driver_attach+0x94/0xa0 >> __driver_attach+0x70/0x108 >> bus_for_each_dev+0xd8/0x128 >> driver_attach+0x30/0x40 >> bus_add_driver+0x1b0/0x2d8 >> driver_register+0xbc/0x1d0 >> __platform_driver_register+0x78/0x88 >> axg_driver_init+0x18/0x20 >> do_one_initcall+0xc8/0x24c >> kernel_init_freeable+0x2b0/0x344 >> kernel_init+0x10/0x128 >> ret_from_fork+0x10/0x18 >> >> This checks if N is null before doing the division. >> >> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") >> Signed-off-by: Remi Pommarel > Reviewed-by: Martin Blumenstingl Applied with a slightly more detailed comment. Thx > > thank you for the patch Remi! > > > Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic