From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12399C3F2C6 for ; Sat, 29 Feb 2020 16:33:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D276D20873 for ; Sat, 29 Feb 2020 16:33:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XfX/PEWF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="nzxY5UU1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D276D20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RpjtiDGWE1UcW1cZOu1k4LatA3SwuV010ZNLpioXD38=; b=XfX/PEWFByYmwIAa64omfA82/a XUHDo6/ejBHPPhO+4dLby49Ckq8Jj/hFT1CD82YVyT5cjMJfrq+pk87zyj3FO9WDqeh8YI8P0po5C HBMrhCLYJ42FUu9ouhxgDT3LJLra4uL4hDFIVgmX9mXk0ujwoWkUfP8KdomtXOX6p67hkHojyeGxw hAqvru+opNJX3W4dRcIUvlALi8yHlwtjQupE+h0qpwu4DH1jWufG7nfVWez+vyByClfh8lzyljVqS Jfq1kEVXK5zmSUFFxM5k87n/1Zkgb3UA6brz2ON2duFg7R8vb4R3mlg9BNnvFCKgqm4f8Zh7OcdgG n+WJB0qQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8537-0006kl-Se; Sat, 29 Feb 2020 16:33:09 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j852v-0006bG-OT for linux-amlogic@lists.infradead.org; Sat, 29 Feb 2020 16:32:59 +0000 Received: by mail-wm1-x344.google.com with SMTP id m10so11665649wmc.0 for ; Sat, 29 Feb 2020 08:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=MmoQZpZlPWrh8tlpzt99cxvERHkrSi8XuDSfS2rijvM=; b=nzxY5UU1fHi8dnx4F+cDmxeGdY+lHs2MIoFwJEHbTo1VepgHSSUgQXJQYy74e813Ih N1v0hAytC0y3lMguHm5Eoh5bhMJHxy5e+8D5buaIRyrKsyAYrFbygyQ7VoMl7AvvHvMS RrqGYKgOGPI7J/Wvbf6+fIZ6NUkoUmY0uUKjEAsTf1xYcVaNKwjtBMOgwTki/PVveLKl ALedzhs//KEhgXGwtvyBgCgc4844Ak8kzZDqynE40Y4WUAbIQhu0psEVa3suGSQlHRmH tAe7N0e9KrpeU07x8+lb+jeAaLYCDVIOJCPUK1EyjFW2qUAeyguOsfSpmxDK4VxkR6WZ iptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=MmoQZpZlPWrh8tlpzt99cxvERHkrSi8XuDSfS2rijvM=; b=U/lCUlGNuy702Ct3laLgY+MLvAnbJ8CDPHjCqthH6QGdmTcRdW/iKpzixAyh8hx9s4 dgy6Fbz4O9sjU1sphDYWX8covBuqC5UbUx8ir3T4zBI02wRbzNMLkteA80a52ZePbyJJ ih4JbZf/OHrYcw03ieI11BrwVK/W1kYtUY4GA9eo3O1a14H9NmapFukWx0ysCG6mvaF/ NEZvXV7gucoXXlG54MkObaUiAKPH8Ce/hioVLQi/81kO5CBeaH6StiShk9FNFCv8fDlj srO63tvSuPd97YqJWOMxWLfVj4QKieoS6IVlZzQd4g9Wa7vG/9gjLaGHwcvDMbWg8Iuq 2JHw== X-Gm-Message-State: APjAAAXBjQV05Ua0jwDEc4ymcwWAxpgnSQF138gzZfxkwCBT+8ZeykYI j4a1Ylzip0yh8KaS083AOOCM3Q== X-Google-Smtp-Source: APXvYqzYhKt24uGVo5jYYZUpUV7dNFzOLZTIBANJuiakCE9ZryycLHzgIvos63pwfINlsA/jlg6Glw== X-Received: by 2002:a7b:c939:: with SMTP id h25mr10510856wml.106.1582993975257; Sat, 29 Feb 2020 08:32:55 -0800 (PST) Received: from localhost (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.gmail.com with ESMTPSA id a70sm6761381wme.28.2020.02.29.08.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Feb 2020 08:32:54 -0800 (PST) References: <1582979124-82363-1-git-send-email-christianshewitt@gmail.com> <1582979124-82363-4-git-send-email-christianshewitt@gmail.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Christian Hewitt , Rob Herring , Mark Rutland , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/3] arm64: dts: meson: add support for the SmartLabs SML-5442TW In-reply-to: <1582979124-82363-4-git-send-email-christianshewitt@gmail.com> Date: Sat, 29 Feb 2020 17:32:53 +0100 Message-ID: <1jpndxgxqi.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200229_083257_798039_91BA8C69 X-CRM114-Status: GOOD ( 20.33 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andreas =?utf-8?Q?F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat 29 Feb 2020 at 13:25, Christian Hewitt wrote: > The SmartLabs SML-5442TW is broadly similar to the P231 reference design > but with the following differences: > > - The Yellow and Blue LEDs are available but disabled > - The Red and Green LEDs are used to signal off/on status > - uart_AO can be accessed after opening the case; soldered pins exist > - GPIOX_17 is forced high to enable the QCA9377 module > > Signed-off-by: Christian Hewitt > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dts | 386 +++++++++++++++++++++ > 2 files changed, 387 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index eef0045..6cf8c4a 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-sml5442tw.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dts > new file mode 100644 > index 0000000..3ad53f7 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dts > @@ -0,0 +1,386 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2016 Endless Computers, Inc. > + * Author: Carlo Caione > + * Copyright (c) 2018 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +/dts-v1/; > + > +#include "meson-gxl-s905d.dtsi" > +#include > + [...] > + > + sound { > + compatible = "amlogic,gx-sound-card"; > + model = "GXL-S905D-SML5442TW"; > + audio-aux-devs = <&dio2133>; > + audio-widgets = "Line", "Lineout"; > + audio-routing = "AU2 INL", "ACODEC LOLP", > + "AU2 INR", "ACODEC LORP", > + "AU2 INL", "ACODEC LOLN", > + "AU2 INR", "ACODEC LORN", > + "Lineout", "AU2 OUTL", > + "Lineout", "AU2 OUTR"; > + assigned-clocks = <&clkc CLKID_MPLL2>, > + <&clkc CLKID_MPLL0>, > + <&clkc CLKID_MPLL1>; > + assigned-clock-parents = <0>, <0>, <0>; > + assigned-clock-rates = <294912000>, > + <270950400>, > + <393216000>; > + status = "okay"; > + > + dai-link-0 { > + sound-dai = <&aiu AIU_CPU CPU_I2S_FIFO>; > + }; > + > + dai-link-1 { > + sound-dai = <&aiu AIU_CPU CPU_SPDIF_FIFO>; > + }; > + > + dai-link-2 { > + sound-dai = <&aiu AIU_CPU CPU_I2S_ENCODER>; > + dai-format = "i2s"; > + mclk-fs = <256>; > + > + codec-0 { > + sound-dai = <&aiu AIU_HDMI CTRL_I2S>; > + }; > + > + codec-1 { > + sound-dai = <&aiu AIU_ACODEC CTRL_I2S>; > + }; > + }; > + > + dai-link-3 { > + sound-dai = <&aiu AIU_CPU CPU_SPDIF_ENCODER>; > + > + codec-0 { > + sound-dai = <&spdif_dit>; > + }; > + }; > + > + dai-link-4 { > + sound-dai = <&aiu AIU_HDMI CTRL_OUT>; > + > + codec-0 { > + sound-dai = <&hdmi_tx>; > + }; > + }; > + > + dai-link-5 { > + sound-dai = <&aiu AIU_ACODEC CTRL_OUT>; > + > + codec-0 { > + sound-dai = <&acodec>; > + }; > + }; > + }; > +}; > + > +&acodec { > + AVDD-supply = <&vddio_ao18>; > + status = "okay"; > +}; > + > +&aiu { > + status = "okay"; > + pinctrl-0 = <&spdif_out_h_pins>; > + pinctrl-names = "default"; > + > +}; The above does not compile against kevin's tree: 1# the audio dt device have not been added yet 2# the bindings deps of 3 different subsystem will be available in this tree with the next rc1 I warned about this on IRC. > + > +&cec_AO { > + status = "okay"; > + pinctrl-0 = <&ao_cec_pins>; > + pinctrl-names = "default"; > + hdmi-phandle = <&hdmi_tx>; > +}; > + > +&cvbs_vdac_port { > + cvbs_vdac_out: endpoint { > + remote-endpoint = <&cvbs_connector_in>; > + }; > +}; > + > +ðmac { > + status = "okay"; > + phy-mode = "rmii"; > + phy-handle = <&internal_phy>; > +}; > + > +/* This will enable the bluetooth module */ > +&gpio { > + bt-en { > + gpio-hog; > + gpios = ; > + output-high; > + line-name = "bt-en"; > + }; > +}; > + > +&hdmi_tx { > + status = "okay"; > + pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; > + pinctrl-names = "default"; > + hdmi-supply = <&hdmi_5v>; > +}; > + > +&hdmi_tx_tmds_port { > + hdmi_tx_tmds_out: endpoint { > + remote-endpoint = <&hdmi_connector_in>; > + }; > +}; > + > +&i2c_A { > + status = "okay"; > + pinctrl-0 = <&i2c_a_pins>; > + pinctrl-names = "default"; > +}; > + > +&internal_phy { > + pinctrl-0 = <ð_link_led_pins>, <ð_act_led_pins>; > + pinctrl-names = "default"; > +}; > + > +&ir { > + status = "okay"; > + pinctrl-0 = <&remote_input_ao_pins>; > + pinctrl-names = "default"; > +}; > + > +&pwm_ef { > + status = "okay"; > + pinctrl-0 = <&pwm_e_pins>; > + pinctrl-names = "default"; > + clocks = <&clkc CLKID_FCLK_DIV4>; > + clock-names = "clkin0"; > +}; > + > +&saradc { > + status = "okay"; > + vref-supply = <&vddio_ao18>; > +}; > + > +/* Wireless SDIO Module */ > +&sd_emmc_a { > + status = "okay"; > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + bus-width = <4>; > + cap-sd-highspeed; > + max-frequency = <100000000>; > + > + non-removable; > + disable-wp; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* SD card */ > +&sd_emmc_b { > + status = "okay"; > + pinctrl-0 = <&sdcard_pins>; > + pinctrl-1 = <&sdcard_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + max-frequency = <100000000>; > + disable-wp; > + > + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; > + cd-inverted; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* eMMC */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <100000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* This is connected to the Bluetooth module: */ > +&uart_A { > + status = "okay"; > + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > +}; > + > +/* This UART is brought out to the debug header */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +&usb0 { > + status = "okay"; > +}; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic