From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84146C4321E for ; Fri, 2 Dec 2022 11:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bag6rmytVuDIDhC4JlJHenVvj++Ic+4x1B2NMUEmJew=; b=EpIdicFs0MXxEM XdIv0Vj2TNalgYEiimUpIMTje7ieDzaMHPWKSSkiDvmkrwLftDkLRRCSyzQxkmHJsVdaBimRbfN5E prHrI4nH0IlX3hp8N1yT9xxRaYdfZn09280I70xKX92PczMfKFstvgS3xO0O2x0Eku3qMxPA+pPyd 0tIB2UDO31eCrHcFqndKJSbpI8t4BAdeuUNpYWaPrtrUGHvfYWNVhqx+CCqBUhSFbORV9c7lJ0NdU YVzK1WpA0Yx4wdWGnJdGk1+onfbtxUfz07RjssrvmkKxpucjcL9FvWjUFe9HMlqyPyFwOGB75SLCK fwIEj0aB9dVcfvpgNxVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p14Q1-00G3yS-Ks; Fri, 02 Dec 2022 11:41:25 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p14Pr-00G3u1-AG for linux-amlogic@lists.infradead.org; Fri, 02 Dec 2022 11:41:16 +0000 Received: by mail-wm1-x331.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so6290658wma.1 for ; Fri, 02 Dec 2022 03:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=U4oz8SSnE2zH+GohF5+iQafg1aGfg/iY/5Nv8cvrkb4=; b=aP1kbEov8QRDX8CAf0EiKIgSjoR9E59RSNGByUUnbzuCe5ru95AQQZhUmETCxsJAdF AWYfsLOpV7WDn5Dm53BiK5EXZpqOTUSj8STjci6i185es4QllvkolJ53m/mB7gIUPLZY uwklyYypa5zI+6TabQjjd1GLvNoQ3UvEW76sAl8RqAf4L6wHqeEN+JY2Tfy4HunyesXI gnBmQOlX595zGMJoHtwDDTNkdUl8L0GmNvY34NglMgZef7k1qEhKl7Ff7Qm+mxZuZeXN 85yBSRaRHMg0JYQyN0U2IOsITzL6XDTSLnq8uGU6YJ8Hqr5TN3R/Azd+cNJuTSEQTrep 7Fkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U4oz8SSnE2zH+GohF5+iQafg1aGfg/iY/5Nv8cvrkb4=; b=kOaFno5ldqr09XxQyHB+igte9fQCTZNIQMv/LctDv71zmtuAVlMVHQRhFBxJYPr2/o 7OuZT1cSD1zzMJvq6sBdh8BWbuC3xY7Obl9mBRnsDpJCUtrb8/SHiFM+ds05zpdsPHyN KGNzCHYmwR3o/XFpjbSRYnSR1jOFBRtavmVttxbSrEa3Ja0aaJ2H8vpl6seR4U4DSPWS mbG7Wvj7Uf3IvHEnKmdXR50NIwzvG1TVlIt54p+X4x5THGvv5hMxgrcVYhgULl7/0zIx WBN0wAU4hTaOMWZPpfLhe1S2p6DFYSmwLMrn9VXoEcoNBr2lTd2Op1ToUY679kcjegId UcLw== X-Gm-Message-State: ANoB5plku5cpIPsrfluolvRJfEizYdL6abAqgzInR5A80mSKv7ghvrtY FTSrh7HEcOGFfqdR2SHmfDIkXw== X-Google-Smtp-Source: AA0mqf7sJS6oRW+XfXeDsK6+elCMZNU62vpBmLcePkew8oXw+ClGBjbQ2rPmqjjQkhYcIVYNKacaUQ== X-Received: by 2002:a05:600c:a56:b0:3cf:77a6:2c2e with SMTP id c22-20020a05600c0a5600b003cf77a62c2emr37078202wmq.179.1669981271603; Fri, 02 Dec 2022 03:41:11 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id n14-20020a05600c4f8e00b003c6f3f6675bsm13381928wmq.26.2022.12.02.03.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 03:41:11 -0800 (PST) References: <20221201225703.6507-1-ddrokosov@sberdevices.ru> <20221201225703.6507-7-ddrokosov@sberdevices.ru> User-agent: mu4e 1.8.10; emacs 28.2 From: Jerome Brunet To: Dmitry Rokosov , neil.armstrong@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com Cc: jian.hu@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 06/11] clk: meson: introduce a1-clkc common driver for all A1 clock controllers Date: Fri, 02 Dec 2022 12:36:50 +0100 In-reply-to: <20221201225703.6507-7-ddrokosov@sberdevices.ru> Message-ID: <1jy1rq6nje.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_034115_361448_97C394C5 X-CRM114-Status: GOOD ( 27.79 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri 02 Dec 2022 at 01:56, Dmitry Rokosov wrote: > Generally, A1 SoC has four clock controllers on the board: PLL, > Peripherals, CPU, and Audio. The audio clock controller is different > from others, but the rest are very similar from a functional and regmap > point of view. So a it's good idea to generalize some routines for all > of them. Exactly, meson-a1-clkc driver contains the common probe() flow. > > Signed-off-by: Dmitry Rokosov I think you should leave this out for the initial submission. It makes harder to review. In some case, these factorizations actually the maitenance harder. There is also the s4 that is coming up. It looks similar to the A1 as well. Let's wait for both them to land, see how it goes and then we'll decide if a factorization is appropriate. > --- > drivers/clk/meson/Kconfig | 4 ++ > drivers/clk/meson/Makefile | 1 + > drivers/clk/meson/meson-a1-clkc.c | 63 +++++++++++++++++++++++++++++++ > drivers/clk/meson/meson-a1-clkc.h | 25 ++++++++++++ > 4 files changed, 93 insertions(+) > create mode 100644 drivers/clk/meson/meson-a1-clkc.c > create mode 100644 drivers/clk/meson/meson-a1-clkc.h > > diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig > index bd44ba47200e..1c885541c3a9 100644 > --- a/drivers/clk/meson/Kconfig > +++ b/drivers/clk/meson/Kconfig > @@ -43,6 +43,10 @@ config COMMON_CLK_MESON_CPU_DYNDIV > tristate > select COMMON_CLK_MESON_REGMAP > > +config COMMON_CLK_MESON_A1_CLKC > + tristate > + select COMMON_CLK_MESON_REGMAP > + > config COMMON_CLK_MESON8B > bool "Meson8 SoC Clock controller support" > depends on ARM > diff --git a/drivers/clk/meson/Makefile b/drivers/clk/meson/Makefile > index 0e6f293c05d4..15136d861a65 100644 > --- a/drivers/clk/meson/Makefile > +++ b/drivers/clk/meson/Makefile > @@ -11,6 +11,7 @@ obj-$(CONFIG_COMMON_CLK_MESON_PLL) += clk-pll.o > obj-$(CONFIG_COMMON_CLK_MESON_REGMAP) += clk-regmap.o > obj-$(CONFIG_COMMON_CLK_MESON_SCLK_DIV) += sclk-div.o > obj-$(CONFIG_COMMON_CLK_MESON_VID_PLL_DIV) += vid-pll-div.o > +obj-$(CONFIG_COMMON_CLK_MESON_A1_CLKC) += meson-a1-clkc.o > > # Amlogic Clock controllers > > diff --git a/drivers/clk/meson/meson-a1-clkc.c b/drivers/clk/meson/meson-a1-clkc.c > new file mode 100644 > index 000000000000..2fe320a0e16e > --- /dev/null > +++ b/drivers/clk/meson/meson-a1-clkc.c > @@ -0,0 +1,63 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Amlogic Meson-A1 Clock Controller Driver > + * > + * Copyright (c) 2022, SberDevices. All Rights Reserved. > + * Author: Dmitry Rokosov > + */ > + > +#include > +#include "meson-a1-clkc.h" > + > +static struct regmap_config clkc_regmap_config = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > +}; > + > +int meson_a1_clkc_probe(struct platform_device *pdev) > +{ > + struct meson_a1_clkc_data *clkc; > + struct device *dev = &pdev->dev; > + struct resource *res; > + void __iomem *base; > + struct regmap *map; > + int clkid, i, err; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return dev_err_probe(dev, -ENXIO, "can't get IO resource\n"); > + > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return dev_err_probe(dev, PTR_ERR(base), > + "can't ioremap resource %pr\n", res); > + > + map = devm_regmap_init_mmio(dev, base, &clkc_regmap_config); > + if (IS_ERR(map)) > + return dev_err_probe(dev, PTR_ERR(map), > + "can't init regmap mmio region\n"); > + > + clkc = (struct meson_a1_clkc_data *)of_device_get_match_data(dev); > + if (!clkc) > + return dev_err_probe(dev, -ENODEV, > + "can't get A1 clkc driver data\n"); > + > + /* Populate regmap for the regmap backed clocks */ > + for (i = 0; i < clkc->num_regs; i++) > + clkc->regs[i]->map = map; > + > + for (clkid = 0; clkid < clkc->hw->num; clkid++) { > + err = devm_clk_hw_register(dev, clkc->hw->hws[clkid]); > + if (err) > + return dev_err_probe(dev, err, > + "clock registration failed\n"); > + } > + > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > + (void *)clkc->hw); > +} > +EXPORT_SYMBOL_GPL(meson_a1_clkc_probe); > + > +MODULE_AUTHOR("Dmitry Rokosov "); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/clk/meson/meson-a1-clkc.h b/drivers/clk/meson/meson-a1-clkc.h > new file mode 100644 > index 000000000000..503eca0f6cb5 > --- /dev/null > +++ b/drivers/clk/meson/meson-a1-clkc.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Amlogic Meson-A1 Clock Controller driver > + * > + * Copyright (c) 2022, SberDevices. All Rights Reserved. > + * Author: Dmitry Rokosov > + */ > + > +#ifndef __MESON_A1_CLKC_H__ > +#define __MESON_A1_CLKC_H__ > + > +#include > +#include > +#include > + > +#include "clk-regmap.h" > + > +struct meson_a1_clkc_data { > + const struct clk_hw_onecell_data *hw; > + struct clk_regmap *const *regs; > + size_t num_regs; > +}; > + > +int meson_a1_clkc_probe(struct platform_device *pdev); > +#endif _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic