From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB823C19F2C for ; Mon, 1 Aug 2022 08:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XkI9Sgh/cn2LGoK5cehyeuXAWdxek5UBC8nEcejvp0s=; b=BZ7/z8mV4Z+I3c zm+ynLTTmtpNt8m03Ri33jBEZIhZ3u5zwGj6KjkAh8eUZVhhPzzZK0fEX9Vh1LlvKID4fVa5nZ9C4 Lzi/aMbOhYIvexb0uCHDJnN+SPV56bUfWAAn/K5CiplFm1TA/bFqMRhBHzmyA5/8HHh/KoEq7xwD3 lPjFMK3RvqsRkXfWf84jcHgU+pKCkZbokT/igv29myOCevqhffF5N15aHOjObDxGA42+bqIeOvfP2 CyGbFE0UfGuTNaBYjp07sC1nQK2h2GvCSx+FtS0MQLm8Et6JkpV9ykR8GvE8l38MCcPmUITqJzdWj ygzFom53Kgu3t0ROZc5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIR8A-0049lg-GH; Mon, 01 Aug 2022 08:50:30 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIR84-0049hg-S0 for linux-amlogic@lists.infradead.org; Mon, 01 Aug 2022 08:50:28 +0000 Received: by mail-wm1-x335.google.com with SMTP id v131-20020a1cac89000000b003a4bb3f786bso1338471wme.0 for ; Mon, 01 Aug 2022 01:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc; bh=31O8ovLNtTNvEXUXIG07xH4GCHGVnpgSiTE7ih01mcI=; b=DEVZa/eNJ/hpFhH4u1Bs4bQp+4ZzM5ExT+7Ewp7B16j1EbDEf6ldaYV79hhefRl12K 8RWl2VqNYaPc5GvZfjow5F7qnoqIeFVE65dWd7WsgGeaWfnx3Su1ab6fRZ9KDybec4UX 5KA9zzSf+cjNV8RQHCGlbxdMRStGPxqLHoeli9UADZN9lSlKhf3zqGs2Ezu1AR+9oapr eRjLPE60/SiMRYPHSuqXdZVtZlPT5FZMmQbLeSGgMBF2M4wSo/JXj/fOU9II3hDjTn9w N+Chk96Dg3DwMR9TQI6iW69qU6hFeZ7SriOhqY741066BGXHvcFn2ZTUllyjVuQ7d48I fNug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=31O8ovLNtTNvEXUXIG07xH4GCHGVnpgSiTE7ih01mcI=; b=eQXvP/ltBrxYJ0uuE/20RvL3FA41ZumCpoFHXuCSMJdwQrtGPHv8hSzW4jYjGf3oon K8d24vdZa0AxQ9ewuWQ3tDize5PHaqlF0+Fbs89yAS0SyByzCX98DLVUFISjMNV36bHs RE+qkswtj2OMdAgICwbWApH7+JfPmlvpnMmZ/iTfK8OR41v8ilhrrjPNKrmJMEya80WJ xAGui9nSZPKtFd8A8wOwa9kYAiMvhe/Bd+sYwVxLElgaDpExHuMYKylpPWW60HYLAbdC eKeweL1C/AAuHTooQQbJhavrX1pfk8fQVWE7UKsrStKZ0XVFh7WxJ1iN6/AZ+czbAvSE cuaw== X-Gm-Message-State: AJIora872u/KJ0ynsPGS7nSpp5wYziYvYKV3dg8R6rF6VDNBMPBgYxBM Aal6sF+lXWpUJRHJ0WMXhdTa5w== X-Google-Smtp-Source: AGRyM1v0rDwsCTzsOFZJWkATMcBdINS/2/Y+B2iG7/TtU913pUZQ3zG7JgtLkTnd3S6+dFK5HwIWWA== X-Received: by 2002:a05:600c:2044:b0:3a3:15a1:ddfd with SMTP id p4-20020a05600c204400b003a315a1ddfdmr10506355wmg.3.1659343822506; Mon, 01 Aug 2022 01:50:22 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id a1-20020adfe5c1000000b0021e491fd250sm4810200wrn.89.2022.08.01.01.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 01:50:21 -0700 (PDT) References: <88d6ef05-f77a-57a2-f34a-e3998a8d70d4@gmail.com> User-agent: mu4e 1.8.6; emacs 27.1 From: Jerome Brunet To: Da Xue , Heiner Kallweit Cc: Martin Blumenstingl , "netdev@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , "linux-rockchip@lists.infradead.org" Subject: Re: Meson GXL and Rockchip PHY based on same IP? Date: Mon, 01 Aug 2022 10:45:09 +0200 In-reply-to: Message-ID: <1jzggowdo5.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_015025_168477_1C583886 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon 01 Aug 2022 at 03:09, Da Xue wrote: > On Sat, Jul 30, 2022 at 3:31 PM Heiner Kallweit wrote: >> >> On 30.07.2022 19:06, Martin Blumenstingl wrote: >> > Hi Heiner, >> > >> > On Sat, Jul 30, 2022 at 5:59 PM Heiner Kallweit wrote: >> >> >> >> Meson GXL and Rockchip ethernet PHY drivers have quite something in common. >> >> They share a number of non-standard registers, using the same bits >> >> and same bank handling. This makes me think they they may be using >> >> the same IP. However they have different quirk handling. But this >> >> doesn't rule out that actually they would need the same quirk handling. >> > You made me curious and I found the following public Microchip >> > LAN83C185 datasheet: [0] >> > Page 27 has a "SMI REGISTER MAPPING" which matches the definitions in >> > meson-gxl.c. >> > Also on page 33 the interrupt source bits are a 100% match with the >> > INTSRC_* marcos in meson-gxl.c >> > >> Great, thanks for investigating! >> >> > Whether this means that: >> > - Amlogic SoCs embed a LAN83C185 >> > - LAN83C185 is based on the same IP core (possibly not even designed >> > by Amlogic or SMSC) >> > - the SMI interface design is something that one hardware engineer >> > brought from one company to another >> > - ...something else >> > is something I can't tell > > Per Jerome, both are OmniPHY IP. > I believe it to be the case, yes. However, the version of the IP could be different. The integration the SoC vendor did is very likely to be different too. I'd be in favor of keeping things the way they are now. I don't think merging the drivers now is really worth the effort. With the uncertainty there is around SoC integration, It could bring more problems that it solves down the line. > >> > >> > >> > Best regards, >> > Martin >> > >> > >> > [0] https://ww1.microchip.com/downloads/en/DeviceDoc/LAN83C185-Data-Sheet-DS00002808A.pdf >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic