From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Thu, 23 Mar 2017 21:34:04 +0100 Subject: [PATCH v4 05/10] i2c: meson: use full 12 bits for clock divider In-Reply-To: References: <1a2ecdc8-a326-a7a7-22ec-658fd147daf4@gmail.com> Message-ID: <20170323203404.nuobb4wtgsepnilu@ninjato> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org > + /* clock divider has 12 bits */ > + WARN_ON(div >= (1 << 12)); Do you insist on WARN_ON? I wonder what it gives over dev_err? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: