From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 00/11] clk: implement clock rate protection mechanism
Date: Sun, 21 May 2017 23:59:47 +0200 [thread overview]
Message-ID: <20170521215958.19743-1-jbrunet@baylibre.com> (raw)
This Patchset is related the RFC [0] and the discussion around
CLK_SET_RATE_GATE available here [1]
The goal of this patchset is to provide a way for consumers to inform the
system that they depend on the rate of the clock source and can't tolerate
other consumers changing the rate or causing glitches.
With this series there is 3 use-case:
- the provider is not protected: nothing changes
- the provider is protected by only 1 consumer (and only once), then only
this consumer will be able to alter the rate of the clock, as it is the
only one depending on it.
- If the provider is protected more than once, or by the provider itself,
the rate is basically locked.
The last 2 patches provide the same functionnality for providers themself
by fixing CLK_SET_RATE_GATE (enforce clock gating along the tree)
qcom, at91 and ux500 are the heaviest users of this flag. If anybody having
one these platform could try this series, I would help build confidence
that they are relying on CLK_SET_RATE_GATE being broken.
Changes since RFC:
- s/clk_protect/clk_rate_protect
- Request rework around core_nolock function
- Add clk_set_rate_protect
- Reword clk_rate_protect and clk_unprotect documentation
- Add few comments to explain the code
- Add 2 last patches to fix users of CLK_SET_RATE_GATE
Changes since v1:
- Add patch 4: Check if the rate would actually change before continuing, a
possibly in clk_set_rate.
This was tested with the audio use case mentioned in [1]
[0]: http://lkml.kernel.org/r/20170321183330.26722-1-jbrunet at baylibre.com
[1]: http://lkml.kernel.org/r/148942423440.82235.17188153691656009029 at resonance
Jerome Brunet (11):
clk: take the prepare lock out of clk_core_set_parent
clk: add clk_core_set_phase_nolock function
clk: rework calls to round and determine rate callbacks
clk: use round rate to bail out early in set_rate
clk: add support for clock protection
clk: add clk_set_rate_protect
clk: rollback set_rate_range changes on failure
clk: cosmetic changes to clk_summary debugfs entry
clk: fix incorrect usage of ENOSYS
clk: fix CLK_SET_RATE_GATE with clock rate protection
clk: move CLK_SET_RATE_GATE protection from prepare to enable
drivers/clk/clk.c | 429 ++++++++++++++++++++++++++++++++++++-------
include/linux/clk-provider.h | 1 +
include/linux/clk.h | 43 +++++
3 files changed, 403 insertions(+), 70 deletions(-)
--
2.9.4
next reply other threads:[~2017-05-21 21:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 21:59 Jerome Brunet [this message]
2017-05-21 21:59 ` [PATCH v2 01/11] clk: take the prepare lock out of clk_core_set_parent Jerome Brunet
2017-05-25 18:54 ` Michael Turquette
2017-05-29 9:35 ` Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 02/11] clk: add clk_core_set_phase_nolock function Jerome Brunet
2017-05-23 9:35 ` Adriana Reus
2017-05-23 9:48 ` Jerome Brunet
2017-05-25 18:58 ` Michael Turquette
2017-05-21 21:59 ` [PATCH v2 03/11] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-05-25 20:13 ` Michael Turquette
2017-05-21 21:59 ` [PATCH v2 04/11] clk: use round rate to bail out early in set_rate Jerome Brunet
2017-05-25 20:20 ` Michael Turquette
2017-05-29 9:12 ` Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 05/11] clk: add support for clock protection Jerome Brunet
2017-05-25 20:58 ` Michael Turquette
2017-05-29 9:15 ` Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 06/11] clk: add clk_set_rate_protect Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 07/11] clk: rollback set_rate_range changes on failure Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 08/11] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 09/11] clk: fix incorrect usage of ENOSYS Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 10/11] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2017-05-23 13:42 ` Adriana Reus
2017-05-23 15:09 ` Jerome Brunet
2017-05-21 21:59 ` [PATCH v2 11/11] clk: move CLK_SET_RATE_GATE protection from prepare to enable Jerome Brunet
2017-05-29 9:17 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521215958.19743-1-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®