mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 09/10] clk: fix incorrect usage of ENOSYS
Date: Mon, 12 Jun 2017 21:44:37 +0200	[thread overview]
Message-ID: <20170612194438.12298-10-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170612194438.12298-1-jbrunet@baylibre.com>

ENOSYS is special and should only be used for incorrect syscall number.
It does not seem to be the case here.

Reported by checkpatch.pl while working on clock protection.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 8d57e130c4e0..5d545954c48f 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2032,7 +2032,7 @@ static int clk_core_set_parent_nolock(struct clk_core *core,
 
 	/* verify ops for for multi-parent clks */
 	if ((core->num_parents > 1) && (!core->ops->set_parent))
-		return -ENOSYS;
+		return -EPERM;
 
 	/* check that we are allowed to re-parent if the clock is in use */
 	if ((core->flags & CLK_SET_PARENT_GATE) && core->prepare_count)
-- 
2.9.4

  parent reply	other threads:[~2017-06-12 19:44 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 19:44 [PATCH v3 00/10] clk: implement clock rate protection mechanism Jerome Brunet
2017-06-12 19:44 ` [PATCH v3 01/10] clk: take the prepare lock out of clk_core_set_parent Jerome Brunet
2017-07-12  1:21   ` Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 02/10] clk: add clk_core_set_phase_nolock function Jerome Brunet
2017-07-12  1:22   ` Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 03/10] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-07-12  1:49   ` Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 04/10] clk: use round rate to bail out early in set_rate Jerome Brunet
2017-07-12  2:00   ` Stephen Boyd
2017-07-26 17:13     ` Jerome Brunet
2017-08-04  0:32       ` Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 05/10] clk: add support for clock protection Jerome Brunet
2017-07-26  0:12   ` Stephen Boyd
2017-07-26 17:18     ` Jerome Brunet
2017-08-04  0:18       ` Stephen Boyd
2017-08-08 22:37         ` Michael Turquette
2017-08-09  2:19           ` Stephen Boyd
2017-08-09 11:45             ` Russell King - ARM Linux
2017-08-09 13:34               ` Jerome Brunet
2017-08-09 13:40                 ` Russell King - ARM Linux
2017-08-09 13:45                   ` Jerome Brunet
2017-08-10 16:48                   ` Michael Turquette
2017-08-10 16:46               ` Michael Turquette
2017-08-09 13:07             ` Jerome Brunet
2017-08-09 12:18           ` Jerome Brunet
2017-08-10 16:54             ` Michael Turquette
2017-06-12 19:44 ` [PATCH v3 06/10] clk: add clk_set_rate_protect Jerome Brunet
2017-07-26  0:59   ` Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 07/10] clk: rollback set_rate_range changes on failure Jerome Brunet
2017-07-12  2:02   ` Stephen Boyd
2017-07-26 17:22     ` Jerome Brunet
2017-06-12 19:44 ` [PATCH v3 08/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-07-12  2:02   ` Stephen Boyd
2017-06-12 19:44 ` Jerome Brunet [this message]
2017-07-12  2:03   ` [PATCH v3 09/10] clk: fix incorrect usage of ENOSYS Stephen Boyd
2017-06-12 19:44 ` [PATCH v3 10/10] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2017-06-20  9:07 ` [PATCH v3 00/10] clk: implement clock rate protection mechanism Linus Walleij
2017-06-20 10:50   ` Jerome Brunet
2017-06-20 11:54     ` Linus Walleij
2017-06-20 12:32       ` Jerome Brunet
2017-06-20 12:47         ` Boris Brezillon
2017-06-22  7:07           ` Quentin Schulz
2017-06-22 10:09             ` Jerome Brunet
2017-06-20 15:29         ` Linus Walleij
2017-06-21 13:15         ` Jerome Brunet
2017-07-12  1:16           ` Stephen Boyd
2017-07-26 17:05             ` Jerome Brunet
2017-07-27 22:44               ` Stephen Boyd
2017-08-08 22:40                 ` Michael Turquette
2017-08-09 12:14                   ` Jerome Brunet
2017-07-11 21:04 ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612194438.12298-10-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®