From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 2/6] ARM: smp_scu: add a helper for powering on a specific CPU
Date: Mon, 14 Aug 2017 11:52:18 +0100 [thread overview]
Message-ID: <20170814105218.GG20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170728212138.12217-3-martin.blumenstingl@googlemail.com>
On Fri, Jul 28, 2017 at 11:21:34PM +0200, Martin Blumenstingl wrote:
> +/*
> + * Set the executing CPUs power mode to SCU_PM_NORMAL.
> + *
> + * This function must be called with preemption disabled, and as it
> + * has the side effect of disabling coherency, caches must have been
> + * flushed. Interrupts must also have been disabled.
This comment looks rather misleading for several reasons:
1. we're bringing another CPU to normal power mode, which means it's
coming _into_ coherency, not leaving coherency, so "side effect of
disabling coherency" is wrong.
2. what has the state of the _local_ CPUs caches got to do with the
remote CPU when it isn't even powered up?
Could you please reword this comment to be more accurate please - I
think the paragraph can be removed.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-08-14 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 21:21 [PATCH v5 0/6] SMP and CPU hotplug support for Meson8/Meson8b Martin Blumenstingl
2017-07-28 21:21 ` [PATCH v5 1/6] dt-bindings: Amlogic: Add Meson8 and Meson8b SMP related documentation Martin Blumenstingl
2017-07-28 21:21 ` [PATCH v5 2/6] ARM: smp_scu: add a helper for powering on a specific CPU Martin Blumenstingl
2017-08-14 10:52 ` Russell King - ARM Linux [this message]
2017-07-28 21:21 ` [PATCH v5 3/6] ARM: smp_scu: allow the platform code to read the SCU CPU status Martin Blumenstingl
2017-07-28 21:21 ` [PATCH v5 4/6] ARM: meson: Add SMP bringup code for Meson8 and Meson8b Martin Blumenstingl
2017-07-28 21:21 ` [PATCH v5 5/6] ARM: dts: meson8: add support for booting the secondary CPU cores Martin Blumenstingl
2017-07-28 21:21 ` [PATCH v5 6/6] ARM: dts: meson8b: " Martin Blumenstingl
2017-08-13 18:30 ` [PATCH v5 0/6] SMP and CPU hotplug support for Meson8/Meson8b Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814105218.GG20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®