From: linus.luessing@c0d3.blue (Linus Lüssing)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: meson8b: extending ethernet controller description
Date: Thu, 28 Sep 2017 04:23:46 +0200 [thread overview]
Message-ID: <20170928022346.GB6726@otheros> (raw)
In-Reply-To: <aecccf76841a035f8dc5cc23dadfad66fbbac03e.1506507688.git.ingrassia@epigenesys.com>
On Wed, Sep 27, 2017 at 11:39:53PM +0200, Emiliano Ingrassia wrote:
> This patch corrects the meson8b-dwmac reg attributes updated by the previous
> 2/4 patch (450a483abe07f8d903c6cb74091592743975a8eb).
> The second addresses range, taken from S805 (aka Meson8b) SoC manual,
> was not correct.
>
> [..]
> ðmac {
> - clocks = <&clkc CLKID_ETH>;
> - clock-names = "stmmaceth";
> + compatible = "amlogic,meson8b-dwmac", "snps,dwmac-3.70a", "snps,dwmac";
> +
> + interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 14 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "macirq",
> + "eth_lpi";
> +
> + clock-names = "stmmaceth", "clkin0", "clkin1";
> + clocks = <&clkc CLKID_ETH>,
> + <&clkc CLKID_FCLK_DIV2>,
> + <&clkc CLKID_MPLL2>;
> +
> + resets = <&reset RESET_ETHERNET>;
> + reset-names = "stmmaceth";
> +
> + rx-fifo-depth=<4000>;
> + tx-fifo-depth=<2000>;
> };
Hi Emiliano,
Did you accidentally delete instead of replace the reg values?
(or are there default values hidden somewhere else?)
Also, please don't forget to add a v2/v3/etc. next time,
makes it easier to follow here and in Patchwork, thanks :-).
And thanks a lot at looking into ethernet support as well. Will
try this patchset soon, too! You guys are killing it :D!
Regards, Linus
next prev parent reply other threads:[~2017-09-28 2:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 10:39 [PATCH 0/4] meson8b-odroidc1: ethernet support Emiliano Ingrassia
2017-09-27 10:40 ` [PATCH 1/4] clk: meson8b: keep mpll2 clock enabled Emiliano Ingrassia
2017-09-28 7:11 ` Jerome Brunet
2017-09-28 9:59 ` Emiliano Ingrassia
2017-09-28 15:08 ` Jerome Brunet
2017-09-28 21:29 ` Martin Blumenstingl
2017-09-30 17:08 ` Emiliano Ingrassia
2017-09-27 10:40 ` [PATCH 2/4] ARM: dts: meson8b: extending ethernet controller description Emiliano Ingrassia
2017-09-27 10:41 ` [PATCH 3/4] ARM: dts: meson8b-odroidc1: enabling ethernet support Emiliano Ingrassia
2017-09-27 10:46 ` [PATCH 4/4] net: stmmac: fixing DMA reset sleep and timeout values Emiliano Ingrassia
2017-09-27 21:39 ` [PATCH 2/4] ARM: dts: meson8b: extending ethernet controller description Emiliano Ingrassia
2017-09-28 2:23 ` Linus Lüssing [this message]
2017-09-28 10:31 ` Emiliano Ingrassia
2017-09-28 21:41 ` Martin Blumenstingl
2017-09-29 19:10 ` Emiliano Ingrassia
2017-09-30 14:09 ` Martin Blumenstingl
2017-11-21 15:36 ` Emiliano Ingrassia
2017-11-26 21:02 ` Martin Blumenstingl
2017-11-26 21:58 ` Martin Blumenstingl
2017-12-04 22:37 ` Emiliano Ingrassia
2017-12-16 23:39 ` Martin Blumenstingl
2017-12-18 20:07 ` Emiliano Ingrassia
2017-10-02 19:54 ` [PATCH 0/4] meson8b-odroidc1: ethernet support Linus Lüssing
2017-10-06 8:10 ` Emiliano Ingrassia
2017-11-21 11:57 ` Linus Lüssing
2017-11-21 15:40 ` Emiliano Ingrassia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928022346.GB6726@otheros \
--to=linus.luessing@c0d3.blue \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®