From: dan.carpenter@oracle.com (Dan Carpenter)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/2] mmc: meson-mx-sdio: return correct error code
Date: Fri, 13 Oct 2017 14:19:43 +0300 [thread overview]
Message-ID: <20171013111943.zyp5myiwb3pp56vh@mwanda> (raw)
This has a copy and paste bug so we use "host->fixed_factor_clk" which
is a valid pointer instead of "host->cfg_div_clk" which holds the error
code.
Fixes: 0aa0fb9cd239 ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
index 19b499bbe691..dc30ed5e964b 100644
--- a/drivers/mmc/host/meson-mx-sdio.c
+++ b/drivers/mmc/host/meson-mx-sdio.c
@@ -621,7 +621,7 @@ static int meson_mx_mmc_register_clks(struct meson_mx_mmc_host *host)
host->cfg_div_clk = devm_clk_register(host->controller_dev,
&host->cfg_div.hw);
if (WARN_ON(PTR_ERR_OR_ZERO(host->cfg_div_clk)))
- return PTR_ERR(host->fixed_factor_clk);
+ return PTR_ERR(host->cfg_div_clk);
return 0;
}
next reply other threads:[~2017-10-13 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 11:19 Dan Carpenter [this message]
2017-10-13 11:20 ` [PATCH 2/2] mmc: meson-mx-sdio: Cleanup IS_ERR() checks Dan Carpenter
2017-10-13 19:02 ` Martin Blumenstingl
2017-10-20 10:02 ` Ulf Hansson
2017-10-13 18:58 ` [PATCH 1/2] mmc: meson-mx-sdio: return correct error code Martin Blumenstingl
2017-10-20 10:02 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013111943.zyp5myiwb3pp56vh@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®