From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Sat, 18 Nov 2017 08:19:47 +0000 Subject: [PATCH 0/6] mmc: Handle platform_get_irq's error checking and return In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> Message-ID: <20171118081947.GX31757@n2100.armlinux.org.uk> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Sat, Nov 18, 2017 at 01:58:16AM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct and and we must check its return value. IRQ 0 is not a valid interrupt. The correct test here is <= 0. Please rework your patches for this. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync@8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up