From: martin.blumenstingl@googlemail.com (Martin Blumenstingl)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 0/2] meson-saradc: add chip temperature support
Date: Sun, 4 Nov 2018 00:10:22 +0100 [thread overview]
Message-ID: <20181103231024.659-1-martin.blumenstingl@googlemail.com> (raw)
The meson-saradc allows switching the input of channel #6 between an
actual ADC pad and the SoC's internal temperature sensor.
On the 64-bit SoCs the SCPI firmware reads the chip temperature using
the SAR ADC. Thus the 64-bit SoCs simply expose the temperature through
the "arm,scpi-sensors" interface (and so Linux doesn't have to program
the SAR ADC for temperature readings).
The 32-bit SoCs however don't have any SCPI firmware. Thus we need to
configure the SAR ADC in Linux to get the chip temperature. To make it
work we need two changes to the existing dt-bindings:
- we have to get the TSC (temperature sensor calibration coefficient)
from the eFuse (where it has been programmed to the correct value in
the manufacturing process). the SAR ADC needs the TSC value, otherwise
it returns only garbage readings
- we need to get a phandle to the new HHI syscon region because on
Meson8b and Meson8m2 the TSC is five bits wide (on Meson8 it's only
four bits wide) but only four bits are stored inside the SAR ADC's
memory region. The upper most bit (not all five bits, only one out of
five) is stored at a seemingly random register HHI_DPLL_TOP_0) in the
HHI register area.
This also requires changes to the clock controller where we don't have
a solution where everyone's happy with the dt-bindings (see the
discussion in [0]) - so this will be added in a future series.
changes since v1 at [1]:
- (many thanks to Peter Meerwald-Stadler and Jonathan Cameron for taking
the time to review my patches)
- use "MESON_SAR_ADC_" as naming schema for two new #defines
- remove .indexed = 0 (because it's already the default) from
MESON_SAR_ADC_TEMP_CHAN
- simplify setting MESON_SAR_ADC_DELTA_10_TEMP_SEL in
meson_sar_adc_enable_channel
- remove IIO_CHAN_INFO_ENABLE (abuse) from MESON_SAR_ADC_TEMP_CHAN
- register the channel set depending on whether the temperature sensor
can be used or not (instead of exposing the info whether it can be
used through the "ENABLE" element)
- shorten check for MESON_SAR_ADC_EFUSE_BYTE3_IS_CALIBRATED
- dropped Meson8b and Meson8m2 support for now (see the HHI register
discussion mentioned above). I still plan to add support for these
SoCs, but I don't want to add any code to the SAR ADC driver before
we have a decision on the dt-bindings of the clock driver (where we
need to write one bit from the SAR ADC driver for the temperature
sensor calibration coefficient).
- dropped the .dts changes for now since the useful part was adding
iio-hwmon on Meson8b and Meson8m2 boards. now that support for these
two SoCs is postponed we can wait with the .dts changes as well.
[0] https://patchwork.kernel.org/cover/10658527/
[1] https://patchwork.kernel.org/cover/10658551/
Martin Blumenstingl (2):
dt-bindings: iio: adc: meson-saradc: add temperature sensor support
iio: adc: meson-saradc: add support for the chip's temperature sensor
.../bindings/iio/adc/amlogic,meson-saradc.txt | 6 +
drivers/iio/adc/meson_saradc.c | 229 ++++++++++++++++--
2 files changed, 209 insertions(+), 26 deletions(-)
--
2.19.1
next reply other threads:[~2018-11-03 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 23:10 Martin Blumenstingl [this message]
2018-11-03 23:10 ` [PATCH v2 1/2] dt-bindings: iio: adc: meson-saradc: add temperature sensor support Martin Blumenstingl
2018-11-04 16:58 ` Jonathan Cameron
2018-11-05 22:16 ` Rob Herring
2018-11-03 23:10 ` [PATCH v2 2/2] iio: adc: meson-saradc: add support for the chip's temperature sensor Martin Blumenstingl
2018-11-04 17:00 ` Jonathan Cameron
2018-11-04 22:36 ` Martin Blumenstingl
2018-11-11 15:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181103231024.659-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®