From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 9 Nov 2018 21:13:07 +0100 Subject: [PATCH net-next v3 1/2] net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt In-Reply-To: References: <203c4d9e-f39a-7a08-46c3-4ee6e61f181e@gmail.com> Message-ID: <20181109201307.GV5259@lunn.ch> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hi Heiner > +static bool phy_drv_supports_irq(struct phy_driver *phydrv) > +{ > + return phydrv->config_intr || phydrv->ack_interrupt; > +} Should this be && not || ? I thought both needed to be provided for interrupts to work. Andrew