From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAC6C43387 for ; Fri, 11 Jan 2019 18:21:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8734121841 for ; Fri, 11 Jan 2019 18:21:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ixmwtLKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8734121841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=epigenesys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xcUxtzz4wwpH2LOsMaZJtYyhsJRzn6IJ3z54aa1tOtg=; b=ixmwtLKn4G6Q8h umEUVevBK2hxunAJyAuaqzgBk/uFVB8Z6NJL6df/8PvtBpbXU+HIyPl0IoAaI7fN1lJnlXS06LPeH j2TEsISRYA4P92I4zGa04ekKILeQj9Bh/aQ+MfmIf72KcLK51mRCxLp3J25f/wB8+dPNdgH9kAmtr /U9yAWKRnrRiDgcyGp3zQit35+iOTq22uA5sPY8j2u8+AWmHf33niwLdi9MomdKoNteRkGDSVj4ku fuKBH3km/mLsMKSDg9VJ+lUnh6gwKZMJBD4paxPX/wnk9Mmb994FOFH7Saa8iE2Zrt4t1+pRviuT2 Vo8Ngx1AGz2lFnU9rGHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gi1Qy-0003eP-9L; Fri, 11 Jan 2019 18:21:32 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gi1Qv-0003dy-Ti; Fri, 11 Jan 2019 18:21:31 +0000 Received: by mail-wr1-f67.google.com with SMTP id t6so16148940wrr.12; Fri, 11 Jan 2019 10:21:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CXQMb3CYoxZvEBGoFLf3XqN+Sy8lNJon5xeR0SKttEQ=; b=lqYwXZ0BtcJ61vKFP0PAxqPw26kUwe9IybUOKCSwZ1LeuVFStgw6FWYLZbHgrAGUbd rQf9IIIEBdn7iJKDYExGeaHDoEMUVWo56hpGwWkCHVL+a7QL+ljyNtL4i99UsBxNCi3S gYM7uN3rDVOT4DuKUXoNLxDYnZMef2De8rQ4hxUEuEm9SNhxrwnWni190l2VEdFpWJdH wo92+qvjm3A8uOSQT9a9Mya3gBsAb+iEHkKq+wwMiJqGmr+s03G7OX8I0X8Q5Ip2rp5r cUyujOhE8C13x45VkDgKHP4xlpOHzhaH9AghOTZzzStdJaHeM/WLkOXn5tWSswDQjYtF phHQ== X-Gm-Message-State: AJcUukevPkEK1oeKPpOExl5cYHF1WxrNN9036RHI/A0ZWeZOaJ9ucp4Q 22vU8m38jEAgKb4IuElL8sHzCBwG X-Google-Smtp-Source: ALg8bN4fYziC++OXve0ga78/Oef9cqm1AGM6vL7wECICvMlTC/n/gbWa8+Fwy7Zx6t1yMvaQ51EWyg== X-Received: by 2002:adf:e509:: with SMTP id j9mr15436184wrm.76.1547230887888; Fri, 11 Jan 2019 10:21:27 -0800 (PST) Received: from ingrassia.epigenesys.com (host194-85-static.3-79-b.business.telecomitalia.it. [79.3.85.194]) by smtp.gmail.com with ESMTPSA id o5sm32667437wmg.25.2019.01.11.10.21.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 10:21:27 -0800 (PST) Date: Fri, 11 Jan 2019 19:21:24 +0100 From: Emiliano Ingrassia To: Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH v3 1/2] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins Message-ID: <20190111182124.GA4420@ingrassia.epigenesys.com> References: <20181229143556.27339-1-martin.blumenstingl@googlemail.com> <20181229143556.27339-2-martin.blumenstingl@googlemail.com> <7hzhs8ovag.fsf@baylibre.com> <20190111100915.GA1716@ingrassia.epigenesys.com> <7hbm4noypt.fsf@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7hbm4noypt.fsf@baylibre.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190111_102129_953802_F731FE5E X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, jianxin.pan@amlogic.com, linus.luessing@c0d3.blue Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Kevin, On Fri, Jan 11, 2019 at 10:06:54AM -0800, Kevin Hilman wrote: > Emiliano Ingrassia writes: > > > Hi Kevin, > > > > sorry to bother you. > > No need to apologize. > > > On Thu, Jan 10, 2019 at 05:08:39PM -0800, Kevin Hilman wrote: > >> Martin Blumenstingl writes: > >> > >> > Gigabit Ethernet requires the Ethernet TXD0..3 and RXD0..3 data lines. > >> > Add the missing eth_rxd2 and eth_rxd3 definitions so we don't have to > >> > rely on the bootloader to set them up correctly. > >> > > >> > The vendor u-boot sources for Odroid-C1 use the following Ethernet > >> > pinmux configuration: > >> > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_6, 0x3f4f); > >> > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_7, 0xf00000); > >> > This translates to the following pin groups in the mainline kernel: > >> > - register 6 bit 0: eth_rxd1 (DIF_0_P) > >> > - register 6 bit 1: eth_rxd0 (DIF_0_N) > >> > - register 6 bit 2: eth_rx_dv (DIF_1_P) > >> > - register 6 bit 3: eth_rx_clk (DIF_1_N) > >> > - register 6 bit 6: eth_tx_en (DIF_3_P) > >> > - register 6 bit 8: eth_ref_clk (DIF_3_N) > >> > - register 6 bit 9: eth_mdc (DIF_4_P) > >> > - register 6 bit 10: eth_mdio_en (DIF_4_N) > >> > - register 6 bit 11: eth_tx_clk (GPIOH_9) > >> > - register 6 bit 12: eth_txd2 (GPIOH_8) > >> > - register 6 bit 13: eth_txd3 (GPIOH_7) > >> > - register 7 bit 20: eth_txd0_0 (GPIOH_6) > >> > - register 7 bit 21: eth_txd1_0 (GPIOH_5) > >> > - register 7 bit 22: eth_rxd3 (DIF_2_P) > >> > - register 7 bit 23: eth_rxd2 (DIF_2_N) > >> > > >> > All functions except eth_rxd2 and eth_rxd3 are already supported by the > >> > pinctrl-meson8b driver. > >> > > >> > Suggested-by: Jianxin Pan > >> > Signed-off-by: Martin Blumenstingl > >> > >> Reviewed-by: Kevin Hilman > > > > For both patches of this series I gave: > > Tested-by: Emiliano Ingrassia > > Reviewed-by: Emiliano Ingrassia > > > > They were in the answer to the cover letter of this series. > > I note that they were not included in the commit message of the first patch. > > > > Did I miss something or did something wrong? > > Please, let me know. > > You did everything fine, I just missed them. > > I've started relying a bit more heavily on patchwork to collect > review/test tags, and right now it doesn't notice tags to the > cover-letter, only to individual patches, so I typically add those by > hand, but in this case I missed them. > Good to know, I'll keep it in mind next time. > Sorry about that, and thanks for the reminder. I'll add them and > repush. > > And, while I'm thinking about it, I'll request that feature to patchwork > developers. > > Kevin > > Thank you for the explanation! Best regards, Emiliano _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic