From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C839C43381 for ; Mon, 25 Mar 2019 08:50:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2925F20863 for ; Mon, 25 Mar 2019 08:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SO2T5HRK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2925F20863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WG2NY2SbZ+rgzSV8vqjWMv088gcuxUNBiZlRcwoE280=; b=SO2T5HRKz2jWh5 LSeFaDr4UycbEVlt2C8XhO0KWFr/3JEMPke+sK8kkEJ7lTY1SWcQhWRoUoOvEGYpebbiZc9Vpt8gP 1itv3p9QZ94eSQ6dSf9t0JDc0q2++1d+WeMQPaDI+0GOB6MetBdYXZvP+J7dagO9wR/2eAUK1Q1DK 0RqIxacyUg10RG7JNE61cLPqAzzVUs3yInojuyOBAjyq3baIo8nYSDCxL+MvyIPGaFXnxvqHYj1ky W9IL25VurYoGBtrBGwM65XNDqoHaA935p6MMZnhNkSFBm7iBbt5TV4pbYXxtqlpLz9Fpj8k45tuLI pveVfa2AwF0hpBT0O+0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8LJb-000594-Ca; Mon, 25 Mar 2019 08:50:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8LJY-00058P-Bf for linux-amlogic@lists.infradead.org; Mon, 25 Mar 2019 08:50:41 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h8LJW-0001dy-02; Mon, 25 Mar 2019 09:50:38 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1h8LJV-0005sp-LY; Mon, 25 Mar 2019 09:50:37 +0100 Date: Mon, 25 Mar 2019 09:50:37 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Subject: Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue Message-ID: <20190325085037.f4weycbhaa7yyurt@pengutronix.de> References: <20190324220217.15813-1-martin.blumenstingl@googlemail.com> <20190325084153.l44pzfewcqlkoaoe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325084153.l44pzfewcqlkoaoe@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_015040_561295_8A96EB41 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hello, On Mon, Mar 25, 2019 at 09:41:53AM +0100, Uwe Kleine-K=F6nig wrote: > If you want to implement further cleanups, my questions and propositions > are: > = > - Is there a publicly available manual for this hardware? If yes, you > can add a link to it in the header of the driver. > = > - Why do you handle reparenting of the PWM's clk in .request? Wouldn't > this be more suitable in .apply? > = > - Does stopping the PWM (i.e. clearing MISC_{A,B}_EN in the MISC_AB > register) freeze the output, or is the currently running period > completed first? (The latter is the right behaviour.) > = > - Please point out in the header that for changing period/duty > cycle/polarity the hardware must be stopped. (I suggest to apply the > style used in https://www.spinics.net/lists/linux-pwm/msg09262.html > for some consistency.) Another thing I just noted: The .get_state callback only sets .enabled but nothing of the remaining information is provided. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic