mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] phy: socionext: get optional clock by devm_clk_get_optional()
Date: Mon, 01 Apr 2019 18:15:19 +0900	[thread overview]
Message-ID: <20190401181519.2595.4A936039@socionext.com> (raw)
In-Reply-To: <f3370a0619d40c40676ed029cc04a3ed1c12b991.1553914418.git.chunfeng.yun@mediatek.com>

Hi,

This looks good to me.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thanks,

On Sat, 30 Mar 2019 17:11:37 +0800
Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:

> Use devm_clk_get_optional() to get optional clock
> 
> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/phy/socionext/phy-uniphier-usb3hs.c | 10 +++-------
>  drivers/phy/socionext/phy-uniphier-usb3ss.c | 10 +++-------
>  2 files changed, 6 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/phy/socionext/phy-uniphier-usb3hs.c b/drivers/phy/socionext/phy-uniphier-usb3hs.c
> index b1b048be6166..50f379fc4e06 100644
> --- a/drivers/phy/socionext/phy-uniphier-usb3hs.c
> +++ b/drivers/phy/socionext/phy-uniphier-usb3hs.c
> @@ -335,13 +335,9 @@ static int uniphier_u3hsphy_probe(struct platform_device *pdev)
>  	if (IS_ERR(priv->clk_parent))
>  		return PTR_ERR(priv->clk_parent);
>  
> -	priv->clk_ext = devm_clk_get(dev, "phy-ext");
> -	if (IS_ERR(priv->clk_ext)) {
> -		if (PTR_ERR(priv->clk_ext) == -ENOENT)
> -			priv->clk_ext = NULL;
> -		else
> -			return PTR_ERR(priv->clk_ext);
> -	}
> +	priv->clk_ext = devm_clk_get_optional(dev, "phy-ext");
> +	if (IS_ERR(priv->clk_ext))
> +		return PTR_ERR(priv->clk_ext);
>  
>  	priv->rst = devm_reset_control_get_shared(dev, "phy");
>  	if (IS_ERR(priv->rst))
> diff --git a/drivers/phy/socionext/phy-uniphier-usb3ss.c b/drivers/phy/socionext/phy-uniphier-usb3ss.c
> index 4be95679c7d8..ec231e40ef2a 100644
> --- a/drivers/phy/socionext/phy-uniphier-usb3ss.c
> +++ b/drivers/phy/socionext/phy-uniphier-usb3ss.c
> @@ -238,13 +238,9 @@ static int uniphier_u3ssphy_probe(struct platform_device *pdev)
>  		if (IS_ERR(priv->clk))
>  			return PTR_ERR(priv->clk);
>  
> -		priv->clk_ext = devm_clk_get(dev, "phy-ext");
> -		if (IS_ERR(priv->clk_ext)) {
> -			if (PTR_ERR(priv->clk_ext) == -ENOENT)
> -				priv->clk_ext = NULL;
> -			else
> -				return PTR_ERR(priv->clk_ext);
> -		}
> +		priv->clk_ext = devm_clk_get_optional(dev, "phy-ext");
> +		if (IS_ERR(priv->clk_ext))
> +			return PTR_ERR(priv->clk_ext);
>  
>  		priv->rst = devm_reset_control_get_shared(dev, "phy");
>  		if (IS_ERR(priv->rst))
> -- 
> 2.20.1

---
Best Regards,
Kunihiko Hayashi



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2019-04-01  9:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  9:11 [PATCH 1/4] phy: phy-mtk-tphy: " Chunfeng Yun
2019-03-30  9:11 ` [PATCH 2/4] phy: qcom-qusb2: " Chunfeng Yun
2019-03-30  9:11 ` [PATCH 3/4] phy: socionext: " Chunfeng Yun
2019-04-01  9:15   ` Kunihiko Hayashi [this message]
2019-03-30  9:11 ` [PATCH 4/4] phy: phy-meson-gxl-usb2: " Chunfeng Yun
2019-03-31 20:39   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401181519.2595.4A936039@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=kishon@ti.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®