From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80E3C4321A for ; Tue, 11 Jun 2019 15:37:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 774AE2080A for ; Tue, 11 Jun 2019 15:37:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YYCOd/Jq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 774AE2080A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HUbej98l/rlMQ+mCzQfmatfeVCTsPNenbEGvX7PqMLc=; b=YYCOd/Jq1wvcJq vdospuHzObraeWOnvV4TPb+FeGNXTEewhy7cLu+AFN6Nedr6n9lNlrs9+6lwtozeNq3t07AsQTvxP l8hnHFxLgX7DKtOnZd/WNglW7uqOOcXOT9bzgzgiYb6Va1TPyPYCPOmsBpc69fxjm3Sj5QdEV8w6k BiFtpjHMCpLI0YW/LyMQpWPZsIfRT9raaJEogxU2K1SSBbTFWAV873ELZ7v7T4mCKQMFyJALPY5X/ nh+4T4MgMB8Ru5xce9ak0rozKRrWSl6sgh35wY309ffxvphw8BX/UeEoATpz/AMz0BLWWuB3Sw94c 2+hBcIbEfMh3s462rFZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haiqE-0006bt-QU; Tue, 11 Jun 2019 15:37:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haipy-0006Ok-PP for linux-amlogic@lists.infradead.org; Tue, 11 Jun 2019 15:37:28 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haipw-000382-M3; Tue, 11 Jun 2019 17:37:24 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1haipw-0004sA-4S; Tue, 11 Jun 2019 17:37:24 +0200 Date: Tue, 11 Jun 2019 17:37:24 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Subject: Re: [PATCH v2 02/14] pwm: meson: use devm_clk_get_optional() to get the input clock Message-ID: <20190611153724.fg34zp6vof7lpcgl@pengutronix.de> References: <20190608180626.30589-1-martin.blumenstingl@googlemail.com> <20190608180626.30589-3-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190608180626.30589-3-martin.blumenstingl@googlemail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_083726_995870_FE9F13F9 X-CRM114-Status: UNSURE ( 8.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, thierry.reding@gmail.com, kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Jun 08, 2019 at 08:06:14PM +0200, Martin Blumenstingl wrote: > Simplify the code which fetches the input clock for a PWM channel by > using devm_clk_get_optional(). > This comes with a small functional change: previously all errors except > EPROBE_DEFER were ignored. Now all other errors are also treated as > errors. If no input clock is present devm_clk_get_optional() will return > NULL instead of an error which matches the behavior of the old code. > = > Signed-off-by: Martin Blumenstingl > Reviewed-by: Neil Armstrong Nitpick: Put your S-o-b last. Otherwise this ends as Sgned-off-by: Martin Blumenstingl Rviewed-by: Neil Armstrong Sgned-off-by: Thierry Reding and this implies that Thierry added Neil's tag. (Typos are done on purpose to not confuse patchwork.) Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic