From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B3AC4321A for ; Tue, 11 Jun 2019 15:38:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACE4B2089E for ; Tue, 11 Jun 2019 15:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GRrPjTyv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACE4B2089E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=33BYUi8ht8MNx5h8halvMerCguF1NEDd3ME1R5EbppI=; b=GRrPjTyvwUeW13 l0oU6ewYyhVLApcSsznrcDt29hw/b9VuiKsqGq0Zzn/eqslJjZjHL7zWFAT2gdzkmnNmZ506CsJ0G W595Afq15JMKnp32l1oKQVIAcc+mb7Q+vWNjaLA64VpLxUW5CjrfSTNtUhbLVuTRJQd16KWd4DTBX 95DTPmoSxN92ObLb3ULXRbzJC7RMhMZHqJdjmuE01GBZOF9H9sS18vzq7bRpbrd9rN+aSga+51dvu XeYXmWhYSsQeVQc70pcNsgfo3uH0uRaJscAIm2nN/y1RcSGJ90UQRk1ls+9hc0s0Ed6odnxmEEb7a w9glblLWO3oKl6CNGQ9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haiqv-0006zn-EI; Tue, 11 Jun 2019 15:38:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haiqg-0006mw-BM for linux-amlogic@lists.infradead.org; Tue, 11 Jun 2019 15:38:11 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haiqe-0003Ik-F4; Tue, 11 Jun 2019 17:38:08 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1haiqe-0004sJ-5Y; Tue, 11 Jun 2019 17:38:08 +0200 Date: Tue, 11 Jun 2019 17:38:08 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Blumenstingl Subject: Re: [PATCH v2 03/14] pwm: meson: use GENMASK and FIELD_PREP for the lo and hi values Message-ID: <20190611153808.oljoea7ohzpm26zy@pengutronix.de> References: <20190608180626.30589-1-martin.blumenstingl@googlemail.com> <20190608180626.30589-4-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190608180626.30589-4-martin.blumenstingl@googlemail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_083810_559823_82BECC89 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Jun 08, 2019 at 08:06:15PM +0200, Martin Blumenstingl wrote: > meson_pwm_calc() ensures that "lo" is always less than 16 bits wide > (otherwise it would overflow into the "hi" part of the REG_PWM_{A,B} > register). > Use GENMASK and FIELD_PREP for the lo and hi values to make it easier to > spot how wide these are internally. Additionally this is a preparation > step for the .get_state() implementation where the GENMASK() for lo and > hi becomes handy because it can be used with FIELD_GET() to extract the > values from the register REG_PWM_{A,B} register. > = > No functional changes intended. > = > Signed-off-by: Martin Blumenstingl > Reviewed-by: Neil Armstrong Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic