From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93CDC7618B for ; Mon, 29 Jul 2019 17:57:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1A5E206BA for ; Mon, 29 Jul 2019 17:57:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UdHHSqcs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1A5E206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gazz/NcRqlDUw5uE9/o2y3iVjYSLUgkhqahq9+B987M=; b=UdHHSqcsFoW4mV GFPsw64Rv0MEWro2Wni2gTu1yXOwB4bI6IsEiZ5RjDPgif1tbVI6Zw0XiUF5Oba6BL2B51W7a1tGY 4b4WnO5gnZUzrDOa/+2AakzA/6p6KE5YeDpJxvTz8Psro9w6HC/vquOXmVUxORvbpcKS7Lh1TuYx/ 4I14xKiMlVn3IxoYJ7NasIqvAqVJk3EBJ3gESsF6KbxgnK/TIW158npY2kj+AoCj1tL0qBXgZvNWS GUxFCDQW65JvpVksBEKUVseocCZnpGa38C+HsJD/sWT6TBkznAaLUQT6b+OQtCwnojYrLCYBh/P1Q 9ZzDVsXexXHpFdxNMlfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs9tz-0005tp-OI; Mon, 29 Jul 2019 17:57:39 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs9tw-0005rd-Ea; Mon, 29 Jul 2019 17:57:37 +0000 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6124B14015B10; Mon, 29 Jul 2019 10:57:32 -0700 (PDT) Date: Mon, 29 Jul 2019 10:57:31 -0700 (PDT) Message-Id: <20190729.105731.2008954478313187190.davem@davemloft.net> To: martin.blumenstingl@googlemail.com Subject: Re: [PATCH] net: stmmac: manage errors returned by of_get_mac_address() From: David Miller In-Reply-To: <20190727192137.27881-1-martin.blumenstingl@googlemail.com> References: <20190727192137.27881-1-martin.blumenstingl@googlemail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 29 Jul 2019 10:57:32 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_105736_487889_6875A216 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joabreu@synopsys.com, linux-amlogic@lists.infradead.org, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Martin Blumenstingl Date: Sat, 27 Jul 2019 21:21:37 +0200 > Commit d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") > added support for reading the MAC address from an nvmem-cell. This > required changing the logic to return an error pointer upon failure. > > If stmmac is loaded before the nvmem provider driver then > of_get_mac_address() return an error pointer with -EPROBE_DEFER. > > Propagate this error so the stmmac driver will be probed again after the > nvmem provider driver is loaded. > Default to a random generated MAC address in case of any other error, > instead of using the error pointer as MAC address. > > Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") > Signed-off-by: Martin Blumenstingl Applied, thanks. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic