From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AB8C33CA9 for ; Sun, 12 Jan 2020 00:16:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 480A920866 for ; Sun, 12 Jan 2020 00:16:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OEqPQ5Jv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="uZapQ+by" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 480A920866 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4U14nO12M+dUmwPGMFQUjXagtfrnQABmsL+hJiFfCGg=; b=OEqPQ5Jv6YaZQh Nj0JHr3R5+UyQswgydlfAWsj3z+ul5WD5nL4MXl/E5THbkMJdsFbVSs8SibgviMj+jDOOY0ZuVyjr KmRGj+eCfV8rD+1bQqv3uIGzEC2IwygOAH28W+dV9Ibgc2DAwVUUVqtwW9wnc8mDgk1mqq1shJTmn 6lb9CqKMNnO2Z3FnDpSISrMBH7NiHXv/OZjBLRRPGbYbcSwLOX1vKnfvaJ6PXBQNeNZXVvduibNMQ +VDLEG7nybCc7mBDbw20FeJm9o4D73tJVMPgH1e8wQKGauIETI17njgZbYC9G2PdlhYJ3r4nVtJwC uMRxIxESIUHDujmoQ1zA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqQvw-0005dU-FH; Sun, 12 Jan 2020 00:16:48 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqQvt-0005cL-R2; Sun, 12 Jan 2020 00:16:47 +0000 Received: by mail-wr1-x444.google.com with SMTP id t2so5221484wrr.1; Sat, 11 Jan 2020 16:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjUv0l8hskCQu/sfhTW+zT+JFalMEnxaLpHc5wjsSrk=; b=uZapQ+by1rty3HyhlkQGQkL4kSQRFma4TxmcNEsHnvBp7pkpTBMBX3vgVUMG3/IClu IdHTMtYLKZeVzzvg+Qfdyi/l7s5XskJDnMxZRuZsGRBMoTHlDD+YnLEQHQ5eS3CFXphI HIDuL1wMXLwd/+ib2+jlhodUqkboDBpYVhCZ5GkTDadamEcaOfwQJfCx6JGEM9subtBS xfJqEWOS4NkPl+/XTRZ0RgtsvZMJu96IjLswacwCUb09BNsTfFjIpPpEW6Fjh+gXEaQ5 2Sm1qgWUR++mXkO7AZvhOE5GSRKeOomTQo9+/4P8ZcgDTlCPaCdNAgc4uKiDO5BU5VQB r3Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjUv0l8hskCQu/sfhTW+zT+JFalMEnxaLpHc5wjsSrk=; b=aVqtFESxvitsYbrcQzVnUXKragsBo/IRyEMAKPeS3vJ3ckG2TbDkVDReVA+Z5IY/c6 CjHvXsUA21tnZuksJiGbF34SG7iB0R6LoGddE8UaBcYQcOsbWIkrgAKHnhZhE0ciKAbB O9mYgrx9qc+GxK75fOWrRQK5U5DEtPuEDrqfzxWcDpTA2VJqr7G68DKrXraTjAlyu5mG f1Bk16Tfy5VJxxSDCteTeNn1TAs9G2Rh/DuVsxXuY7xUEY9lJV4FOdmXq1t/9hQcFaZa PlO5IAmAsyZJySA4vG7vQZkTLSph3tNbe/8UiLAnkAWHl9dzyEje365AqXjEyBlvtoZM uXDA== X-Gm-Message-State: APjAAAX0Y7HCTzdx+iRLfHo0dLrV1tk41bYTqYCul/y9jVfoL9SS5JQq nIjlN0xFG49eQZF1vYXQ5H0= X-Google-Smtp-Source: APXvYqwxgbwC6cX6oTmsyFU5iWJhMbjSDPZ+lTlZ+fPIHUdsXfTc9BQoIDqOEKQOSfKrzV9ga6hutw== X-Received: by 2002:a5d:44cd:: with SMTP id z13mr10795278wrr.104.1578788203919; Sat, 11 Jan 2020 16:16:43 -0800 (PST) Received: from localhost.localdomain (p200300F1373A1900428D5CFFFEB99DB8.dip0.t-ipconnect.de. [2003:f1:373a:1900:428d:5cff:feb9:9db8]) by smtp.googlemail.com with ESMTPSA id h66sm8575535wme.41.2020.01.11.16.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2020 16:16:43 -0800 (PST) From: Martin Blumenstingl To: dri-devel@lists.freedesktop.org, alyssa@rosenzweig.io, steven.price@arm.com, tomeu.vizoso@collabora.com, robh@kernel.org Subject: [PATCH RFT v2 0/3] devfreq fixes for panfrost Date: Sun, 12 Jan 2020 01:16:20 +0100 Message-Id: <20200112001623.2121227-1-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200111_161645_899860_B411D74C X-CRM114-Status: UNSURE ( 8.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, Martin Blumenstingl , linux-rockchip@lists.infradead.org, daniel@ffwll.ch, sudeep.holla@arm.com, linux-amlogic@lists.infradead.org, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org These are a bunch of devfreq fixes for panfrost that came up in a discussion with Robin Murphy during the code-review of the lima devfreq patches: [0] I am only able to test patch #1 properly because the only boards with panfrost GPU that I have are using an Amlogic SoC. We don't have support for the OPP tables or dynamic clock changes there yet. So patches #2 and #3 are compile-tested only. Changes since v1 at [1] - added Steven's Reviewed-by to patch #2 (thank you!) - only use dev_pm_opp_put_regulators() to clean up in panfrost_devfreq_init() if regulators_opp_table is not NULL to fix a potential crash inside dev_pm_opp_put_regulators() as spotted by Steven Price (thank you!). While here, I also switched to "goto err" pattern to avoid lines with more than 80 characters. Known discussion topics (I have no way to test either of these, so I am looking for help here): - Steven Price reported the following message on his firefly (RK3288) board: "debugfs: Directory 'ffa30000.gpu-mali' with parent 'vdd_gpu' already present!" - Robin Murphy suggested that patch #1 may not work once the OPP table for the GPU comes from SCMI [0] https://patchwork.freedesktop.org/patch/346898/ [1] https://patchwork.freedesktop.org/series/71744/ Martin Blumenstingl (3): drm/panfrost: enable devfreq based the "operating-points-v2" property drm/panfrost: call dev_pm_opp_of_remove_table() in all error-paths drm/panfrost: Use the mali-supply regulator for control again drivers/gpu/drm/panfrost/panfrost_devfreq.c | 44 +++++++++++++++++---- drivers/gpu/drm/panfrost/panfrost_device.h | 1 + 2 files changed, 37 insertions(+), 8 deletions(-) -- 2.24.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic